Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7531

Improve the concurrent access on FsVolumeList

    Details

    • Target Version/s:

      Description

      FsVolumeList uses synchronized to protect the update on FsVolumeList#volumes, while various operations (e.g., checkDirs(), getAvailable()) iterate volumes without protection.

      This JIRA proposes to use AtomicReference to encapture volumes to provide better concurrent access.

      1. HDFS-7531.000.patch
        19 kB
        Lei (Eddy) Xu
      2. HDFS-7531.001.patch
        20 kB
        Lei (Eddy) Xu
      3. HDFS-7531.002.patch
        20 kB
        Lei (Eddy) Xu

        Issue Links

          Activity

          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          This patch changes FsVolumeList#volumes from volatile List<FsVolumeImpl> to AtomicReference<FsVolumeImpl[]>.

          Show
          eddyxu Lei (Eddy) Xu added a comment - This patch changes FsVolumeList#volumes from volatile List<FsVolumeImpl> to AtomicReference<FsVolumeImpl[]> .
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12687403/HDFS-7531.000.patch
          against trunk revision c379e10.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9047//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9047//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687403/HDFS-7531.000.patch against trunk revision c379e10. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9047//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9047//console This message is automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          The failed test is not related. I have verified this test locally on a linux machine.

          Show
          eddyxu Lei (Eddy) Xu added a comment - The failed test is not related. I have verified this test locally on a linux machine.
          Hide
          cmccabe Colin P. McCabe added a comment -

          addVolume: I would prefer not to have this be synchronized. Instead, we can simply use a loop with AtomicReference#compareAndSet to ensure that our modification doesn't collide with a concurrent modification.

          Same comment for removeVolume.

          +1 once that is addressed

          Show
          cmccabe Colin P. McCabe added a comment - addVolume : I would prefer not to have this be synchronized. Instead, we can simply use a loop with AtomicReference#compareAndSet to ensure that our modification doesn't collide with a concurrent modification. Same comment for removeVolume . +1 once that is addressed
          Hide
          wheat9 Haohui Mai added a comment -

          Looks good to me. Just a minor nit:

          -    List<byte[]> blocksVolumeIds = new ArrayList<byte[]>(volumes.volumes.size());
          +    List<byte[]> blocksVolumeIds = new ArrayList<byte[]>(curVolumes.size());
          

          It can be simplified as

          +    List<byte[]> blocksVolumeIds = new ArrayList<>(curVolumes.size());
          

          Since we're on Java 7.

          Show
          wheat9 Haohui Mai added a comment - Looks good to me. Just a minor nit: - List< byte []> blocksVolumeIds = new ArrayList< byte []>(volumes.volumes.size()); + List< byte []> blocksVolumeIds = new ArrayList< byte []>(curVolumes.size()); It can be simplified as + List< byte []> blocksVolumeIds = new ArrayList<>(curVolumes.size()); Since we're on Java 7.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks for the reviews, Colin P. McCabe and Haohui Mai !

          I updated the patch to use compareAndSet instead of synchronized for addVolume and removeVolume.

          Also changed to use JDK 7 features.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks for the reviews, Colin P. McCabe and Haohui Mai ! I updated the patch to use compareAndSet instead of synchronized for addVolume and removeVolume . Also changed to use JDK 7 features.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12687594/HDFS-7531.001.patch
          against trunk revision 565d72f.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration

          The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestFileCreation

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9056//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9056//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687594/HDFS-7531.001.patch against trunk revision 565d72f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestFileCreation Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9056//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9056//console This message is automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, Eddy.

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, Eddy.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Oops, just found two minor comment issues when I was going to commit this.

            /**
             * Read access to this atomic reference array is not synchronized.
             * This list is replaced on modification holding "this" lock.
             */
          

          Can you remove this comment? It is no longer accurate because we don't hold the "this" lock when replacing the atomic reference. I don't think we need the first part, either... it's assumed that objects in AtomicReference are accessed locklessly unless otherwise noted.

            /**
             * Returns a unmodifiable list view of all the volumes.
             * Note that this list is unmodifiable.
             */
          

          This comment is a bit redundant. If it's an "unmodifiable list" then we don't need to also note that it is unmodifiable. Let's get rid of the second line, and change unmodifiable to "immutable" since that's more idiomatic

          thanks

          Show
          cmccabe Colin P. McCabe added a comment - Oops, just found two minor comment issues when I was going to commit this. /** * Read access to this atomic reference array is not synchronized . * This list is replaced on modification holding " this " lock. */ Can you remove this comment? It is no longer accurate because we don't hold the "this" lock when replacing the atomic reference. I don't think we need the first part, either... it's assumed that objects in AtomicReference are accessed locklessly unless otherwise noted. /** * Returns a unmodifiable list view of all the volumes. * Note that this list is unmodifiable. */ This comment is a bit redundant. If it's an "unmodifiable list" then we don't need to also note that it is unmodifiable. Let's get rid of the second line, and change unmodifiable to "immutable" since that's more idiomatic thanks
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks for the suggestions Colin P. McCabe.

          I updated the patch based on your comments.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks for the suggestions Colin P. McCabe . I updated the patch based on your comments.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12687810/HDFS-7531.002.patch
          against trunk revision f2d150e.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9061//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9061//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687810/HDFS-7531.002.patch against trunk revision f2d150e. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9061//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9061//console This message is automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, Eddy

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, Eddy
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #6743 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6743/)
          HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #6743 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6743/ ) HDFS-7531 . Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks for the reviews, Colin P. McCabe and Haohui Mai!

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks for the reviews, Colin P. McCabe and Haohui Mai !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #45 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/45/)
          HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #45 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/45/ ) HDFS-7531 . Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #779 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/779/)
          HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #779 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/779/ ) HDFS-7531 . Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #42 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/42/)
          HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #42 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/42/ ) HDFS-7531 . Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1977 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1977/)
          HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1977 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1977/ ) HDFS-7531 . Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #46 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/46/)
          HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #46 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/46/ ) HDFS-7531 . Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1996 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1996/)
          HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1996 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1996/ ) HDFS-7531 . Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe) (cmccabe: rev 3b173d95171d01ab55042b1162569d1cf14a8d43) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Sangjin Lee backported this to 2.6.1, with minor changes to accomodate older JDKs. I just pushed the commit to 2.6.1 after running compilation and TestFsDatasetImpl which changed in the patch.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Sangjin Lee backported this to 2.6.1, with minor changes to accomodate older JDKs. I just pushed the commit to 2.6.1 after running compilation and TestFsDatasetImpl which changed in the patch.

            People

            • Assignee:
              eddyxu Lei (Eddy) Xu
              Reporter:
              eddyxu Lei (Eddy) Xu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development