Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This jira proposes to consolidate encryption zone related implementation to a single class.

      1. HDFS-7529.000.patch
        33 kB
        Haohui Mai
      2. HDFS-7529.001.patch
        33 kB
        Haohui Mai
      3. HDFS-7529-002.patch
        35 kB
        Rakesh R
      4. HDFS-7529-003.patch
        35 kB
        Rakesh R
      5. HDFS-7529-004.patch
        35 kB
        Rakesh R
      6. HDFS-7529-005.patch
        35 kB
        Rakesh R

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12687427/HDFS-7529.000.patch
        against trunk revision c379e10.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
        org.apache.hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9048//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9048//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687427/HDFS-7529.000.patch against trunk revision c379e10. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager org.apache.hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9048//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9048//console This message is automatically generated.
        Hide
        clamb Charles Lamb added a comment -

        Hi Haohui Mai,

        Thanks for looking into this. I have a few comments and then a bunch of formatting nits that are introduced as part of this patch.

        FSDirEncryptionZoneOp.java:

        In #ensureKeysAreInitialized, why do you return if provider, keyName, or metadata or null? The existing code would throw an exception, which the new code eventually does, but not before it has waited around to take the writeLock(). Wouldn't it be better to fail fast in this case? Did you copy the wrong code to #ensureKeysAreInitialized?

        Likewise, I think that the checks for nullness of provider, keyName, and metadata can be removed from #createEncryptionZoneInt, right?

        These two lines:

        +    final byte[][] pathComponents =
        +      FSDirectory.getPathComponentsForReservedPath(src);
        +    FSPermissionChecker pc = fsn.getPermissionChecker();
        

        are now inside the FSN#writeLock(). I suppose that's not the end of the world, but every little bit of extra code inside the writeLock() hurts. Same issue with the call to #logAuditEvent (for the failure case only) being inside the writeLock() now. IWBNI that call could be moved out of the scope of the lock.

        The same general comment for #getEZForPath. auditStat can be made final in that method.

        Formatting issues:

        You introduced a newline at the end of #createEncryptionZone.

        #getFileEncryptionInfo. The formatting for the call to getEZForPath is weird. Bump the 'iip);' up a line. In that same method, the call to unprotectedGetXAttrByName busts the 80 char limit. I realize that this was already in the codebase before this patch, but it was introduced in the previous Jira (the one which introduced FSDirXAttrOp) so we might as well fix it now for cleanliness purposes.

        In #createEncryptionZoneInt, the block comment did not get re-indented -2 when you moved it so it's out of alignment now.

        FSNamesystem.java:

        Call to FSDirEncryptionZoneOp.getFileEncryptionInfo could use some formatting. It exceeds the 80 char limit. Ditto the call to #generateEncryptedDataEncryptionKey.

        FSDirStatAndListingOp.java:

        Lines 204 and 423 exceed the 80 char limit.

        Show
        clamb Charles Lamb added a comment - Hi Haohui Mai , Thanks for looking into this. I have a few comments and then a bunch of formatting nits that are introduced as part of this patch. FSDirEncryptionZoneOp.java: In #ensureKeysAreInitialized, why do you return if provider, keyName, or metadata or null? The existing code would throw an exception, which the new code eventually does, but not before it has waited around to take the writeLock(). Wouldn't it be better to fail fast in this case? Did you copy the wrong code to #ensureKeysAreInitialized? Likewise, I think that the checks for nullness of provider, keyName, and metadata can be removed from #createEncryptionZoneInt, right? These two lines: + final byte [][] pathComponents = + FSDirectory.getPathComponentsForReservedPath(src); + FSPermissionChecker pc = fsn.getPermissionChecker(); are now inside the FSN#writeLock(). I suppose that's not the end of the world, but every little bit of extra code inside the writeLock() hurts. Same issue with the call to #logAuditEvent (for the failure case only) being inside the writeLock() now. IWBNI that call could be moved out of the scope of the lock. The same general comment for #getEZForPath. auditStat can be made final in that method. Formatting issues: You introduced a newline at the end of #createEncryptionZone. #getFileEncryptionInfo. The formatting for the call to getEZForPath is weird. Bump the 'iip);' up a line. In that same method, the call to unprotectedGetXAttrByName busts the 80 char limit. I realize that this was already in the codebase before this patch, but it was introduced in the previous Jira (the one which introduced FSDirXAttrOp) so we might as well fix it now for cleanliness purposes. In #createEncryptionZoneInt, the block comment did not get re-indented -2 when you moved it so it's out of alignment now. FSNamesystem.java: Call to FSDirEncryptionZoneOp.getFileEncryptionInfo could use some formatting. It exceeds the 80 char limit. Ditto the call to #generateEncryptedDataEncryptionKey. FSDirStatAndListingOp.java: Lines 204 and 423 exceed the 80 char limit.
        Hide
        wheat9 Haohui Mai added a comment -

        Wouldn't it be better to fail fast in this case? Did you copy the wrong code to #ensureKeysAreInitialized?

        Likewise, I think that the checks for nullness of provider, keyName, and metadata can be removed from #createEncryptionZoneInt, right?

        Duplicating the checks is intentional to define well-formed steps as it is implied by the name ensureKeysAreInitialized().

        are now inside the FSN#writeLock(). I suppose that's not the end of the world, but every little bit of extra code inside the writeLock() hurts.

        The performance benefit is minimal as getPermissionChecker() eventually synchronized in the UserGroupInformation#getCurrentUser(). Making it consistent with other operations allows the further refactoring.

        Show
        wheat9 Haohui Mai added a comment - Wouldn't it be better to fail fast in this case? Did you copy the wrong code to #ensureKeysAreInitialized? Likewise, I think that the checks for nullness of provider, keyName, and metadata can be removed from #createEncryptionZoneInt, right? Duplicating the checks is intentional to define well-formed steps as it is implied by the name ensureKeysAreInitialized() . are now inside the FSN#writeLock(). I suppose that's not the end of the world, but every little bit of extra code inside the writeLock() hurts. The performance benefit is minimal as getPermissionChecker() eventually synchronized in the UserGroupInformation#getCurrentUser() . Making it consistent with other operations allows the further refactoring.
        Hide
        wheat9 Haohui Mai added a comment -

        The v1 patch fixes various formatting issues in the v0 patch.

        Show
        wheat9 Haohui Mai added a comment - The v1 patch fixes various formatting issues in the v0 patch.
        Hide
        clamb Charles Lamb added a comment -

        Hi @wheat9,

        While the .001 patch fixes the formatting issues, the larger problem is that by calling provider.getMetadata() inside the lock, you're doing an RPC (inside the lock). While it is true that you may have been able to contact the KMS during ensureKeysAreInitialized, that may not be true when you try later and there can be an arbitrarily long delay. BTW, there's a plurality mismatch between ensureKeysAreInitialized (plural) and the method it calls (generateEncryptedDataEncryptionKey, which is singular).

        Charles

        Show
        clamb Charles Lamb added a comment - Hi @wheat9, While the .001 patch fixes the formatting issues, the larger problem is that by calling provider.getMetadata() inside the lock, you're doing an RPC (inside the lock). While it is true that you may have been able to contact the KMS during ensureKeysAreInitialized, that may not be true when you try later and there can be an arbitrarily long delay. BTW, there's a plurality mismatch between ensureKeysAreInitialized (plural) and the method it calls (generateEncryptedDataEncryptionKey, which is singular). Charles
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12687849/HDFS-7529.001.patch
        against trunk revision 0da1330.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9065//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9065//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687849/HDFS-7529.001.patch against trunk revision 0da1330. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9065//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9065//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12687849/HDFS-7529.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10687/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12687849/HDFS-7529.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10687/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12687849/HDFS-7529.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10693/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12687849/HDFS-7529.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10693/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Haohui Mai, I'd like to take this ahead to the completion. As per the offline discussion, am attaching a patch. I hope I've addressed the above comments. Please take a look at the patch when you get a chance. Thanks!

        Following are the major changes:

        • I feel provider.getMetadata() is not required to do twice as the 'provider' has provider.warmUpEncryptedKeys(keyName); warming up logic. Does this sound good to you ?
        • modified few codes under the lock section.
        • rebased in latest trunk code
        Show
        rakeshr Rakesh R added a comment - Haohui Mai , I'd like to take this ahead to the completion. As per the offline discussion, am attaching a patch. I hope I've addressed the above comments. Please take a look at the patch when you get a chance. Thanks! Following are the major changes: I feel provider.getMetadata() is not required to do twice as the 'provider' has provider.warmUpEncryptedKeys(keyName); warming up logic. Does this sound good to you ? modified few codes under the lock section. rebased in latest trunk code
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 13s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 4s There were no new javac warning messages.
        +1 javadoc 10m 26s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 38s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 43s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 17s Pre-build of native portion
        -1 hdfs tests 193m 59s Tests failed in hadoop-hdfs.
            237m 52s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.TestEncryptionZonesWithHA
          hadoop.hdfs.TestEncryptionZonesWithKMS



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12761607/HDFS-7529-002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 10ab7d5
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12588/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12588/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12588/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 13s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 4s There were no new javac warning messages. +1 javadoc 10m 26s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 38s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 43s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 193m 59s Tests failed in hadoop-hdfs.     237m 52s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestEncryptionZonesWithHA   hadoop.hdfs.TestEncryptionZonesWithKMS Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761607/HDFS-7529-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 10ab7d5 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12588/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12588/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12588/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 7s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 55s There were no new javac warning messages.
        +1 javadoc 10m 8s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 20s The applied patch generated 2 new checkstyle issues (total was 354, now 355).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 162m 43s Tests failed in hadoop-hdfs.
            208m 23s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.web.TestWebHDFSOAuth2
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12761668/HDFS-7529-003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 57003fa
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12598/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12598/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12598/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12598/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 10m 8s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 20s The applied patch generated 2 new checkstyle issues (total was 354, now 355). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 162m 43s Tests failed in hadoop-hdfs.     208m 23s   Reason Tests Failed unit tests hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.web.TestWebHDFSOAuth2   hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761668/HDFS-7529-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 57003fa checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12598/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12598/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12598/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12598/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 13s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 58s There were no new javac warning messages.
        +1 javadoc 9m 58s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 354, now 354).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 30s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 17s Pre-build of native portion
        -1 hdfs tests 99m 2s Tests failed in hadoop-hdfs.
            144m 52s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
        Timed out tests org.apache.hadoop.hdfs.server.datanode.web.dtp.TestDtpHttp2



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12761787/HDFS-7529-004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / cc2b473
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12614/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12614/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12614/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12614/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 354, now 354). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 99m 2s Tests failed in hadoop-hdfs.     144m 52s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration Timed out tests org.apache.hadoop.hdfs.server.datanode.web.dtp.TestDtpHttp2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761787/HDFS-7529-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cc2b473 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12614/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12614/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12614/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12614/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 54s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 1s There were no new javac warning messages.
        +1 javadoc 10m 24s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 354, now 354).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 26s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 11s Pre-build of native portion
        -1 hdfs tests 103m 52s Tests failed in hadoop-hdfs.
            149m 46s  



        Reason Tests
        Timed out tests org.apache.hadoop.hdfs.TestExternalBlockReader



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12761787/HDFS-7529-004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7c5c099
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12617/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12617/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12617/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12617/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 54s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 24s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 23s The applied patch generated 1 new checkstyle issues (total was 354, now 354). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 11s Pre-build of native portion -1 hdfs tests 103m 52s Tests failed in hadoop-hdfs.     149m 46s   Reason Tests Timed out tests org.apache.hadoop.hdfs.TestExternalBlockReader Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761787/HDFS-7529-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7c5c099 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12617/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12617/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12617/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12617/console This message was automatically generated.
        Hide
        wheat9 Haohui Mai added a comment -

        Thanks for taking the work! It looks good overall.

        +	  static EncryptedKeyVersion generateEncryptedDataEncryptionKey(final FSNamesystem fsn, final String ezKeyName) throws IOException {
        

        FSDirEncryptionZoneOp.java should minimize the usage of FSNamesystem. Most of the functions in the current patch are passing in FSNamesystem instead of FSDirectory. It's better to clean them up. The changes includes:

        • Remove the assertion on holding the FSNamesystem lock
        • Introduce a new getting method in FSDirectory to get the KeyProviderCryptoExtension object, or just move it inside FSDirectory.
        Show
        wheat9 Haohui Mai added a comment - Thanks for taking the work! It looks good overall. + static EncryptedKeyVersion generateEncryptedDataEncryptionKey( final FSNamesystem fsn, final String ezKeyName) throws IOException { FSDirEncryptionZoneOp.java should minimize the usage of FSNamesystem . Most of the functions in the current patch are passing in FSNamesystem instead of FSDirectory . It's better to clean them up. The changes includes: Remove the assertion on holding the FSNamesystem lock Introduce a new getting method in FSDirectory to get the KeyProviderCryptoExtension object, or just move it inside FSDirectory .
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Haohui Mai for the advice. Attached another patch including the changes:

        Remove the assertion on holding the FSNamesystem lock

        Done.

        Introduce a new getting method in FSDirectory to get the KeyProviderCryptoExtension object, or just move it inside FSDirectory.

        Done. Added FSDirectory#getProvider() function.

        Show
        rakeshr Rakesh R added a comment - Thanks Haohui Mai for the advice. Attached another patch including the changes: Remove the assertion on holding the FSNamesystem lock Done. Introduce a new getting method in FSDirectory to get the KeyProviderCryptoExtension object, or just move it inside FSDirectory. Done. Added FSDirectory#getProvider() function.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 21s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 17s There were no new javac warning messages.
        +1 javadoc 10m 18s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 26s The applied patch generated 1 new checkstyle issues (total was 354, now 354).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 20s Pre-build of native portion
        -1 hdfs tests 163m 10s Tests failed in hadoop-hdfs.
            209m 59s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12762073/HDFS-7529-005.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / ead1b9e
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12658/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12658/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12658/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12658/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 21s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 17s There were no new javac warning messages. +1 javadoc 10m 18s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 26s The applied patch generated 1 new checkstyle issues (total was 354, now 354). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 20s Pre-build of native portion -1 hdfs tests 163m 10s Tests failed in hadoop-hdfs.     209m 59s   Reason Tests Failed unit tests hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12762073/HDFS-7529-005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ead1b9e checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12658/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12658/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12658/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12658/console This message was automatically generated.
        Hide
        wheat9 Haohui Mai added a comment -

        +1. I'll commit it shortly.

        Show
        wheat9 Haohui Mai added a comment - +1. I'll commit it shortly.
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks Rakesh R for the contribution.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Rakesh R for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #442 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/442/)
        HDFS-7529. Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #442 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/442/ ) HDFS-7529 . Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8514 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8514/)
        HDFS-7529. Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8514 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8514/ ) HDFS-7529 . Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Hide
        rakeshr Rakesh R added a comment -

        Thanks a lot Haohui Mai for the detailed reviews and committing the patch!

        Show
        rakeshr Rakesh R added a comment - Thanks a lot Haohui Mai for the detailed reviews and committing the patch!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #436 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/436/)
        HDFS-7529. Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #436 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/436/ ) HDFS-7529 . Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2353 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2353/)
        HDFS-7529. Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2353 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2353/ ) HDFS-7529 . Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1175 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1175/)
        HDFS-7529. Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1175 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1175/ ) HDFS-7529 . Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #414 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/414/)
        HDFS-7529. Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #414 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/414/ ) HDFS-7529 . Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2381 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2381/)
        HDFS-7529. Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2381 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2381/ ) HDFS-7529 . Consolidate encryption zone related implementation into a single class. Contributed by Rakesh R. (wheat9: rev 71a81b6257c0000475ad62eb69292a20d45d269c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java

          People

          • Assignee:
            rakeshr Rakesh R
            Reporter:
            wheat9 Haohui Mai
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development