[HDFS-7439] Add BlockOpResponseProto's message to DFSClient's exception message

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.7.0
• Component/s: balancer & mover, datanode, hdfs-client
• Hadoop Flags: Reviewed
• Assignee: Takanobu Asanuma
• Reporter: Ming Ma
• Created: 25/Nov/14 01:11
• Updated: 24/Apr/15 23:22
• Resolved: 02/Mar/15 07:08

Description

When (BlockOpResponseProto#getStatus() != SUCCESS), it helps with debugging if DFSClient can add BlockOpResponseProto's message to the exception message applications will get. For example, instead of

        throw new IOException("Got error for OP_READ_BLOCK, self="
            + peer.getLocalAddressString() + ", remote="
            + peer.getRemoteAddressString() + ", for file " + file
            + ", for pool " + block.getBlockPoolId() + " block " 
            + block.getBlockId() + "_" + block.getGenerationStamp());

It could be,

        throw new IOException("Got error for OP_READ_BLOCK, self="
            + peer.getLocalAddressString() + ", remote="
            + peer.getRemoteAddressString() + ", for file " + file
            + ", for pool " + block.getBlockPoolId() + " block " 
            + block.getBlockId() + "_" + block.getGenerationStamp()
            + ", status message " + status.getMessage());

We might want to check out all the references to BlockOpResponseProto in DFSClient.