Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:

      Description

      HDFS-2832 added heterogeneous support. In a cluster with different storage types, it is useful to have metrics per storage type.

      1. HDFS-7390-008.patch
        20 kB
        Benoy Antony
      2. HDFS-7390-007.patch
        20 kB
        Benoy Antony
      3. HDFS-7390-006.patch
        21 kB
        Benoy Antony
      4. HDFS-7390-005.patch
        19 kB
        Benoy Antony
      5. HDFS-7390-004.patch
        19 kB
        Benoy Antony
      6. HDFS-7390-003.patch
        18 kB
        Benoy Antony
      7. HDFS-7390.patch
        19 kB
        Benoy Antony
      8. HDFS-7390.patch
        14 kB
        Benoy Antony

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/)
          HDFS-7390. Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/ ) HDFS-7390 . Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/)
          HDFS-7390. Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/ ) HDFS-7390 . Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/)
          HDFS-7390. Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/ ) HDFS-7390 . Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/)
          HDFS-7390. Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/ ) HDFS-7390 . Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #8086 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8086/)
          HDFS-7390. Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8086 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8086/ ) HDFS-7390 . Provide JMX metrics per storage type. (Benoy Antony) (benoy: rev d3fed8e653ed9e18d3a29a11c4b24a628ac770bb) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/StorageTypeStats.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeStatistics.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockStatsMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
          Hide
          benoyantony Benoy Antony added a comment -

          committed to trunk and branch-2.

          Show
          benoyantony Benoy Antony added a comment - committed to trunk and branch-2.
          Hide
          benoyantony Benoy Antony added a comment -

          The test failure on _ TestWebHDFS_ is unrelated. Thanks for the review, Arpit Agarwal. I'll commit this shortly.

          Show
          benoyantony Benoy Antony added a comment - The test failure on _ TestWebHDFS_ is unrelated. Thanks for the review, Arpit Agarwal . I'll commit this shortly.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 18m 29s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 32s There were no new javac warning messages.
          +1 javadoc 9m 57s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 21s The applied patch generated 1 new checkstyle issues (total was 200, now 200).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 25s Pre-build of native portion
          -1 hdfs tests 164m 54s Tests failed in hadoop-hdfs.
              213m 38s  



          Reason Tests
          Failed unit tests hadoop.hdfs.web.TestWebHDFS



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12742205/HDFS-7390-008.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / aa07dea
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11505/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11505/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11505/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11505/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11505/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 29s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 32s There were no new javac warning messages. +1 javadoc 9m 57s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 21s The applied patch generated 1 new checkstyle issues (total was 200, now 200). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 25s Pre-build of native portion -1 hdfs tests 164m 54s Tests failed in hadoop-hdfs.     213m 38s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHDFS Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742205/HDFS-7390-008.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / aa07dea Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11505/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11505/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11505/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11505/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11505/console This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks Benoy Antony. +1 for the v8 patch.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks Benoy Antony . +1 for the v8 patch.
          Hide
          benoyantony Benoy Antony added a comment -

          Attaching the patch which addresses Arpit Agarwal's comments.

          Show
          benoyantony Benoy Antony added a comment - Attaching the patch which addresses Arpit Agarwal 's comments.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for the updated patch Benoy. +1 for the v7 patch.

          Couple of things you can fix while committing:

          1. StorageTypeStatsMap#get should wrap the returned map using Collections#unmodifiableMap to avoid inadvertent modification.
          2. HeartbeatManager:490 entry: missing space before :.
          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for the updated patch Benoy. +1 for the v7 patch. Couple of things you can fix while committing: StorageTypeStatsMap#get should wrap the returned map using Collections#unmodifiableMap to avoid inadvertent modification. HeartbeatManager:490 entry: missing space before : .
          Hide
          benoyantony Benoy Antony added a comment -

          The checkstyle issue is due to the length of BlockManager which was already above 2000 lines. Not some that was introduced by the patch

          Show
          benoyantony Benoy Antony added a comment - The checkstyle issue is due to the length of BlockManager which was already above 2000 lines. Not some that was introduced by the patch
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 57s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 40s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 10s The applied patch generated 1 new checkstyle issues (total was 230, now 230).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 16s Pre-build of native portion
          +1 hdfs tests 162m 16s Tests passed in hadoop-hdfs.
              208m 43s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741850/HDFS-7390-007.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / b381f88
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11488/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11488/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11488/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11488/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 57s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 10s The applied patch generated 1 new checkstyle issues (total was 230, now 230). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion +1 hdfs tests 162m 16s Tests passed in hadoop-hdfs.     208m 43s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741850/HDFS-7390-007.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b381f88 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11488/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11488/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11488/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11488/console This message was automatically generated.
          Hide
          benoyantony Benoy Antony added a comment -

          Attaching a patch after fixing the compilation issues.

          Show
          benoyantony Benoy Antony added a comment - Attaching a patch after fixing the compilation issues.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 44s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          -1 javac 1m 27s The patch appears to cause the build to fail.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741707/HDFS-7390-006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / afe9ea3
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11475/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 44s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 javac 1m 27s The patch appears to cause the build to fail. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741707/HDFS-7390-006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / afe9ea3 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11475/console This message was automatically generated.
          Hide
          benoyantony Benoy Antony added a comment -

          Thanks for the review Arpit Agarwal
          Attaching a patch which addresses the comments.

          Show
          benoyantony Benoy Antony added a comment - Thanks for the review Arpit Agarwal Attaching a patch which addresses the comments.
          Hide
          arpitagarwal Arpit Agarwal added a comment - - edited

          Hi Benoy Antony,

          1. We should replace TieredStorage with ByStorageType or similar everywhere. HDFS knows nothing about the hierarchy of storage types.
          2. It looks like StorageTypeStats#add will add each node multiple times i.e. once per storage. I understand why you added nodesInService count in StorageTypeStats. We can have separate routines - addNode and addUsageStats or similar.
          3. Missing audience and stability annotations on public class StorageTypeStats.
          4. Nitpick. Couple of Coding style issues: Need spaces around operators e.g. in storageInfo:node.

          The patch looks good otherwise.

          Show
          arpitagarwal Arpit Agarwal added a comment - - edited Hi Benoy Antony , We should replace TieredStorage with ByStorageType or similar everywhere. HDFS knows nothing about the hierarchy of storage types. It looks like StorageTypeStats#add will add each node multiple times i.e. once per storage. I understand why you added nodesInService count in StorageTypeStats . We can have separate routines - addNode and addUsageStats or similar. Missing audience and stability annotations on public class StorageTypeStats . Nitpick. Couple of Coding style issues: Need spaces around operators e.g. in storageInfo:node . The patch looks good otherwise.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 45s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 26s There were no new javac warning messages.
          +1 javadoc 9m 31s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 14s The applied patch generated 3 new checkstyle issues (total was 228, now 230).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 13s Pre-build of native portion
          +1 hdfs tests 160m 1s Tests passed in hadoop-hdfs.
              206m 2s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741135/HDFS-7390-005.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 11ac848
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11440/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11440/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11440/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11440/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 45s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 26s There were no new javac warning messages. +1 javadoc 9m 31s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 14s The applied patch generated 3 new checkstyle issues (total was 228, now 230). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion +1 hdfs tests 160m 1s Tests passed in hadoop-hdfs.     206m 2s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741135/HDFS-7390-005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 11ac848 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11440/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11440/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11440/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11440/console This message was automatically generated.
          Hide
          benoyantony Benoy Antony added a comment -

          fixing checkstyle warning

          Show
          benoyantony Benoy Antony added a comment - fixing checkstyle warning
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 43s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 32s There were no new javac warning messages.
          +1 javadoc 9m 38s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 13s The applied patch generated 3 new checkstyle issues (total was 228, now 230).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 15s Pre-build of native portion
          -1 hdfs tests 162m 10s Tests failed in hadoop-hdfs.
              208m 23s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12740172/HDFS-7390-004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1a169a2
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11395/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11395/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11395/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11395/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 13s The applied patch generated 3 new checkstyle issues (total was 228, now 230). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion -1 hdfs tests 162m 10s Tests failed in hadoop-hdfs.     208m 23s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740172/HDFS-7390-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1a169a2 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11395/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11395/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11395/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11395/console This message was automatically generated.
          Hide
          benoyantony Benoy Antony added a comment -

          Attaching a patch after fixing checkstyle warnings.

          Show
          benoyantony Benoy Antony added a comment - Attaching a patch after fixing checkstyle warnings.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 46s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 12s The applied patch generated 22 new checkstyle issues (total was 229, now 250).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 13s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 13s Pre-build of native portion
          +1 hdfs tests 162m 36s Tests passed in hadoop-hdfs.
              208m 42s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12740019/HDFS-7390-003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 5dbc8c9
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11382/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11382/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11382/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11382/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 46s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 12s The applied patch generated 22 new checkstyle issues (total was 229, now 250). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 13s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion +1 hdfs tests 162m 36s Tests passed in hadoop-hdfs.     208m 42s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740019/HDFS-7390-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5dbc8c9 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11382/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11382/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11382/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11382/console This message was automatically generated.
          Hide
          benoyantony Benoy Antony added a comment -

          Updated the patch. A new MXBean BlockStats is defined and is implemented by BlockManager.
          Used standard MXBean approach (based on CompositeDataSupport) to output Json.
          Testcases are added.
          Dependency on HADOOP-11308 is no longer needed and it is closed.
          The sample Json output is as below:

          {
              "name" : "Hadoop:service=NameNode,name=BlockStats",
              "modelerType" : "org.apache.hadoop.hdfs.server.blockmanagement.BlockManager",
              "TieredStorageStats" : [ {
                "key" : "RAM_DISK",
                "value" : {
                  "blockPoolUsed" : 24576,
                  "capacityRemaining" : 1634963226624,
                  "capacityTotal" : 2994494914560,
                  "capacityUsed" : 24576,
                  "nodesInService" : 6
                }
              }, {
                "key" : "ARCHIVE",
                "value" : {
                  "blockPoolUsed" : 12288,
                  "capacityRemaining" : 817481576448,
                  "capacityTotal" : 1497247457280,
                  "capacityUsed" : 12288,
                  "nodesInService" : 3
                }
              }, {
                "key" : "DISK",
                "value" : {
                  "blockPoolUsed" : 12288,
                  "capacityRemaining" : 817481650176,
                  "capacityTotal" : 1497247457280,
                  "capacityUsed" : 12288,
                  "nodesInService" : 3
                }
              } ]
            }
          
          Show
          benoyantony Benoy Antony added a comment - Updated the patch. A new MXBean BlockStats is defined and is implemented by BlockManager . Used standard MXBean approach (based on CompositeDataSupport) to output Json. Testcases are added. Dependency on HADOOP-11308 is no longer needed and it is closed. The sample Json output is as below: { "name" : "Hadoop:service=NameNode,name=BlockStats" , "modelerType" : "org.apache.hadoop.hdfs.server.blockmanagement.BlockManager" , "TieredStorageStats" : [ { "key" : "RAM_DISK" , "value" : { "blockPoolUsed" : 24576, "capacityRemaining" : 1634963226624, "capacityTotal" : 2994494914560, "capacityUsed" : 24576, "nodesInService" : 6 } }, { "key" : "ARCHIVE" , "value" : { "blockPoolUsed" : 12288, "capacityRemaining" : 817481576448, "capacityTotal" : 1497247457280, "capacityUsed" : 12288, "nodesInService" : 3 } }, { "key" : "DISK" , "value" : { "blockPoolUsed" : 12288, "capacityRemaining" : 817481650176, "capacityTotal" : 1497247457280, "capacityUsed" : 12288, "nodesInService" : 3 } } ] }
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12681720/HDFS-7390.patch
          against trunk revision fe7a302.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9645//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12681720/HDFS-7390.patch against trunk revision fe7a302. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9645//console This message is automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Benoy Antony, the patch looks good to me. Could you please rebase it to current trunk?

          Show
          arpitagarwal Arpit Agarwal added a comment - Benoy Antony , the patch looks good to me. Could you please rebase it to current trunk?
          Hide
          wheat9 Haohui Mai added a comment -

          Since the information is only related to the block manager, maybe in general it makes more sense to move the JMX information to the block manager (i.e., creating a MXBean for BlockManager)?

          Show
          wheat9 Haohui Mai added a comment - Since the information is only related to the block manager, maybe in general it makes more sense to move the JMX information to the block manager (i.e., creating a MXBean for BlockManager)?
          Hide
          benoyantony Benoy Antony added a comment - - edited

          Haohui Mai, Could you please review the patch and recommend if there is anything else needs to be done here and related HADOOP-11308 ?

          Show
          benoyantony Benoy Antony added a comment - - edited Haohui Mai , Could you please review the patch and recommend if there is anything else needs to be done here and related HADOOP-11308 ?
          Hide
          benoyantony Benoy Antony added a comment -

          Charles Lamb, I was trying to satisfy the Json structure in https://issues.apache.org/jira/browse/HDFS-7390?focusedCommentId=14211474&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14211474 .

          Per http://www.json.org/ , anything between double quotes is a string. The following basically represents two strings.

              "TieredStorageStats" : "{DISK={capacityTotal=42275598336, capacityUsed=24576, capacityRemaining=21051469824, blockPoolUsed=24576, nodesInService=1}}",
          

          An object is denoted by curly brackets. The following represents a String and a Json Object.

           "TieredStorageStats" : {"ARCHIVE":{"capacityTotal":1498254102528,"capacityUsed":12288,"capacityRemaining":982557745152,"blockPoolUsed":12288,"nodesInService":3},"DISK":{"capacityTotal":1498254102528,"capacityUsed":49152,"capacityRemaining":982557745152,"blockPoolUsed":49152,"nodesInService":3}}
          
          Show
          benoyantony Benoy Antony added a comment - Charles Lamb , I was trying to satisfy the Json structure in https://issues.apache.org/jira/browse/HDFS-7390?focusedCommentId=14211474&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14211474 . Per http://www.json.org/ , anything between double quotes is a string. The following basically represents two strings. "TieredStorageStats" : "{DISK={capacityTotal=42275598336, capacityUsed=24576, capacityRemaining=21051469824, blockPoolUsed=24576, nodesInService=1}}", An object is denoted by curly brackets. The following represents a String and a Json Object. "TieredStorageStats" : { "ARCHIVE" :{ "capacityTotal" :1498254102528, "capacityUsed" :12288, "capacityRemaining" :982557745152, "blockPoolUsed" :12288, "nodesInService" :3}, "DISK" :{ "capacityTotal" :1498254102528, "capacityUsed" :49152, "capacityRemaining" :982557745152, "blockPoolUsed" :49152, "nodesInService" :3}}
          Hide
          clamb Charles Lamb added a comment -

          Hi Benoy Antony,

          Thanks for working on this – it's a good improvement.

          I'm currently working on HDFS-7331. In https://issues.apache.org/jira/browse/HDFS-7331?focusedCommentId=14195484&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14195484, Haohui Mai suggested that I just return the Map directly rather than the JSON.toString. If I change your code to do that, the output looks like this and you'd be returning a JSON object, not just a string:

              "TieredStorageStats" : "{DISK={capacityTotal=42275598336, capacityUsed=24576, capacityRemaining=21051469824, blockPoolUsed=24576, nodesInService=1}}",
          

          Would that work?

          If you end up keeping JsonString, I assume you'll use the version from HADOOP-11308's second patch and not the one in the HDFS-7390 patch. That would probably happen just by virtue of commit order of the two patches. Also, there are several lines that are > 80 chars.

          Show
          clamb Charles Lamb added a comment - Hi Benoy Antony , Thanks for working on this – it's a good improvement. I'm currently working on HDFS-7331 . In https://issues.apache.org/jira/browse/HDFS-7331?focusedCommentId=14195484&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14195484 , Haohui Mai suggested that I just return the Map directly rather than the JSON.toString. If I change your code to do that, the output looks like this and you'd be returning a JSON object, not just a string: "TieredStorageStats" : "{DISK={capacityTotal=42275598336, capacityUsed=24576, capacityRemaining=21051469824, blockPoolUsed=24576, nodesInService=1}}", Would that work? If you end up keeping JsonString, I assume you'll use the version from HADOOP-11308 's second patch and not the one in the HDFS-7390 patch. That would probably happen just by virtue of commit order of the two patches. Also, there are several lines that are > 80 chars.
          Hide
          benoyantony Benoy Antony added a comment -

          Separating the hadoop-common changes to a separate jira - HADOOP-11308. The test failures seems to be related this fact as they complain of missing class.

          Show
          benoyantony Benoy Antony added a comment - Separating the hadoop-common changes to a separate jira - HADOOP-11308 . The test failures seems to be related this fact as they complain of missing class.
          Hide
          benoyantony Benoy Antony added a comment -

          Attached patch takes care of the previous comment.

          Sample JMX output
              "name" : "Hadoop:service=NameNode,name=FSNamesystemState",
              "modelerType" : "org.apache.hadoop.hdfs.server.namenode.FSNamesystem",
              "CapacityTotal" : 2996508205056,
              "CapacityUsed" : 61440,
              "CapacityRemaining" : 1965115490304,
              "TotalLoad" : 6,
              "SnapshotStats" : "{\"SnapshottableDirectories\":0,\"Snapshots\":0}",
              "TieredStorageStats" : {"ARCHIVE":{"capacityTotal":1498254102528,"capacityUsed":12288,"capacityRemaining":982557745152,"blockPoolUsed":12288,"nodesInService":3},"DISK":{"capacityTotal":1498254102528,"capacityUsed":49152,"capacityRemaining":982557745152,"blockPoolUsed":49152,"nodesInService":3}},
          
          Show
          benoyantony Benoy Antony added a comment - Attached patch takes care of the previous comment. Sample JMX output "name" : "Hadoop:service=NameNode,name=FSNamesystemState" , "modelerType" : "org.apache.hadoop.hdfs.server.namenode.FSNamesystem" , "CapacityTotal" : 2996508205056, "CapacityUsed" : 61440, "CapacityRemaining" : 1965115490304, "TotalLoad" : 6, "SnapshotStats" : "{\" SnapshottableDirectories\ ":0,\" Snapshots\ ":0}" , "TieredStorageStats" : { "ARCHIVE" :{ "capacityTotal" :1498254102528, "capacityUsed" :12288, "capacityRemaining" :982557745152, "blockPoolUsed" :12288, "nodesInService" :3}, "DISK" :{ "capacityTotal" :1498254102528, "capacityUsed" :49152, "capacityRemaining" :982557745152, "blockPoolUsed" :49152, "nodesInService" :3}},
          Hide
          wheat9 Haohui Mai added a comment -

          For

            "TieredStorageStats" : "{\"ARCHIVE\":{\"capacityTotal\":1498254102528,\"capacityUsed\":12288,\"capacityRemaining\":980102602752,\"blockPoolUsed\":12288,\"nodesInService\":3,\"numBlocks\":0}...
          

          Can the code output

            "TieredStorageStats" : {"ARCHIVE":{"capacityTotal":1498254102528,"capacityUsed":12288,"capacityRemaining":980102602752,"blockPoolUsed":12288,"nodesInService":3,"numBlocks":0}...
          

          In the former output TieredStorageStats maps to a JSON string while in the latter one it maps to a JSON object.

          Show
          wheat9 Haohui Mai added a comment - For "TieredStorageStats" : "{\" ARCHIVE\ ":{\" capacityTotal\ ":1498254102528,\" capacityUsed\ ":12288,\" capacityRemaining\ ":980102602752,\" blockPoolUsed\ ":12288,\" nodesInService\ ":3,\" numBlocks\":0}... Can the code output "TieredStorageStats" : { "ARCHIVE" :{ "capacityTotal" :1498254102528, "capacityUsed" :12288, "capacityRemaining" :980102602752, "blockPoolUsed" :12288, "nodesInService" :3, "numBlocks" :0}... In the former output TieredStorageStats maps to a JSON string while in the latter one it maps to a JSON object.
          Hide
          benoyantony Benoy Antony added a comment -

          Haohui Mai, I did not understand the recommendation.

          Currently, these additional statistics are under FSNamesystemState metrics.
          If you need something different, could you please provide me some additional pointers ?

          JMX output
          {
              "name" : "Hadoop:service=NameNode,name=FSNamesystemState",
              "modelerType" : "org.apache.hadoop.hdfs.server.namenode.FSNamesystem",
              "CapacityTotal" : 2996508205056,
              "CapacityUsed" : 36864,
              "CapacityRemaining" : 1960205205504,
              "TotalLoad" : 6,
              "SnapshotStats" : "{\"SnapshottableDirectories\":0,\"Snapshots\":0}",
              "TieredStorageStats" : "{\"ARCHIVE\":{\"capacityTotal\":1498254102528,\"capacityUsed\":12288,\"capacityRemaining\":980102602752,\"blockPoolUsed\":12288,\"nodesInService\":3,\"numBlocks\":0},\"DISK\":{\"capacityTotal\":1498254102528,\"capacityUsed\":24576,\"capacityRemaining\":980102602752,\"blockPoolUsed\":24576,\"nodesInService\":3,\"numBlocks\":0}}",
          
          Show
          benoyantony Benoy Antony added a comment - Haohui Mai , I did not understand the recommendation. Currently, these additional statistics are under FSNamesystemState metrics. If you need something different, could you please provide me some additional pointers ? JMX output { "name" : "Hadoop:service=NameNode,name=FSNamesystemState" , "modelerType" : "org.apache.hadoop.hdfs.server.namenode.FSNamesystem" , "CapacityTotal" : 2996508205056, "CapacityUsed" : 36864, "CapacityRemaining" : 1960205205504, "TotalLoad" : 6, "SnapshotStats" : "{\" SnapshottableDirectories\ ":0,\" Snapshots\ ":0}" , "TieredStorageStats" : "{\" ARCHIVE\ ":{\" capacityTotal\ ":1498254102528,\" capacityUsed\ ":12288,\" capacityRemaining\ ":980102602752,\" blockPoolUsed\ ":12288,\" nodesInService\ ":3,\" numBlocks\ ":0},\" DISK\ ":{\" capacityTotal\ ":1498254102528,\" capacityUsed\ ":24576,\" capacityRemaining\ ":980102602752,\" blockPoolUsed\ ":24576,\" nodesInService\ ":3,\" numBlocks\ ":0}}" ,
          Hide
          wheat9 Haohui Mai added a comment -

          Thanks for the work. Can you make The JMX directly output JSON objects instead JSON strings?

          Show
          wheat9 Haohui Mai added a comment - Thanks for the work. Can you make The JMX directly output JSON objects instead JSON strings?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12680905/HDFS-7390.patch
          against trunk revision 163bb55.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDFSUpgradeFromImage
          org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8717//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8717//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12680905/HDFS-7390.patch against trunk revision 163bb55. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDFSUpgradeFromImage org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestScrLazyPersistFiles +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8717//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8717//console This message is automatically generated.
          Hide
          benoyantony Benoy Antony added a comment - - edited

          The attached patch provide JMX metrics per storage type.
          The following information is provided for each storage type in the cluster

          {capacityTotal, capacityUsed, capacityRemaining, blockPoolUsed, nodesInService, numBlocks}
          Sample JMX output
          "TieredStorageStats" : "
          
          {\"ARCHIVE\":{\"capacityTotal\":1498254102528,\"capacityUsed\":12288,\"capacityRemaining\":981672161280,\"blockPoolUsed\":12288,\"nodesInService\":3,\"numBlocks\":0},
          \"DISK\":{\"capacityTotal\":1498254102528,\"capacityUsed\":12288,\"capacityRemaining\":981672161280,\"blockPoolUsed\":12288,\"nodesInService\":3,\"numBlocks\":0}}"
          
          Show
          benoyantony Benoy Antony added a comment - - edited The attached patch provide JMX metrics per storage type. The following information is provided for each storage type in the cluster {capacityTotal, capacityUsed, capacityRemaining, blockPoolUsed, nodesInService, numBlocks} Sample JMX output "TieredStorageStats" : " {\ "ARCHIVE\" :{\ "capacityTotal\" :1498254102528,\ "capacityUsed\" :12288,\ "capacityRemaining\" :981672161280,\ "blockPoolUsed\" :12288,\ "nodesInService\" :3,\ "numBlocks\" :0}, \ "DISK\" :{\ "capacityTotal\" :1498254102528,\ "capacityUsed\" :12288,\ "capacityRemaining\" :981672161280,\ "blockPoolUsed\" :12288,\ "nodesInService\" :3,\ "numBlocks\" :0}}"

            People

            • Assignee:
              benoyantony Benoy Antony
              Reporter:
              benoyantony Benoy Antony
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development