Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Add full path name of the file to the under replicated block information and summary of total number of files, blocks, live and dead datanodes to metasave output.

      Description

      This jira tracks following improvements in metasave output
      1. A summary of total files/directories and blocks at the begining
      2. Full path name of the files should also be written out for under-replicated/corrupt or missing blocks.

      1. HDFS-737.3.rel20.patch
        7 kB
        Suresh Srinivas
      2. HDFS-737.3.patch
        7 kB
        Jitendra Nath Pandey
      3. HDFS-737.2.patch
        7 kB
        Jitendra Nath Pandey
      4. HDFS-737.1.patch
        6 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Suresh Srinivas added a comment -

        Comments:

        1. Adding number of live and dead nodes will be useful information along with count of files, directories and blocks.
        2. TestMetaSave.java - please make this Junit4 testcase. Also start and stop of the cluster can be done in @BeforeClass and @AfterClass methods.
        3. TestMetaSave.java - some of the imports are not used.
        4. FsNameSystem.metaSave, TestMetaSave.createFile, TestMetasave.testMetaSave - some lines exceed 80 chars.
        5. TestMetaSave.testMetaSave - variable out is not used.
        Show
        Suresh Srinivas added a comment - Comments: Adding number of live and dead nodes will be useful information along with count of files, directories and blocks. TestMetaSave.java - please make this Junit4 testcase. Also start and stop of the cluster can be done in @BeforeClass and @AfterClass methods. TestMetaSave.java - some of the imports are not used. FsNameSystem.metaSave, TestMetaSave.createFile, TestMetasave.testMetaSave - some lines exceed 80 chars. TestMetaSave.testMetaSave - variable out is not used.
        Hide
        Jitendra Nath Pandey added a comment -

        HDFS-737.2.patch is submitted for hudson tests.

        Show
        Jitendra Nath Pandey added a comment - HDFS-737 .2.patch is submitted for hudson tests.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423472/HDFS-737.2.patch
        against trunk revision 830003.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/84/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/84/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/84/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/84/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423472/HDFS-737.2.patch against trunk revision 830003. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/84/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/84/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/84/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/84/console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        HDFS-737.3.patch is submitted.

        Show
        Jitendra Nath Pandey added a comment - HDFS-737 .3.patch is submitted.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423513/HDFS-737.3.patch
        against trunk revision 830804.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/87/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/87/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/87/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/87/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423513/HDFS-737.3.patch against trunk revision 830804. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/87/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/87/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/87/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/87/console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        +1 for the patch.

        Show
        Suresh Srinivas added a comment - +1 for the patch.
        Hide
        Jitendra Nath Pandey added a comment -

        The failure of TestBlockReport is not related to this patch.

        Show
        Jitendra Nath Pandey added a comment - The failure of TestBlockReport is not related to this patch.
        Hide
        Suresh Srinivas added a comment -

        Committed the patch to both trunk and 21.

        Show
        Suresh Srinivas added a comment - Committed the patch to both trunk and 21.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #89 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/89/)
        . Add full path name of the file to the block information and summary of total number of files, blocks, live and deadnodes to metasave output. Contributed by Jitendra Pandey.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #89 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/89/ ) . Add full path name of the file to the block information and summary of total number of files, blocks, live and deadnodes to metasave output. Contributed by Jitendra Pandey.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #136 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #136 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/ )
        Hide
        Suresh Srinivas added a comment -

        Patch for branch 20 attached.

        Show
        Suresh Srinivas added a comment - Patch for branch 20 attached.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 HDFS-737.3.rel20.patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 HDFS-737 .3.rel20.patch looks good.

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development