Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-731

Support new Syncable interface in HDFS

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS should implement the new Syncable interface defined in HADOOP-6313.

      1. hdfsSyncable2.patch
        12 kB
        Hairong Kuang
      2. hdfsSyncable1.patch
        12 kB
        Hairong Kuang
      3. hdfsSyncable.patch
        1.0 kB
        Hairong Kuang

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          6d 22h 46m 1 Hairong Kuang 30/Oct/09 21:32
          Resolved Resolved Closed Closed
          297d 23h 17m 1 Tom White 24/Aug/10 21:50
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #136 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #136 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/ )
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/ )
          Hairong Kuang made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Hairong Kuang added a comment -

          I've just committed this.

          Show
          Hairong Kuang added a comment - I've just committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #91 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/91/)
          . Support new Syncable interface in HDFS. Contributed by Hairong Kuang.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #91 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/91/ ) . Support new Syncable interface in HDFS. Contributed by Hairong Kuang.
          Hide
          Hairong Kuang added a comment -

          > We should create a jira to track completing hsync implementation. That jira should be linked to this.
          Created HDFS-744.

          Show
          Hairong Kuang added a comment - > We should create a jira to track completing hsync implementation. That jira should be linked to this. Created HDFS-744 .
          Hairong Kuang made changes -
          Link This issue relates to HDFS-744 [ HDFS-744 ]
          Hide
          Hairong Kuang added a comment -

          BUILD SUCCESSFUL
          Total time: 66 minutes 37 seconds

          Show
          Hairong Kuang added a comment - BUILD SUCCESSFUL Total time: 66 minutes 37 seconds
          Hide
          Suresh Srinivas added a comment -

          Currently hsync and hflush are the same. We should create a jira to track completing hsync implementation. That jira should be linked to this.

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - Currently hsync and hflush are the same. We should create a jira to track completing hsync implementation. That jira should be linked to this. +1 for the patch.
          Hide
          Hairong Kuang added a comment -

          Since this patch needs the changes made in HDFS-6313, I used a modified version of test-patch.sh to "ant test-patch". Here is the result:
          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 33 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

          Show
          Hairong Kuang added a comment - Since this patch needs the changes made in HDFS-6313 , I used a modified version of test-patch.sh to "ant test-patch". Here is the result: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 33 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          Hairong Kuang made changes -
          Attachment hdfsSyncable2.patch [ 12423647 ]
          Hide
          Hairong Kuang added a comment -

          This patch sync with the trunk.

          Show
          Hairong Kuang added a comment - This patch sync with the trunk.
          Hairong Kuang made changes -
          Attachment hdfsSyncable1.patch [ 12423269 ]
          Hide
          Hairong Kuang added a comment -

          This patch adds more java doc and replaces all use of sync() in tests with hflush().

          Show
          Hairong Kuang added a comment - This patch adds more java doc and replaces all use of sync() in tests with hflush().
          Hairong Kuang made changes -
          Fix Version/s 0.21.0 [ 12314046 ]
          Fix Version/s 0.20.2 [ 12314204 ]
          Hairong Kuang made changes -
          Attachment hdfsSyncable.patch [ 12423082 ]
          Hide
          Hairong Kuang added a comment -

          Here is the patch for implementing Syncable in HDFS.

          Show
          Hairong Kuang added a comment - Here is the patch for implementing Syncable in HDFS.
          Hairong Kuang made changes -
          Field Original Value New Value
          Link This issue is blocked by HADOOP-6313 [ HADOOP-6313 ]
          Hairong Kuang created issue -

            People

            • Assignee:
              Hairong Kuang
              Reporter:
              Hairong Kuang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development