[HDFS-7284] Add more debug info to BlockInfoUnderConstruction#setGenerationStampAndVerifyReplicas

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.1
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: namenode
• Labels: supportability
• Assignee: Wei-Chiu Chuang
• Reporter: Hu Liu,
• Created: 24/Oct/14 06:52
• Updated: 02/Oct/19 17:15
• Resolved: 26/Oct/15 20:47

Description

When I was looking at some replica loss issue, I got the following info from log

2014-10-13 01:54:53,104 INFO BlockStateChange: BLOCK* Removing stale replica from location x.x.x.x

I could just know that a replica is removed, but I don't know which block and its timestamp. I need to know the id and timestamp of the block from the log file.
So it's better to add more info including block id and timestamp to the code snippet

    for (ReplicaUnderConstruction r : replicas) {
      if (genStamp != r.getGenerationStamp()) {
        r.getExpectedLocation().removeBlock(this);
        NameNode.blockStateChangeLog.info("BLOCK* Removing stale replica "
            + "from location: " + r.getExpectedLocation());
      }
    }