Thanks Hu Liu, for reporting the issue and Wei-Chiu Chuang for the patch. I think this is a good supportability jira.
Hi Wei-Chiu Chuang,
I think we can change the message to:
NameNode.blockStateChangeLog.debug("BLOCK* Removing stale replica "
+ r + " of block " + ((Block)r));
which utilize the toString methods of ReplicaUnderConstruction and Block classes to provide needed info (block id, timestamp), plus replica state which would help in cases.
The only thing is, if people used to search for "from location: " string for this message, it won't be there.
But I think this is ok, since this is a debug message and the keyword "Remove stale replica" is not changed.
Wonder what other people would think. Hi Andrew Wang, mind comment on my comment?