[HDFS-7190] Bad use of Preconditions in startFileInternal()

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0
• Component/s: namenode
• Labels: newbie
• Target Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Dawson Choong
• Reporter: Konstantin Shvachko
• Created: 03/Oct/14 21:55
• Updated: 10/Apr/15 20:29
• Resolved: 15/Oct/14 06:42

Description

The following precondition is in the middle of startFileInternal()

feInfo = new FileEncryptionInfo(suite, version,
        ....
Preconditions.checkNotNull(feInfo);

Preconditions are recommended to be used in the beginning of the method.
In this case the check is no-op anyways, because the variable has just been constructed.
Should be just removed.