[HDFS-7118] Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Component/s: journal-node, namenode
• Target Version/s: 2.6.0
• Hadoop Flags: Reviewed
• Assignee: Chris Nauroth
• Reporter: Chris Nauroth
• Created: 22/Sep/14 17:48
• Updated: 01/Dec/14 03:11
• Resolved: 25/Sep/14 17:07

Description

If a file rename fails, NativeIO#renameTo includes more information about the root cause than a plain java.io.File#renameTo. The native code can throw an exception with a detailed error message and the errno on *nix or the value of GetLastError on Windows. This issue proposes to use NativeIO#renameTo inside or in place of Storage#rename to help improve diagnostics. The method falls back to java.io.File#renameTo if native code is not loaded, so this change would not introduce a compatibility problem for deployments running without native code.

Issue Links

• is related to: HADOOP-9590 Move to JDK7 improved APIs for file operations when available
• relates to: HDFS-4428 FsDatasetImpl should disclose what the error is when a rename fails
• relates to: HDFS-6499 Use NativeIO#renameTo instead of File#renameTo in FileJournalManager