[HDFS-6] in FSNamesystem.registerDatanode, dnAddress should be resolved (rarely occured)

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix

Environment

CentOS 5.2, JDK 1.6

• Assignee: Unassigned
• Reporter: Wang Xu
• Created: 12/Feb/09 07:25
• Updated: 19/Nov/11 20:51
• Resolved: 19/Nov/11 20:51

Description

In FSNamesystem.java registerDatanode(), if the datanode address cannot be
got from the RPC Server, it will use that from the datanode report:

String dnAddress = Server.getRemoteAddress();
if (dnAddress == null)

{ // Mostly called inside an RPC. // But if not, use address passed by the data-node. dnAddress = nodeReg.getHost(); }

The getHost() may return the hostname or address, while the Server.getRemoteAddress()
will return the IP address, which is the dnAddress should be. Thus I think the it should be

if (dnAddress == null)

{ // Mostly called inside an RPC. // But if not, use address passed by the data-node. dnAddress = InetAddress.getByName(nodeReg.getHost()).getHostAddress(); }

I know it should not be called in most situation, but I indeed use that, and I suppose the
dnAddress should be an IP address.