[HDFS-6945] BlockManager should remove a block from excessReplicateMap and decrement ExcessBlocks metric when the block is removed

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.8.0, 2.7.2, 2.6.4, 3.0.0-alpha1
• Component/s: namenode
• Labels: metrics
• Target Version/s: 2.8.0, 2.6.4
• Hadoop Flags: Reviewed
• Assignee: Akira Ajisaka
• Reporter: Akira Ajisaka
• Created: 26/Aug/14 09:01
• Updated: 06/Jan/17 00:53
• Resolved: 01/Apr/15 00:11

Description

I'm seeing ExcessBlocks metric increases to more than 300K in some clusters, however, there are no over-replicated blocks (confirmed by fsck).

After a further research, I noticed when deleting a block, BlockManager does not remove the block from excessReplicateMap or decrement excessBlocksCount.
Usually the metric is decremented when processing block report, however, if the block has been deleted, BlockManager does not remove the block from excessReplicateMap or decrement the metric.
That way the metric and excessReplicateMap can increase infinitely (i.e. memory leak can occur).