Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6646

[ HDFS Rolling Upgrade - Shell ] shutdownDatanode and getDatanodeInfo usage is missed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.6.0
    • Component/s: tools
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Usage message is missed for shutdownDatanode and getdatanodeinfo

      Please check the following for same..(It's printing whole usage for dfsadmin)
      hdfs dfsadmin -shutdownDatanode
      Usage: java DFSAdmin
      Note: Administrative commands can only be run as the HDFS superuser.
      [-report]
      [-safemode enter | leave | get | wait]
      [-allowSnapshot <snapshotDir>]
      [-disallowSnapshot <snapshotDir>]
      [-saveNamespace]
      [-rollEdits]
      [-restoreFailedStorage true|false|check]
      [-refreshNodes]
      [-finalizeUpgrade]
      [-rollingUpgrade [<query|prepare|finalize>]]
      [-metasave filename]
      [-refreshServiceAcl]
      [-refreshUserToGroupsMappings]
      [-refreshSuperUserGroupsConfiguration]
      [-refreshCallQueue]
      [-printTopology]
      [-refreshNamenodes datanodehost:port]
      [-deleteBlockPool datanode-host:port blockpoolId [force]]
      [-setQuota <quota> <dirname>...<dirname>]
      [-clrQuota <dirname>...<dirname>]
      [-setSpaceQuota <quota> <dirname>...<dirname>]
      [-clrSpaceQuota <dirname>...<dirname>]
      [-setBalancerBandwidth <bandwidth in bytes per second>]
      [-fetchImage <local directory>]
      [-shutdownDatanode <datanode_host:ipc_port> [upgrade]]
      [-getDatanodeInfo <datanode_host:ipc_port>]
      [-help [cmd]]

      Generic options supported are
      -conf <configuration file> specify an application configuration file
      -D <property=value> use value for given property
      -fs <local|namenode:port> specify a namenode
      -jt <local|jobtracker:port> specify a job tracker
      -files <comma separated list of files> specify comma separated files to be copied to the map reduce cluster
      -libjars <comma separated list of jars> specify comma separated jar files to include in the classpath.
      -archives <comma separated list of archives> specify comma separated archives to be unarchived on the compute machines.

      The general command line syntax is
      bin/hadoop command [genericOptions] [commandOptions]

      1. HDFS-6646.patch
        1 kB
        Brahma Reddy Battula
      2. HDFS-6646_1.patch
        1 kB
        Brahma Reddy Battula

        Activity

        Hide
        Brahma Reddy Battula added a comment -

        Not adding the testcase since it is related just usage message not functional

        Show
        Brahma Reddy Battula added a comment - Not adding the testcase since it is related just usage message not functional
        Hide
        Vinayakumar B added a comment -

        Hi Brahma Reddy Battula,
        Thanks for the patch.
        Fix looks good to me.

        Small nits:
        1. Need to remove <tab> character, and correct the indentation of 'else if' as other 'else if' statements.

        Show
        Vinayakumar B added a comment - Hi Brahma Reddy Battula , Thanks for the patch. Fix looks good to me. Small nits: 1. Need to remove <tab> character, and correct the indentation of 'else if' as other 'else if' statements.
        Hide
        Brahma Reddy Battula added a comment -

        HI vinay,

        Show
        Brahma Reddy Battula added a comment - HI vinay,
        Hide
        Brahma Reddy Battula added a comment -

        Hi Vinayakumar B,

        Thanks for taking look into this issue,..Updated patch..

        Show
        Brahma Reddy Battula added a comment - Hi Vinayakumar B , Thanks for taking look into this issue,..Updated patch..
        Hide
        Vinayakumar B added a comment -

        +1 for the updated patch.
        Will commit soon.

        Show
        Vinayakumar B added a comment - +1 for the updated patch. Will commit soon.
        Hide
        Vinayakumar B added a comment -

        committed to trunk and branch-2.

        Thanks Brahma Reddy Battula.

        Show
        Vinayakumar B added a comment - committed to trunk and branch-2. Thanks Brahma Reddy Battula .
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #5848 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5848/)
        HDFS-6646. [ HDFS Rolling Upgrade - Shell ] shutdownDatanode and getDatanodeInfo usage is missed ( Contributed by Brahma Reddy Battula) (vinayakumarb: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1609020)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #5848 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5848/ ) HDFS-6646 . [ HDFS Rolling Upgrade - Shell ] shutdownDatanode and getDatanodeInfo usage is missed ( Contributed by Brahma Reddy Battula) (vinayakumarb: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1609020 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #608 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/608/)
        HDFS-6646. [ HDFS Rolling Upgrade - Shell ] shutdownDatanode and getDatanodeInfo usage is missed ( Contributed by Brahma Reddy Battula) (vinayakumarb: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1609020)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #608 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/608/ ) HDFS-6646 . [ HDFS Rolling Upgrade - Shell ] shutdownDatanode and getDatanodeInfo usage is missed ( Contributed by Brahma Reddy Battula) (vinayakumarb: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1609020 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1799 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1799/)
        HDFS-6646. [ HDFS Rolling Upgrade - Shell ] shutdownDatanode and getDatanodeInfo usage is missed ( Contributed by Brahma Reddy Battula) (vinayakumarb: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1609020)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1799 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1799/ ) HDFS-6646 . [ HDFS Rolling Upgrade - Shell ] shutdownDatanode and getDatanodeInfo usage is missed ( Contributed by Brahma Reddy Battula) (vinayakumarb: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1609020 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1827/)

        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1827/ )

          People

          • Assignee:
            Brahma Reddy Battula
            Reporter:
            Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development