Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6576

Datanode log is generating at root directory in security mode

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: datanode, scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In hadoop-env.sh script we are exporting HADOOP_SECURE_DN_LOG_DIR , but in above line export statement for HADOOP_LOG_DIR is commented
      If in user environment HADOOP_LOG_DIR is not exported then HADOOP_SECURE_DN_LOG_DIR env variable will export with "/" value and DN will logs in root directory.

      # Where log files are stored.  $HADOOP_HOME/logs by default.
      #export HADOOP_LOG_DIR=${HADOOP_LOG_DIR}/$USER
      
      # Where log files are stored in the secure data environment.
      export HADOOP_SECURE_DN_LOG_DIR=${HADOOP_LOG_DIR}/${HADOOP_HDFS_USER}
      

      I think we should comment this line.

      In hadoop-daemon.sh already handled case if value of HADOOP_SECURE_DN_LOG_DIR and HADOOP_LOG_DIR is empty.

      In hadoop-daemon.sh we assigning value of HADOOP_SECURE_DN_LOG_DIR in HADOOP_LOG_DIR and after that we are checking if HADOOP_LOG_DIR is empty then HADOOP_LOG_DIR env variable export with "$HADOOP_PREFIX/logs" value

      # Determine if we're starting a secure datanode, and if so, redefine appropriate variables
      if [ "$command" == "datanode" ] && [ "$EUID" -eq 0 ] && [ -n "$HADOOP_SECURE_DN_USER" ]; then
        export HADOOP_PID_DIR=$HADOOP_SECURE_DN_PID_DIR
        export HADOOP_LOG_DIR=$HADOOP_SECURE_DN_LOG_DIR
        export HADOOP_IDENT_STRING=$HADOOP_SECURE_DN_USER
        starting_secure_dn="true"
      fi
      
      if [ "$HADOOP_IDENT_STRING" = "" ]; then
        export HADOOP_IDENT_STRING="$USER"
      fi
      
      
      # get log directory
      if [ "$HADOOP_LOG_DIR" = "" ]; then
        export HADOOP_LOG_DIR="$HADOOP_PREFIX/logs"
      fi 
      
      1. HDFS-6576_1.patch
        1 kB
        Surendra Singh Lilhore
      2. HDFS-6576.patch
        0.8 kB
        Surendra Singh Lilhore
      3. HDFS-6576-branch-2.patch
        0.8 kB
        Surendra Singh Lilhore

        Activity

        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        I have attached a patch.

        Show
        surendrasingh Surendra Singh Lilhore added a comment - I have attached a patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12651661/HDFS-6576.patch
        against trunk revision 6b17eb9.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9290//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12651661/HDFS-6576.patch against trunk revision 6b17eb9. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9290//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12693578/HDFS-6576_1.patch
        against trunk revision 6b17eb9.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9291//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12693578/HDFS-6576_1.patch against trunk revision 6b17eb9. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9291//console This message is automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        patch no longer applies

        Show
        aw Allen Wittenauer added a comment - patch no longer applies
        Hide
        aw Allen Wittenauer added a comment -

        Actually, this is fixed in trunk so only if someone needs it in branch-2.

        Show
        aw Allen Wittenauer added a comment - Actually, this is fixed in trunk so only if someone needs it in branch-2.
        Hide
        surendrasingh Surendra Singh Lilhore added a comment -

        Attached patch for branch-2..

        Show
        surendrasingh Surendra Singh Lilhore added a comment - Attached patch for branch-2..
        Hide
        vinayrpet Vinayakumar B added a comment -

        Patch looks good to me. Committing soon.

        Show
        vinayrpet Vinayakumar B added a comment - Patch looks good to me. Committing soon.
        Hide
        vinayrpet Vinayakumar B added a comment -

        +1

        Show
        vinayrpet Vinayakumar B added a comment - +1
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to branch-2.
        Thanks Surendra Singh Lilhore for the patch.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to branch-2. Thanks Surendra Singh Lilhore for the patch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7774 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7774/)
        HDFS-6576. Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7774 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7774/ ) HDFS-6576 . Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/)
        HDFS-6576. Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/ ) HDFS-6576 . Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/)
        HDFS-6576. Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/ ) HDFS-6576 . Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/)
        HDFS-6576. Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/ ) HDFS-6576 . Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/)
        HDFS-6576. Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/ ) HDFS-6576 . Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/)
        HDFS-6576. Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/ ) HDFS-6576 . Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/)
        HDFS-6576. Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/ ) HDFS-6576 . Datanode log is generating at root directory in security mode (Contributed by surendra singh lilhore) (vinayakumarb: rev 46509617b6296eeeabf9d99e8ba365040bec05ad) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            surendrasingh Surendra Singh Lilhore
            Reporter:
            surendrasingh Surendra Singh Lilhore
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development