Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6517

Remove hadoop-metrics2.properties from hdfs project

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.6.0
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      HDFS-side of HADOOP-9919.
      HADOOP-9919 updated hadoop-metrics2.properties examples to YARN, however, the examples are still old because hadoop-metrics2.properties in HDFS project is actually packaged.

      1. HDFS-6517.patch
        2 kB
        Akira AJISAKA

        Issue Links

          Activity

          Hide
          Akira AJISAKA added a comment -

          Attaching a patch to remove hadoop-metrics2.properties from hdfs project.
          I executed mvn package to create package and confirmed the file (hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/hadoop-metrics2.properties) was updated to YARN.

          Show
          Akira AJISAKA added a comment - Attaching a patch to remove hadoop-metrics2.properties from hdfs project. I executed mvn package to create package and confirmed the file (hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/hadoop-metrics2.properties) was updated to YARN.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12649849/HDFS-6517.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7088//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7088//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649849/HDFS-6517.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7088//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7088//console This message is automatically generated.
          Hide
          Akira AJISAKA added a comment -

          The patch is just to remove a config file, so new tests are not needed.

          Show
          Akira AJISAKA added a comment - The patch is just to remove a config file, so new tests are not needed.
          Hide
          Allen Wittenauer added a comment -

          +1 lgtm.

          Show
          Allen Wittenauer added a comment - +1 lgtm.
          Hide
          Allen Wittenauer added a comment -

          Committed to both trunk and branch-2.

          Show
          Allen Wittenauer added a comment - Committed to both trunk and branch-2.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #6022 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6022/)
          HDFS-6517. Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616262)

          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #6022 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6022/ ) HDFS-6517 . Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616262 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/conf/hadoop-metrics2.properties HDFS-6517 . Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616261 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Akira AJISAKA added a comment -

          Thanks Allen for the review!

          Show
          Akira AJISAKA added a comment - Thanks Allen for the review!
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #636 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/636/)
          HDFS-6517. Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616262)

          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #636 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/636/ ) HDFS-6517 . Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616262 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/conf/hadoop-metrics2.properties HDFS-6517 . Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616261 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1830 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1830/)
          HDFS-6517. Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616262)

          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1830 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1830/ ) HDFS-6517 . Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616262 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/conf/hadoop-metrics2.properties HDFS-6517 . Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616261 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1856 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1856/)
          HDFS-6517. Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616262)

          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1856 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1856/ ) HDFS-6517 . Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616262 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/conf/hadoop-metrics2.properties HDFS-6517 . Remove hadoop-metrics2.properties from hdfs project (Akira AJISAKA via aw) (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1616261 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

            People

            • Assignee:
              Akira AJISAKA
              Reporter:
              Akira AJISAKA
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development