Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6443

Fix MiniQJMHACluster related test failures

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.5.0
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      MiniQJMHACluster uses fixed ports(10000/10001/10002/10003) to set up a cluster for testing, this will result in port conflicts when multiple tests which rely on MiniQJMHACluster running concurrently. The can easily reproduce when run 'mvn test -Pparallel-tests' under hadoop-hdfs directory.

      1. HDFS-6443.1.patch
        6 kB
        Zesheng Wu
      2. HDFS-6443.patch
        11 kB
        Zesheng Wu

        Activity

        Hide
        Arpit Agarwal added a comment -

        Thanks for reporting this and the patch Zesheng Wu.

        A better solution is to randomize the initial port selection and optionally add a retry or two in case the chosen port is in use.

        Show
        Arpit Agarwal added a comment - Thanks for reporting this and the patch Zesheng Wu . A better solution is to randomize the initial port selection and optionally add a retry or two in case the chosen port is in use.
        Hide
        Zesheng Wu added a comment -

        Thanks Arpit Agarwal, randomized port selection with retrying is really a better solution, I will generate a new patch soon.

        Show
        Zesheng Wu added a comment - Thanks Arpit Agarwal , randomized port selection with retrying is really a better solution, I will generate a new patch soon.
        Hide
        Zesheng Wu added a comment -

        Updated patch according to Arpit Agarwal's comments.

        Show
        Zesheng Wu added a comment - Updated patch according to Arpit Agarwal's comments.
        Hide
        Arpit Agarwal added a comment -

        Thanks for addressing the feedback Zesheng Wu.

        +1 for the updated patch, pending Jenkins.

        Show
        Arpit Agarwal added a comment - Thanks for addressing the feedback Zesheng Wu . +1 for the updated patch, pending Jenkins.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12646457/HDFS-6443.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6958//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6958//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12646457/HDFS-6443.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6958//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6958//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12646457/HDFS-6443.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6961//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6961//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12646457/HDFS-6443.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6961//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6961//console This message is automatically generated.
        Hide
        Zesheng Wu added a comment -

        Thanks Arpit Agarwal for reviewing the patch.
        BTW: The failed test isn't relate to this JIRA.

        Show
        Zesheng Wu added a comment - Thanks Arpit Agarwal for reviewing the patch. BTW: The failed test isn't relate to this JIRA.
        Hide
        Arpit Agarwal added a comment -

        I committed this to trunk and branch-2. I also added you as a contributor in HDFS Zesheng Wu.

        Thanks for the patch and look forward to your future contributions.

        Show
        Arpit Agarwal added a comment - I committed this to trunk and branch-2. I also added you as a contributor in HDFS Zesheng Wu . Thanks for the patch and look forward to your future contributions.
        Hide
        Zesheng Wu added a comment -

        Thanks Arpit Agarwal, I will spend more time on HDFS in the future.

        Show
        Zesheng Wu added a comment - Thanks Arpit Agarwal , I will spend more time on HDFS in the future.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #5609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5609/)
        HDFS-6443. Fix MiniQJMHACluster related test failures. (Contributed by Zesheng Wu) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1597238)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #5609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5609/ ) HDFS-6443 . Fix MiniQJMHACluster related test failures. (Contributed by Zesheng Wu) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1597238 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #564 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/564/)
        HDFS-6443. Fix MiniQJMHACluster related test failures. (Contributed by Zesheng Wu) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1597238)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #564 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/564/ ) HDFS-6443 . Fix MiniQJMHACluster related test failures. (Contributed by Zesheng Wu) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1597238 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1756 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1756/)
        HDFS-6443. Fix MiniQJMHACluster related test failures. (Contributed by Zesheng Wu) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1597238)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1756 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1756/ ) HDFS-6443 . Fix MiniQJMHACluster related test failures. (Contributed by Zesheng Wu) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1597238 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1782 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1782/)
        HDFS-6443. Fix MiniQJMHACluster related test failures. (Contributed by Zesheng Wu) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1597238)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1782 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1782/ ) HDFS-6443 . Fix MiniQJMHACluster related test failures. (Contributed by Zesheng Wu) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1597238 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java

          People

          • Assignee:
            Zesheng Wu
            Reporter:
            Zesheng Wu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development