Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: HDFS XAttrs (HDFS-2006)
    • Fix Version/s: HDFS XAttrs (HDFS-2006)
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Some javadoc improvements and minor comment fixups from HDFS-6299

      1. HDFS-6309.3.patch
        5 kB
        Charles Lamb
      2. HDFS-6309.2.patch
        5 kB
        Charles Lamb
      3. HDFS-6309.1.patch
        3 kB
        Charles Lamb

        Activity

        Uma Maheswara Rao G created issue -
        Uma Maheswara Rao G made changes -
        Field Original Value New Value
        Component/s namenode [ 12312926 ]
        Uma Maheswara Rao G made changes -
        Assignee Yi Liu [ hitliuyi ]
        Uma Maheswara Rao G made changes -
        Affects Version/s HDFS XAttrs (HDFS-2006) [ 12326771 ]
        Uma Maheswara Rao G made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Uma Maheswara Rao G made changes -
        Summary Javadocs for Xattrs apis in DFSCliengt and other minor fixups Javadocs for Xattrs apis in DFSClient and other minor fixups
        Yi Liu made changes -
        Assignee Yi Liu [ hitliuyi ] Charles Lamb [ clamb ]
        Hide
        Charles Lamb added a comment -

        Here are some minor javadoc fixes and cleanups to XAttr.java.

        Show
        Charles Lamb added a comment - Here are some minor javadoc fixes and cleanups to XAttr.java.
        Charles Lamb made changes -
        Attachment HDFS-6309.1.patch [ 12642639 ]
        Hide
        Uma Maheswara Rao G added a comment -

        Patch looks good to me.
        Could you also consider the suggestion from Fengdong Yu at HDFS-6299?

        Another, try to use !result.isEmpty(), instead of 'result.size() > 0'

        Right, isEmpty() is efficient, and I will add this improvement.

        Show
        Uma Maheswara Rao G added a comment - Patch looks good to me. Could you also consider the suggestion from Fengdong Yu at HDFS-6299 ? Another, try to use !result.isEmpty(), instead of 'result.size() > 0' Right, isEmpty() is efficient, and I will add this improvement.
        Hide
        Charles Lamb added a comment -

        Fix typo in DFSClient.java

        Show
        Charles Lamb added a comment - Fix typo in DFSClient.java
        Charles Lamb made changes -
        Attachment HDFS-6309.2.patch [ 12642654 ]
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks a lot Charles for the patch.

        Patch looks good to me.
        +1

        I will commit the patch shortly to the branch!

        Show
        Uma Maheswara Rao G added a comment - Thanks a lot Charles for the patch. Patch looks good to me. +1 I will commit the patch shortly to the branch!
        Hide
        Uma Maheswara Rao G added a comment -

        I will take back my +1 on this.

        Here your logic should be:

         if (result != null && result.isEmpty()) {
        

        to

         if (result != null && !result.isEmpty()) {
        
        Show
        Uma Maheswara Rao G added a comment - I will take back my +1 on this. Here your logic should be: if (result != null && result.isEmpty()) { to if (result != null && !result.isEmpty()) {
        Charles Lamb made changes -
        Attachment HDFS-6309.3.patch [ 12642857 ]
        Hide
        Charles Lamb added a comment -

        Sorry about that. The right patch is attached.

        Show
        Charles Lamb added a comment - Sorry about that. The right patch is attached.
        Hide
        Charles Lamb added a comment -

        ... as well you should. Sorry about that. A better patch has been attached.

        Show
        Charles Lamb added a comment - ... as well you should. Sorry about that. A better patch has been attached.
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks a lot, Charles!
        Latest patch looks good to me. Will commit the patch to branch!.

        Show
        Uma Maheswara Rao G added a comment - Thanks a lot, Charles! Latest patch looks good to me. Will commit the patch to branch!.
        Hide
        Uma Maheswara Rao G added a comment -

        I have just committed this to branch!

        Show
        Uma Maheswara Rao G added a comment - I have just committed this to branch!
        Uma Maheswara Rao G made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s HDFS XAttrs (HDFS-2006) [ 12326771 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 7h 9m 1 Uma Maheswara Rao G 01/May/14 18:31

          People

          • Assignee:
            Charles Lamb
            Reporter:
            Uma Maheswara Rao G
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development