Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6291

FSImage may be left unclosed in BootstrapStandby#doRun()

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0
    • Component/s: ha
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      At around line 203:

            if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
              return ERR_CODE_LOGS_UNAVAILABLE;
            }
      

      If we return following the above check, image is not closed.

      1. HDFS-6291.2.patch
        0.7 kB
        Sanghyun Yun
      2. HDFS-6291.patch
        0.6 kB
        Sanghyun Yun

        Activity

        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/)
        HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #189 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/189/ ) HDFS-6291 . FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/)
        HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/ ) HDFS-6291 . FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/)
        HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/ ) HDFS-6291 . FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/)
        HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/ ) HDFS-6291 . FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/)
        HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/190/ ) HDFS-6291 . FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/)
        HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/ ) HDFS-6291 . FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7770 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7770/)
        HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7770 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7770/ ) HDFS-6291 . FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Vinayakumar B added a comment -

        Committed to trunk and branch-2.
        Thanks Sanghyun Yun, Ted Yu and Rakesh R

        Show
        Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks Sanghyun Yun , Ted Yu and Rakesh R
        Hide
        Uma Maheswara Rao G added a comment -

        +1, thanks for the patch. Will commit it shortly.

        Show
        Uma Maheswara Rao G added a comment - +1, thanks for the patch. Will commit it shortly.
        Hide
        Rakesh R added a comment -

        Thanks Sanghyun Yun for the patch. lgtm +1 (non-binding)

        Show
        Rakesh R added a comment - Thanks Sanghyun Yun for the patch. lgtm +1 (non-binding)
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 33s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 17s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 164m 42s Tests failed in hadoop-hdfs.
            207m 28s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12677224/HDFS-6291.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a319771
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10767/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10767/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10767/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 17s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 164m 42s Tests failed in hadoop-hdfs.     207m 28s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12677224/HDFS-6291.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a319771 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10767/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10767/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10767/console This message was automatically generated.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 47s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 48s There were no new javac warning messages.
        +1 javadoc 9m 59s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 15s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 20s Pre-build of native portion
        -1 hdfs tests 165m 6s Tests failed in hadoop-hdfs.
            209m 0s  



        Reason Tests
        Timed out tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12677224/HDFS-6291.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a319771
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10741/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10741/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10741/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 59s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 15s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 20s Pre-build of native portion -1 hdfs tests 165m 6s Tests failed in hadoop-hdfs.     209m 0s   Reason Tests Timed out tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12677224/HDFS-6291.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a319771 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10741/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10741/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10741/console This message was automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12677224/HDFS-6291.2.patch
        against trunk revision caecd9f.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8546//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8546//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12677224/HDFS-6291.2.patch against trunk revision caecd9f. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8546//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8546//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        lgtm

        Show
        Ted Yu added a comment - lgtm
        Hide
        Sanghyun Yun added a comment -

        Thanks for your review, Ted Yu.
        You are right. I removed image.close() in catch block.

        Show
        Sanghyun Yun added a comment - Thanks for your review, Ted Yu . You are right. I removed image.close() in catch block.
        Hide
        Ted Yu added a comment -

        With image.close() in finally block, the catch block doesn't need to call it, right ?

        Show
        Ted Yu added a comment - With image.close() in finally block, the catch block doesn't need to call it, right ?
        Hide
        Sanghyun Yun added a comment -

        Please review my patch, Vinayakumar B and Ted Yu.
        And can I assign to me this issue?

        Show
        Sanghyun Yun added a comment - Please review my patch, Vinayakumar B and Ted Yu . And can I assign to me this issue?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12662718/HDFS-6291.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7684//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7684//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12662718/HDFS-6291.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7684//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7684//console This message is automatically generated.
        Hide
        Sanghyun Yun added a comment -

        I add image.close() in finally

        Show
        Sanghyun Yun added a comment - I add image.close() in finally
        Hide
        Vinayakumar B added a comment -

        Yes! you are right.
        image.close() should be finally clause.

        Show
        Vinayakumar B added a comment - Yes! you are right. image.close() should be finally clause.

          People

          • Assignee:
            Sanghyun Yun
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development