Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.8.0
    • Component/s: tools
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      It would be useful if PBImageXmlWriter outputs AclEntry also.

      1. HDFS-6249_1.patch
        6 kB
        Surendra Singh Lilhore
      2. HDFS-6249.patch
        4 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          Akira AJISAKA added a comment -

          The patch to fix this issue will

          1. output AclEntry in PBImageXmlWriter
          2. add AclEntry in the fsimage to test.

          I think it's better to wait to create a patch until HDFS-6210 is resolved because the issue contains the latter.

          Show
          Akira AJISAKA added a comment - The patch to fix this issue will output AclEntry in PBImageXmlWriter add AclEntry in the fsimage to test. I think it's better to wait to create a patch until HDFS-6210 is resolved because the issue contains the latter.
          Hide
          Surendra Singh Lilhore added a comment -

          Attached patch, Please review...

          Show
          Surendra Singh Lilhore added a comment - Attached patch, Please review...
          Hide
          Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 2s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 44s There were no new javac warning messages.
          +1 javadoc 9m 48s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 14s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 22s Pre-build of native portion
          +1 hdfs tests 161m 10s Tests passed in hadoop-hdfs.
              208m 15s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12739036/HDFS-6249.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 95c73d4
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11311/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11311/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11311/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 48s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 14s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 22s Pre-build of native portion +1 hdfs tests 161m 10s Tests passed in hadoop-hdfs.     208m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739036/HDFS-6249.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 95c73d4 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11311/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11311/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11311/console This message was automatically generated.
          Hide
          Surendra Singh Lilhore added a comment -

          Akira AJISAKA, would you please review the patch?

          Show
          Surendra Singh Lilhore added a comment - Akira AJISAKA , would you please review the patch?
          Hide
          Akira AJISAKA added a comment -

          Thanks Surendra Singh Lilhore for taking this issue.
          1. Would you move the following code into dumpAcls method to reduce code duplication?

              ImmutableList<AclEntry> aclEntryList = dumpAcls(f.getAcl());
              if (aclEntryList.size() > 0) {
                out.print("<acls>");
                for (AclEntry aclEntry : aclEntryList) {
                  o("acl", aclEntry.toString());
                }
                out.print("</acls>");
              }
          

          2. Would you add a test case such as TestOfflineImageViewer#testPBImageXmlWriter to TestOfflineImageViewerForAcl.java?

          Show
          Akira AJISAKA added a comment - Thanks Surendra Singh Lilhore for taking this issue. 1. Would you move the following code into dumpAcls method to reduce code duplication? ImmutableList<AclEntry> aclEntryList = dumpAcls(f.getAcl()); if (aclEntryList.size() > 0) { out.print( "<acls>" ); for (AclEntry aclEntry : aclEntryList) { o( "acl" , aclEntry.toString()); } out.print( "</acls>" ); } 2. Would you add a test case such as TestOfflineImageViewer#testPBImageXmlWriter to TestOfflineImageViewerForAcl.java?
          Hide
          Surendra Singh Lilhore added a comment -

          Thanks Akira AJISAKA for review and suggestion
          Attached new patch, Please review...

          Show
          Surendra Singh Lilhore added a comment - Thanks Akira AJISAKA for review and suggestion Attached new patch, Please review...
          Hide
          Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 48s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 12s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 15s Pre-build of native portion
          +1 hdfs tests 162m 0s Tests passed in hadoop-hdfs.
              208m 19s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12740073/HDFS-6249_1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ebb9a82
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11386/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11386/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11386/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11386/console

          This message was automatically generated.

          Show
          Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 12s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion +1 hdfs tests 162m 0s Tests passed in hadoop-hdfs.     208m 19s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740073/HDFS-6249_1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ebb9a82 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11386/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11386/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11386/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11386/console This message was automatically generated.
          Hide
          Akira AJISAKA added a comment -
          Show
          Akira AJISAKA added a comment - +1, thanks Surendra Singh Lilhore .
          Hide
          Akira AJISAKA added a comment -

          I've committed this patch to trunk and branch-2. Thanks Surendra Singh Lilhore for the contribution!

          Show
          Akira AJISAKA added a comment - I've committed this patch to trunk and branch-2. Thanks Surendra Singh Lilhore for the contribution!
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8035 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8035/)
          HDFS-6249. Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8035 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8035/ ) HDFS-6249 . Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #962 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/962/)
          HDFS-6249. Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #962 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/962/ ) HDFS-6249 . Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #232 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/232/)
          HDFS-6249. Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #232 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/232/ ) HDFS-6249 . Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2160 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2160/)
          HDFS-6249. Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2160 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2160/ ) HDFS-6249 . Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #221 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/221/)
          HDFS-6249. Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #221 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/221/ ) HDFS-6249 . Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/230/)
          HDFS-6249. Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/230/ ) HDFS-6249 . Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2178 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2178/)
          HDFS-6249. Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2178 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2178/ ) HDFS-6249 . Output AclEntry in PBImageXmlWriter. Contributed by surendra singh lilhore. (aajisaka: rev cc432885adb0182c2c5b3bf92edde12231fd567c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

            People

            • Assignee:
              Surendra Singh Lilhore
              Reporter:
              Akira AJISAKA
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development