[HDFS-6038] Allow JournalNode to handle editlog produced by new release with future layoutversion

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.4.0
• Component/s: journal-node, namenode
• Hadoop Flags: Reviewed
• Assignee: Jing Zhao
• Reporter: Haohui Mai
• Created: 03/Mar/14 18:54
• Updated: 16/Apr/15 19:58
• Resolved: 20/Mar/14 23:13

Description

In HA setup, the JNs receive edit logs (blob) from the NN and write into edit log files. In order to write well-formed edit log files, the JNs prepend a header for each edit log file. The problem is that the JN hard-codes the version (i.e., NameNodeLayoutVersion in the edit log, therefore it generates incorrect edit logs when the newer release bumps the NameNodeLayoutVersion during rolling upgrade.

In the meanwhile, currently JN tries to decode the in-progress editlog segment in order to know the last txid in the segment. In the rolling upgrade scenario, the JN with the old software may not be able to correctly decode the editlog generated by the new software.

This jira makes the following changes to allow JN to handle editlog produced by software with future layoutversion:
1. Change the NN--JN startLogSegment RPC signature and let NN specify the layoutversion for the new editlog segment.
2. Persist a length field for each editlog op to indicate the total length of the op. Instead of calling EditLogFileInputStream#validateEditLog to get the last txid of an in-progress editlog segment, a new method scanEditLog is added and used by JN which does not decode each editlog op but uses the length to quickly jump to the next op.

Issue Links

• is duplicated by: HDFS-5995 TestFSEditLogLoader#testValidateEditLogWithCorruptBody gets OutOfMemoryError and dumps heap.