Details

    • Hadoop Flags:
      Reviewed

      Description

      When rolling upgrade is initiated, a image is created for rollback. We propose the following changes for the DFSAdmin for rolling upgrade commands:

      • change "dfsadmin -rollingUpgrade start" to "dfsadmin -rollingUpgrade prepare";
      • add information for the rollback image to "dfsadmin -rollingUpgrade query".
      1. h6004_20140224.patch
        12 kB
        Tsz Wo Nicholas Sze
      2. h6004_20140224b.patch
        15 kB
        Tsz Wo Nicholas Sze
      3. h6004_20140224c.patch
        19 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h6004_20140224.patch: 1st patch.

        Show
        Tsz Wo Nicholas Sze added a comment - h6004_20140224.patch: 1st patch.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h6004_20140224b.patch: fixes test failures.

        Show
        Tsz Wo Nicholas Sze added a comment - h6004_20140224b.patch: fixes test failures.
        Hide
        Arpit Agarwal added a comment -

        Hi Nicholas, when startRollingUpgradeInternal returns the rollback image has been saved so should rollingUpgradeInfo#createdRollbackImages be initialized to true?

        Show
        Arpit Agarwal added a comment - Hi Nicholas, when startRollingUpgradeInternal returns the rollback image has been saved so should rollingUpgradeInfo#createdRollbackImages be initialized to true?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Arpit, good catch and thanks for the review!

        h6004_20140224c.patch: sets createdRollbackImages and revises some other rolling upgrade related messages in DFSAdmin.

        Show
        Tsz Wo Nicholas Sze added a comment - Arpit, good catch and thanks for the review! h6004_20140224c.patch: sets createdRollbackImages and revises some other rolling upgrade related messages in DFSAdmin.
        Hide
        Arpit Agarwal added a comment -

        +1 for the patch. I committed it to the feature branch as r1571463. Thanks Nicholas!

        Show
        Arpit Agarwal added a comment - +1 for the patch. I committed it to the feature branch as r1571463. Thanks Nicholas!

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development