Details

    • Hadoop Flags:
      Reviewed

      Description

      MD5FileUtils.readStoredMd5(File md5File) may return null but the callers may not check it.

      TestOfflineEditsViewer needs new editsStored files.

      1. h5992_20140220.patch
        32 kB
        Tsz Wo Nicholas Sze
      2. editsStored
        4 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h5992_20140220.patch: fix MD5FileUtils and TestOfflineEditsViewer.
        editsStored: the new binary file.

        Show
        Tsz Wo Nicholas Sze added a comment - h5992_20140220.patch: fix MD5FileUtils and TestOfflineEditsViewer. editsStored: the new binary file.
        Hide
        Chris Nauroth added a comment -

        Hi Nicholas,

        This patch basically looks good, but it seems the editsStored.xml diff contains unresolved merge conflicts. +1 after that is addressed.

        Show
        Chris Nauroth added a comment - Hi Nicholas, This patch basically looks good, but it seems the editsStored.xml diff contains unresolved merge conflicts. +1 after that is addressed.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks Chris for taking a look. The unresolved merge conflicts were generated by previous merge and already committed to the branch. The patch actually cleans up all the conflicts. Could take a look again?

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks Chris for taking a look. The unresolved merge conflicts were generated by previous merge and already committed to the branch. The patch actually cleans up all the conflicts. Could take a look again?
        Hide
        Chris Nauroth added a comment -

        Oh, I see. My mistake.

        +1 for the patch. Thanks, Nicholas!

        Show
        Chris Nauroth added a comment - Oh, I see. My mistake. +1 for the patch. Thanks, Nicholas!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Chris, thanks again for reviewing the patch.

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - Chris, thanks again for reviewing the patch. I have committed this.

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development