[HDFS-596] Memory leak in libhdfs: hdfsFreeFileInfo() in libhdfs does not free memory for mOwner and mGroup

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.20.1
• Fix Version/s: 0.20.2, 0.21.0
• Component/s: fuse-dfs

Environment

Linux hadoop-001 2.6.28-14-server #47-Ubuntu SMP Sat Jul 25 01:18:34 UTC 2009 i686 GNU/Linux. Namenode with 1GB memory.

• Hadoop Flags: Reviewed
• Release Note: Memory leak in function hdfsFreeFileInfo in libhdfs. This bug affects fuse-dfs severely.
• Tags: memory leak libhdfs hdfsFreeFileInfo fuse-dfs
• Assignee: Zhang Bingjun
• Reporter: Zhang Bingjun
• Created: 04/Sep/09 08:23
• Updated: 24/Aug/10 20:49
• Resolved: 16/Nov/09 06:56

Description

This bugs affects fuse-dfs severely. In my test, about 1GB memory were exhausted and the fuse-dfs mount directory was disconnected after writing 14000 files. This bug is related to the memory leak problem of this issue: http://issues.apache.org/jira/browse/HDFS-420.

The bug can be fixed very easily. In function hdfsFreeFileInfo() in file hdfs.c (under c++/libhdfs/) change code block:

//Free the mName
int i;
for (i=0; i < numEntries; ++i) {
if (hdfsFileInfo[i].mName)

{ free(hdfsFileInfo[i].mName); }
}

into:

// free mName, mOwner and mGroup
int i;
for (i=0; i < numEntries; ++i) {
if (hdfsFileInfo[i].mName) { free(hdfsFileInfo[i].mName); }

if (hdfsFileInfo[i].mOwner)

{ free(hdfsFileInfo[i].mOwner); }

if (hdfsFileInfo[i].mGroup)

{ free(hdfsFileInfo[i].mGroup); }

}

I am new to Jira and haven't figured out a way to generate .patch file yet. Could anyone help me do that so that others can commit the changes into the code base. Thanks!

Issue Links

• relates to: HDFS-773 libhdfs test for memory leaks