HDFS-5698 uses protobuf to serialize the FSImage. The code needs to be updated to work with these changes.
Refactor FSImageFormatProtobuf to simplify cross section reads
The v0 patch serializes / deserializes ACL-related information in the PB-based FSImage format.
Fixes on TestOfflineImageViewer and TestOfflineEditsViewer are not covered in this jira.
Hi, Haohui Mai. Thanks for taking care of the merge of the fsimage protobuf changes. This patch seems to make sense overall, but I can't apply it to the current HDFS-4685 branch. Could you please rebase it?
You'll need to apply HDFS-5915 before this patch.
Sorry I missed the HDFS-5915 pre-requisite first time. A few minor comments:
Thanks Chris for the comments.
The v1 patch no longer serializes the ACLs for a symlink.
Based on the discussion of HDFS-5899, this patch removes the TestAclConfigFlag#testFsImage test.
+1 for the patch. I committed it to the HDFS-4685 branch. Thanks again for taking care of this, Haohui.