Details

      Description

      HDFS-5698 uses protobuf to serialize the FSImage. The code needs to be updated to work with these changes.

      1. HDFS-5914.000.patch
        37 kB
        Haohui Mai
      2. HDFS-5914.001.patch
        39 kB
        Haohui Mai

        Issue Links

          Activity

          Hide
          Haohui Mai added a comment -

          The v0 patch serializes / deserializes ACL-related information in the PB-based FSImage format.

          Fixes on TestOfflineImageViewer and TestOfflineEditsViewer are not covered in this jira.

          Show
          Haohui Mai added a comment - The v0 patch serializes / deserializes ACL-related information in the PB-based FSImage format. Fixes on TestOfflineImageViewer and TestOfflineEditsViewer are not covered in this jira.
          Hide
          Chris Nauroth added a comment -

          Hi, Haohui Mai. Thanks for taking care of the merge of the fsimage protobuf changes. This patch seems to make sense overall, but I can't apply it to the current HDFS-4685 branch. Could you please rebase it?

          Show
          Chris Nauroth added a comment - Hi, Haohui Mai . Thanks for taking care of the merge of the fsimage protobuf changes. This patch seems to make sense overall, but I can't apply it to the current HDFS-4685 branch. Could you please rebase it?
          Hide
          Haohui Mai added a comment -

          You'll need to apply HDFS-5915 before this patch.

          Show
          Haohui Mai added a comment - You'll need to apply HDFS-5915 before this patch.
          Hide
          Chris Nauroth added a comment -

          Sorry I missed the HDFS-5915 pre-requisite first time. A few minor comments:

          1. FSImageFormatPBINode: Symlinks don't get ACLs of their own. Shall we skip serialization/deserialization of ACLs here for symlinks?
          2. TestAclConfigFlag#testFsImage is failing now, because it allowed loading of an fsimage containing an ACL even though ACLs were disabled in configuration. Previously, this was rejected by FSImageFormat#loadAclFeature checking the config flag.
          3. FSImageFormatProtobuf: Minor typo: I think saveExtendAclSection was meant to be named saveExtendedAclSection.
          Show
          Chris Nauroth added a comment - Sorry I missed the HDFS-5915 pre-requisite first time. A few minor comments: FSImageFormatPBINode : Symlinks don't get ACLs of their own. Shall we skip serialization/deserialization of ACLs here for symlinks? TestAclConfigFlag#testFsImage is failing now, because it allowed loading of an fsimage containing an ACL even though ACLs were disabled in configuration. Previously, this was rejected by FSImageFormat#loadAclFeature checking the config flag. FSImageFormatProtobuf : Minor typo: I think saveExtendAclSection was meant to be named saveExtendedAclSection .
          Hide
          Haohui Mai added a comment -

          Thanks Chris for the comments.

          The v1 patch no longer serializes the ACLs for a symlink.

          Based on the discussion of HDFS-5899, this patch removes the TestAclConfigFlag#testFsImage test.

          Show
          Haohui Mai added a comment - Thanks Chris for the comments. The v1 patch no longer serializes the ACLs for a symlink. Based on the discussion of HDFS-5899 , this patch removes the TestAclConfigFlag#testFsImage test.
          Hide
          Chris Nauroth added a comment -

          +1 for the patch. I committed it to the HDFS-4685 branch. Thanks again for taking care of this, Haohui.

          Show
          Chris Nauroth added a comment - +1 for the patch. I committed it to the HDFS-4685 branch. Thanks again for taking care of this, Haohui.

            People

            • Assignee:
              Haohui Mai
              Reporter:
              Haohui Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development