Details
-
Type:
Sub-task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: HDFS-5535 (Rolling upgrades)
-
Component/s: datanode
-
Labels:None
-
Hadoop Flags:Reviewed
Description
As Vinayakumar B pointed out in HDFS-5754: in DataStorage DATANODE_LAYOUT_VERSION should not compare with NameNode layout version anymore.
if (DataNodeLayoutVersion.supports(
LayoutVersion.Feature.FEDERATION,
HdfsConstants.DATANODE_LAYOUT_VERSION) &&
HdfsConstants.DATANODE_LAYOUT_VERSION == nsInfo.getLayoutVersion()) {
readProperties(sd, nsInfo.getLayoutVersion());
Issue Links
- is related to
-
HDFS-5754
Split LayoutVerion into NamenodeLayoutVersion and DatanodeLayoutVersion
-
- Resolved
-
Activity
Thanks for filing this jira Brandon.
Show
Vinayakumar B
added a comment - Thanks for filing this jira Brandon.
Uploaded a patch to address the comments.
Show
Brandon Li
added a comment - Uploaded a patch to address the comments.
+1 patch looks good.
Show
Tsz Wo Nicholas Sze
added a comment - +1 patch looks good.
Thank you, Nicholas. I've committed the patch.
Show
Brandon Li
added a comment - Thank you, Nicholas. I've committed the patch.
Noticed the following check should also be removed from DataStorage#recoverTransitionRead():
assert this.getLayoutVersion() == nsInfo.getLayoutVersion() : "Data-node and name-node layout versions must be the same.";