Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-5802

NameNode does not check for inode type before traversing down a path

    Details

    • Hadoop Flags:
      Reviewed

      Description

      This came up during the discussion on a forum at http://community.cloudera.com/t5/Batch-Processing-and-Workflow/Permission-denied-access-EXECUTE-on-getting-the-status-of-a-file/m-p/5049#M162 surrounding an fs.exists(…) check running on a path /foo/bar, where /foo is a file and not a directory.

      In such a case, NameNode yields a user-confusing message of Permission denied: user=foo, access=EXECUTE, inode="/foo":foo:foo:rw-rr- instead of clearly saying (and realising) "/foo is not a directory" or "/foo is a file" before it tries to traverse further down to locate the requested path.

      1. HDFS-5802.001.patch
        4 kB
        Xiao Chen
      2. HDFS-5802.002.patch
        4 kB
        Xiao Chen
      3. HDFS-5802.003.patch
        4 kB
        Xiao Chen
      4. HDFS-5802.004.patch
        4 kB
        Xiao Chen
      5. HDFS-5802.005.patch
        4 kB
        Xiao Chen
      6. HDFS-5802.006.patch
        4 kB
        Xiao Chen

        Issue Links

          Activity

          Hide
          xiaochen Xiao Chen added a comment -

          Hi Harsh,

          Thanks for reporting the issue. I'll be working on it.

          Show
          xiaochen Xiao Chen added a comment - Hi Harsh, Thanks for reporting the issue. I'll be working on it.
          Hide
          xiaochen Xiao Chen added a comment -

          Enhanced the message under the reported scenario to mention /foo is not a directory.

          Show
          xiaochen Xiao Chen added a comment - Enhanced the message under the reported scenario to mention /foo is not a directory.
          Hide
          xiaochen Xiao Chen added a comment -

          Enhanced the message under the reported scenario to mention /foo is not a directory.

          Show
          xiaochen Xiao Chen added a comment - Enhanced the message under the reported scenario to mention /foo is not a directory.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 31s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 4s There were no new javac warning messages.
          +1 javadoc 10m 22s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 38s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          -1 findbugs 2m 32s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          +1 native 3m 13s Pre-build of native portion
          -1 hdfs tests 81m 37s Tests failed in hadoop-hdfs.
              125m 32s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Failed unit tests hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
            hadoop.hdfs.server.namenode.TestFileLimit
            hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot
            hadoop.hdfs.server.namenode.TestEditLogAutoroll
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.server.namenode.TestHostsFiles
            hadoop.hdfs.server.namenode.TestFileContextAcl
            hadoop.hdfs.server.namenode.TestClusterId
            hadoop.hdfs.server.namenode.TestDeleteRace
            hadoop.hdfs.server.namenode.TestFSDirectory
            hadoop.hdfs.server.namenode.TestLeaseManager
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.datanode.TestSimulatedFSDataset
            hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
            hadoop.hdfs.server.namenode.ha.TestGetGroupsWithHA
            hadoop.hdfs.server.namenode.TestSecondaryWebUi
            hadoop.hdfs.server.namenode.TestMalformedURLs
            hadoop.hdfs.server.namenode.TestAuditLogger
            hadoop.hdfs.server.namenode.TestHDFSConcat
            hadoop.hdfs.server.namenode.TestAddBlockRetry
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
            hadoop.hdfs.server.namenode.ha.TestHAMetrics
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap
            hadoop.hdfs.server.namenode.TestFsLimits
            hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional
            hadoop.hdfs.server.datanode.TestHSync
            hadoop.hdfs.server.namenode.TestNameNodeRpcServer
            hadoop.hdfs.server.namenode.TestFSImageWithXAttr
            hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot
            hadoop.hdfs.server.namenode.TestFSImageWithAcl
            hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement
            hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
            hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.server.namenode.TestParallelImageWrite
            hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot
            hadoop.hdfs.server.namenode.TestNameNodeResourceChecker
            hadoop.hdfs.server.namenode.TestGenericJournalConf
            hadoop.hdfs.server.namenode.TestEditLogJournalFailures
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport
            hadoop.hdfs.server.namenode.TestFSNamesystemMBean
            hadoop.hdfs.server.namenode.TestEditLogRace
            hadoop.hdfs.server.namenode.TestAllowFormat
            hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots
            hadoop.hdfs.server.namenode.TestProtectedDirectories
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics
            hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.namenode.TestINodeFile
            hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.server.namenode.TestQuotaByStorageType
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
            hadoop.hdfs.server.namenode.ha.TestNNHealthCheck
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters
            hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
            hadoop.hdfs.server.namenode.TestBlockUnderConstruction
            hadoop.hdfs.server.namenode.TestDeadDatanode
            hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy
            hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
            hadoop.hdfs.server.datanode.TestIncrementalBlockReports
            hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled
            hadoop.hdfs.server.namenode.TestStorageRestore
            hadoop.hdfs.server.namenode.TestFSNamesystem
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.server.namenode.ha.TestHAFsck
            hadoop.hdfs.server.namenode.TestXAttrConfigFlag
            hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
            hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot
            hadoop.hdfs.server.namenode.TestNameNodeRespectsBindHostKeys
            hadoop.hdfs.server.datanode.TestDataNodeMXBean
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes
            hadoop.hdfs.server.namenode.TestSnapshotPathINodes
            hadoop.hdfs.server.namenode.ha.TestStateTransitionFailure
            hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
            hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            hadoop.hdfs.server.namenode.TestFsck
            hadoop.hdfs.server.namenode.TestAuditLogs
            hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
            hadoop.hdfs.server.datanode.TestDataNodeECN
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.server.namenode.TestNameEditsConfigs
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.server.namenode.TestTruncateQuotaUpdate
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
            hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
            hadoop.hdfs.server.namenode.ha.TestHASafeMode
            hadoop.hdfs.server.namenode.TestSecureNameNode
            hadoop.hdfs.server.namenode.snapshot.TestSnapshot
            hadoop.hdfs.server.namenode.TestStartup
            hadoop.hdfs.server.namenode.TestNameNodeRecovery
            hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.hdfs.server.namenode.TestGetBlockLocations
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA
            hadoop.hdfs.server.namenode.TestINodeAttributeProvider
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
            hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
            hadoop.hdfs.server.namenode.TestMetadataVersionOutput
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler
            hadoop.hdfs.server.namenode.TestSaveNamespace
            hadoop.hdfs.server.namenode.TestMetaSave
            hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens
            hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
            hadoop.hdfs.server.datanode.TestIncrementalBrVariations
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.TestBackupNode
            hadoop.hdfs.server.namenode.TestNameNodeAcl
            hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd
            hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
            hadoop.hdfs.server.namenode.TestAddBlock
            hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing
            hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot
            hadoop.hdfs.server.namenode.TestNameNodeXAttr
            hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean
            hadoop.hdfs.server.namenode.ha.TestDNFencing
            hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
          Timed out tests org.apache.hadoop.hdfs.TestReplication
            org.apache.hadoop.hdfs.TestPread
            org.apache.hadoop.hdfs.qjournal.client.TestQJMWithFaults
            org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12756366/HDFS-5802.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 941001b
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12495/artifact/patchprocess/whitespace.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12495/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12495/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12495/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12495/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 31s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 4s There were no new javac warning messages. +1 javadoc 10m 22s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 38s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. -1 findbugs 2m 32s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 81m 37s Tests failed in hadoop-hdfs.     125m 32s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots   hadoop.hdfs.server.namenode.TestFileLimit   hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot   hadoop.hdfs.server.namenode.TestEditLogAutoroll   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.namenode.TestHostsFiles   hadoop.hdfs.server.namenode.TestFileContextAcl   hadoop.hdfs.server.namenode.TestClusterId   hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.server.namenode.TestFSDirectory   hadoop.hdfs.server.namenode.TestLeaseManager   hadoop.hdfs.server.namenode.snapshot.TestSnapshotListing   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.datanode.TestSimulatedFSDataset   hadoop.hdfs.server.namenode.ha.TestQuotasWithHA   hadoop.hdfs.server.namenode.ha.TestGetGroupsWithHA   hadoop.hdfs.server.namenode.TestSecondaryWebUi   hadoop.hdfs.server.namenode.TestMalformedURLs   hadoop.hdfs.server.namenode.TestAuditLogger   hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.server.namenode.TestAddBlockRetry   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.server.namenode.ha.TestHAMetrics   hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap   hadoop.hdfs.server.namenode.TestFsLimits   hadoop.hdfs.server.namenode.TestNNStorageRetentionFunctional   hadoop.hdfs.server.datanode.TestHSync   hadoop.hdfs.server.namenode.TestNameNodeRpcServer   hadoop.hdfs.server.namenode.TestFSImageWithXAttr   hadoop.hdfs.server.namenode.snapshot.TestXAttrWithSnapshot   hadoop.hdfs.server.namenode.TestFSImageWithAcl   hadoop.hdfs.server.namenode.ha.TestStandbyBlockManagement   hadoop.hdfs.server.namenode.TestListCorruptFileBlocks   hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.namenode.TestParallelImageWrite   hadoop.hdfs.server.namenode.snapshot.TestAclWithSnapshot   hadoop.hdfs.server.namenode.TestNameNodeResourceChecker   hadoop.hdfs.server.namenode.TestGenericJournalConf   hadoop.hdfs.server.namenode.TestEditLogJournalFailures   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDiffReport   hadoop.hdfs.server.namenode.TestFSNamesystemMBean   hadoop.hdfs.server.namenode.TestEditLogRace   hadoop.hdfs.server.namenode.TestAllowFormat   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots   hadoop.hdfs.server.namenode.TestProtectedDirectories   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.namenode.snapshot.TestSnapshotMetrics   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.TestINodeFile   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA   hadoop.hdfs.server.namenode.ha.TestNNHealthCheck   hadoop.hdfs.server.namenode.snapshot.TestSnapshotReplication   hadoop.hdfs.server.namenode.snapshot.TestSnapshotNameWithInvalidCharacters   hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM   hadoop.hdfs.server.namenode.TestBlockUnderConstruction   hadoop.hdfs.server.namenode.TestDeadDatanode   hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy   hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.server.datanode.TestIncrementalBlockReports   hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled   hadoop.hdfs.server.namenode.TestStorageRestore   hadoop.hdfs.server.namenode.TestFSNamesystem   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.namenode.ha.TestHAFsck   hadoop.hdfs.server.namenode.TestXAttrConfigFlag   hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot   hadoop.hdfs.server.namenode.snapshot.TestDisallowModifyROSnapshot   hadoop.hdfs.server.namenode.TestNameNodeRespectsBindHostKeys   hadoop.hdfs.server.datanode.TestDataNodeMXBean   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.namenode.TestFsckWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestSnapshotPathINodes   hadoop.hdfs.server.namenode.ha.TestStateTransitionFailure   hadoop.hdfs.server.namenode.ha.TestStandbyIsHot   hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots   hadoop.hdfs.server.datanode.TestDataNodeECN   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.namenode.TestNameEditsConfigs   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.namenode.TestTruncateQuotaUpdate   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.server.namenode.ha.TestPendingCorruptDnMessages   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.server.namenode.ha.TestHASafeMode   hadoop.hdfs.server.namenode.TestSecureNameNode   hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.server.namenode.TestNameNodeRecovery   hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.server.namenode.TestGetBlockLocations   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.namenode.ha.TestXAttrsWithHA   hadoop.hdfs.server.namenode.TestINodeAttributeProvider   hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename   hadoop.hdfs.server.namenode.TestProcessCorruptBlocks   hadoop.hdfs.server.namenode.TestMetadataVersionOutput   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.hdfs.server.namenode.TestMetaSave   hadoop.hdfs.server.namenode.TestCheckPointForSecurityTokens   hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA   hadoop.hdfs.server.datanode.TestIncrementalBrVariations   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestBackupNode   hadoop.hdfs.server.namenode.TestNameNodeAcl   hadoop.hdfs.server.namenode.TestFavoredNodesEndToEnd   hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   hadoop.hdfs.server.namenode.TestAddBlock   hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRackFaultTolerant   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.snapshot.TestSnapshottableDirListing   hadoop.hdfs.server.namenode.snapshot.TestSetQuotaWithSnapshot   hadoop.hdfs.server.namenode.TestNameNodeXAttr   hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold   hadoop.hdfs.server.namenode.snapshot.TestSnapshotStatsMXBean   hadoop.hdfs.server.namenode.ha.TestDNFencing   hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade Timed out tests org.apache.hadoop.hdfs.TestReplication   org.apache.hadoop.hdfs.TestPread   org.apache.hadoop.hdfs.qjournal.client.TestQJMWithFaults   org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756366/HDFS-5802.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 941001b whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12495/artifact/patchprocess/whitespace.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12495/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12495/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12495/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12495/console This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          HI Xiao Chen,

          Thanks for working on this. The patch looks generally good. I have some comments below, largely cosmetic.

          1. Right now you changed private void checkTraverse(INodeAttributes[] inodes, String path, int last) by adding a try/catch block, that catches the exception then check if any ancestor is not directory, and
          construct the path with InodeAttributes.toString(). This InodeAttributes.toString() counts on that InodeAttributes is Inode here, which is generally true but may not always be.

          I think a better approach is to move this try/catch block to one layer above to the caller checkPermission(...), do something like

             try {
                checkTraverse(inodeAttrs, path, ancestorIndex);
              } catch (AccessControlException e) {
                checkAncestorType(inodes, ancestorIndex, e);
              }
          

          where is an Inode array inodes available, so we can use Inode.getFullPathName()}} method. Basically move your code to a new method checkAncestorType(inodes, ancestorIndex, e); above.

          The loop starts with index 1 in your code, we can start with 0.

          In the loop, we check its type when inodes[j] is not null; when it's null, we should simply break and throw the original exception.

          2. The message can be formatted a bit more like

            throw new AccessControlException(e.getMessage() + " (Ancestor " +
                        inodes[j].getFullPathName() + " is not a directory).");
          

          3. Suggest to rename testPermissionMessageOnNonexistingFile() to testPermissionMessageOnNonDirAncestor()

          4. split @Override public FileSystem run() throws Exception into two lines so override is on its own line.

          5. Couple of lines in the testing code exceeded 80 chars.

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - HI Xiao Chen , Thanks for working on this. The patch looks generally good. I have some comments below, largely cosmetic. 1. Right now you changed private void checkTraverse(INodeAttributes[] inodes, String path, int last) by adding a try/catch block, that catches the exception then check if any ancestor is not directory, and construct the path with InodeAttributes.toString() . This InodeAttributes.toString() counts on that InodeAttributes is Inode here, which is generally true but may not always be. I think a better approach is to move this try/catch block to one layer above to the caller checkPermission(...) , do something like try { checkTraverse(inodeAttrs, path, ancestorIndex); } catch (AccessControlException e) { checkAncestorType(inodes, ancestorIndex, e); } where is an Inode array inodes available, so we can use Inode.getFullPathName()}} method. Basically move your code to a new method checkAncestorType(inodes, ancestorIndex, e); above. The loop starts with index 1 in your code, we can start with 0. In the loop, we check its type when inodes [j] is not null; when it's null, we should simply break and throw the original exception. 2. The message can be formatted a bit more like throw new AccessControlException(e.getMessage() + " (Ancestor " + inodes[j].getFullPathName() + " is not a directory)." ); 3. Suggest to rename testPermissionMessageOnNonexistingFile() to testPermissionMessageOnNonDirAncestor() 4. split @Override public FileSystem run() throws Exception into two lines so override is on its own line. 5. Couple of lines in the testing code exceeded 80 chars. Thanks.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Yongjun for the review! It makes sense, and I've addressed comment 1-4. (The code was 80 chars, so no action for 5)
          Submit incremental patch 002 with my changes.

          Show
          xiaochen Xiao Chen added a comment - Thanks Yongjun for the review! It makes sense, and I've addressed comment 1-4. (The code was 80 chars, so no action for 5) Submit incremental patch 002 with my changes.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Xiao Chen,

          Thanks for the new rev. Rev 2 looks good to me, two small nits

          195	  /**
          196	   * Check whether an exception is due to inode type not directory
          197	   */
          198	  private void checkAncestorType(INode[] inodes, int ancestorIndex,
          199	                    AccessControlException e) throws AccessControlException {
          

          1. Suggest to change the comment above to
          "Check whether exception e is due to an ancestor inode's not being directory"
          2. indention of line 199 should be 4

          +1 after that, pending jenkins tests.

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Xiao Chen , Thanks for the new rev. Rev 2 looks good to me, two small nits 195 /** 196 * Check whether an exception is due to inode type not directory 197 */ 198 private void checkAncestorType(INode[] inodes, int ancestorIndex, 199 AccessControlException e) throws AccessControlException { 1. Suggest to change the comment above to "Check whether exception e is due to an ancestor inode's not being directory" 2. indention of line 199 should be 4 +1 after that, pending jenkins tests. Thanks.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Yongjun for the additional comments!
          I have fixed it and uploaded patch 003.

          Show
          xiaochen Xiao Chen added a comment - Thanks Yongjun for the additional comments! I have fixed it and uploaded patch 003.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 19s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 3s There were no new javac warning messages.
          +1 javadoc 10m 14s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 21s The applied patch generated 3 new checkstyle issues (total was 36, now 39).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 16s Pre-build of native portion
          +1 hdfs tests 163m 49s Tests passed in hadoop-hdfs.
              209m 58s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12757115/HDFS-5802.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 58d1a02
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12512/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12512/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12512/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12512/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12512/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 19s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 3s There were no new javac warning messages. +1 javadoc 10m 14s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 21s The applied patch generated 3 new checkstyle issues (total was 36, now 39). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion +1 hdfs tests 163m 49s Tests passed in hadoop-hdfs.     209m 58s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757115/HDFS-5802.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 58d1a02 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12512/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12512/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12512/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12512/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12512/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Upload patch 004 to fix checkstyle warnings.
          The whitespace error is not from my changes, leave it for now.

          Show
          xiaochen Xiao Chen added a comment - Upload patch 004 to fix checkstyle warnings. The whitespace error is not from my changes, leave it for now.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 55s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 32s There were no new javac warning messages.
          +1 javadoc 10m 48s There were no new javadoc warning messages.
          +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 35s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 46s mvn install still works.
          +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
          +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 28s Pre-build of native portion
          +1 hdfs tests 167m 15s Tests passed in hadoop-hdfs.
              214m 3s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12757132/HDFS-5802.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3f82f58
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12515/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12515/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12515/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12515/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 55s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 32s There were no new javac warning messages. +1 javadoc 10m 48s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 35s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 46s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 28s Pre-build of native portion +1 hdfs tests 167m 15s Tests passed in hadoop-hdfs.     214m 3s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757132/HDFS-5802.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3f82f58 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12515/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12515/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12515/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12515/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Upload patch 005 to fix the whitespace error located right next to my change.

          Show
          xiaochen Xiao Chen added a comment - Upload patch 005 to fix the whitespace error located right next to my change.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 34s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 51s There were no new javac warning messages.
          +1 javadoc 9m 59s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 19s The applied patch generated 2 new checkstyle issues (total was 36, now 38).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 26s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 10s Pre-build of native portion
          -1 hdfs tests 161m 46s Tests failed in hadoop-hdfs.
              206m 36s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12757170/HDFS-5802.004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ee4ee6a
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12521/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12521/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12521/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12521/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12521/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 9m 59s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 19s The applied patch generated 2 new checkstyle issues (total was 36, now 38). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 10s Pre-build of native portion -1 hdfs tests 161m 46s Tests failed in hadoop-hdfs.     206m 36s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757170/HDFS-5802.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ee4ee6a checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12521/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12521/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12521/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12521/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12521/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Resubmitting patch 005 because Jenkins job was not triggered last time.

          Show
          xiaochen Xiao Chen added a comment - Resubmitting patch 005 because Jenkins job was not triggered last time.
          Hide
          xiaochen Xiao Chen added a comment -

          Still no Jenkins for 005. Renamed it to patch 006 and resubmitting.

          Show
          xiaochen Xiao Chen added a comment - Still no Jenkins for 005. Renamed it to patch 006 and resubmitting.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 7s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 3s There were no new javac warning messages.
          +1 javadoc 12m 43s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 23s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 17s Pre-build of native portion
          -1 hdfs tests 163m 42s Tests failed in hadoop-hdfs.
              212m 15s  



          Reason Tests
          Failed unit tests hadoop.hdfs.web.TestWebHDFS



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12757178/HDFS-5802.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6b97fa6
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12524/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12524/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12524/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 3s There were no new javac warning messages. +1 javadoc 12m 43s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 23s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 163m 42s Tests failed in hadoop-hdfs.     212m 15s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHDFS Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757178/HDFS-5802.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6b97fa6 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12524/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12524/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12524/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 32s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 44s There were no new javac warning messages.
          +1 javadoc 9m 58s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 19s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 7s Pre-build of native portion
          -1 hdfs tests 163m 50s Tests failed in hadoop-hdfs.
              208m 25s  



          Reason Tests
          Failed unit tests hadoop.hdfs.web.TestWebHDFSOAuth2



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12757202/HDFS-5802.006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 723c31d
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12533/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12533/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12533/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 19s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 7s Pre-build of native portion -1 hdfs tests 163m 50s Tests failed in hadoop-hdfs.     208m 25s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHDFSOAuth2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757202/HDFS-5802.006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 723c31d hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12533/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12533/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12533/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 15s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 6s There were no new javac warning messages.
          +1 javadoc 10m 20s There were no new javadoc warning messages.
          +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 22s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 21s Pre-build of native portion
          -1 hdfs tests 193m 17s Tests failed in hadoop-hdfs.
              239m 49s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.server.blockmanagement.TestNodeCount



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12757202/HDFS-5802.006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 723c31d
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12532/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12532/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12532/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 6s There were no new javac warning messages. +1 javadoc 10m 20s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 22s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 21s Pre-build of native portion -1 hdfs tests 193m 17s Tests failed in hadoop-hdfs.     239m 49s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.server.blockmanagement.TestNodeCount Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757202/HDFS-5802.006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 723c31d hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12532/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12532/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12532/console This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8478 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8478/)
          HDFS-5802. NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8478 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8478/ ) HDFS-5802 . NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          yzhangal Yongjun Zhang added a comment -

          Committed to trunk and branch-2.

          Thanks Xiao for the contribution!

          Show
          yzhangal Yongjun Zhang added a comment - Committed to trunk and branch-2. Thanks Xiao for the contribution!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #408 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/408/)
          HDFS-5802. NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #408 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/408/ ) HDFS-5802 . NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2355 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2355/)
          HDFS-5802. NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2355 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2355/ ) HDFS-5802 . NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #415 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/415/)
          HDFS-5802. NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #415 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/415/ ) HDFS-5802 . NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1149 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1149/)
          HDFS-5802. NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1149 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1149/ ) HDFS-5802 . NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #391 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/391/)
          HDFS-5802. NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #391 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/391/ ) HDFS-5802 . NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2330 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2330/)
          HDFS-5802. NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2330 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2330/ ) HDFS-5802 . NameNode does not check for inode type before traversing down a path. (Xiao Chen via Yongjun Zhang) (yzhang: rev 2ff6faf954eb0f1ab2b339d589edb30040087669) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          Hide
          zhz Zhe Zhang added a comment -

          Thanks Xiao Chen Harsh J Yongjun Zhang for the work. I think it's a valid improvement for 2.7 as well; just backported it to branch-2.7.

          Show
          zhz Zhe Zhang added a comment - Thanks Xiao Chen Harsh J Yongjun Zhang for the work. I think it's a valid improvement for 2.7 as well; just backported it to branch-2.7.

            People

            • Assignee:
              xiaochen Xiao Chen
              Reporter:
              qwertymaniac Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development