Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-5795

RemoteBlockReader2#checkSuccess() shoud print error status

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      RemoteBlockReader2#checkSuccess() doesn't print error status, which makes debug harder when the client can't read from DataNode.

        Activity

        Hide
        xiaochen Xiao Chen added a comment -

        Hi Brandon,

        Thank you for reporting this issue. I'll working on it soon.

        Show
        xiaochen Xiao Chen added a comment - Hi Brandon, Thank you for reporting this issue. I'll working on it soon.
        Hide
        xiaochen Xiao Chen added a comment -

        Include status in RemoteBlockReader2#checkSuccess()'s logs which is eventually in DataTransferProtoUtil#checkBlockOpStatus()

        Show
        xiaochen Xiao Chen added a comment - Include status in RemoteBlockReader2#checkSuccess()'s logs which is eventually in DataTransferProtoUtil#checkBlockOpStatus()
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 47s There were no new javac warning messages.
        +1 javadoc 9m 55s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 34s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 27s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 9s Pre-build of native portion
        +1 hdfs tests 0m 27s Tests passed in hadoop-hdfs-client.
            44m 18s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12757223/HDFS-5795.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 723c31d
        hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12538/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12538/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12538/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 34s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 9s Pre-build of native portion +1 hdfs tests 0m 27s Tests passed in hadoop-hdfs-client.     44m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757223/HDFS-5795.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 723c31d hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12538/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12538/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12538/console This message was automatically generated.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Brandon Li for reporting the issue and Xiao Chen for the patch.

        Hi Brandon, the patch looks good to me. Would you please comment if you have any? thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Brandon Li for reporting the issue and Xiao Chen for the patch. Hi Brandon, the patch looks good to me. Would you please comment if you have any? thanks.
        Hide
        yzhangal Yongjun Zhang added a comment -

        +1, will commit shortly.

        Show
        yzhangal Yongjun Zhang added a comment - +1, will commit shortly.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Brandon Li for reporting the issue and Xiao Chen for the contribution. I committed to trunk and branch-2.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Brandon Li for reporting the issue and Xiao Chen for the contribution. I committed to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8518 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8518/)
        HDFS-5795. RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8518 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8518/ ) HDFS-5795 . RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1179 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1179/)
        HDFS-5795. RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1179 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1179/ ) HDFS-5795 . RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #440 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/440/)
        HDFS-5795. RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #440 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/440/ ) HDFS-5795 . RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #446 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/446/)
        HDFS-5795. RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #446 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/446/ ) HDFS-5795 . RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2357 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2357/)
        HDFS-5795. RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2357 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2357/ ) HDFS-5795 . RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #417 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/417/)
        HDFS-5795. RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #417 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/417/ ) HDFS-5795 . RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2384 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2384/)
        HDFS-5795. RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2384 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2384/ ) HDFS-5795 . RemoteBlockReader2#checkSuccess() shoud print error status. (Xiao Chen via Yongjun Zhang) (yzhang: rev 83e65c5fe84819b6c6da015b269fb4e46a88d105) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/DataTransferProtoUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            xiaochen Xiao Chen
            Reporter:
            brandonli Brandon Li
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development