Details

    • Hadoop Flags:
      Reviewed

      Description

      During upgrade, a marker can be inserted into the editlog streams so that it is possible to roll back to the marker transaction.

      1. editsStored
        5 kB
        Tsz Wo Nicholas Sze
      2. h5645_20130103.patch
        35 kB
        Tsz Wo Nicholas Sze
      3. h5645_20130109.patch
        35 kB
        Tsz Wo Nicholas Sze

        Activity

        Tsz Wo Nicholas Sze created issue -
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h5645_20130103.patch: insert a upgrade marker to editlog.

        Show
        Tsz Wo Nicholas Sze added a comment - h5645_20130103.patch: insert a upgrade marker to editlog.
        Tsz Wo Nicholas Sze made changes -
        Field Original Value New Value
        Attachment editsStored [ 12621268 ]
        Attachment h5645_20130103.patch [ 12621269 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h5645_20130109.patch: updated with the branch.

        Since the patch also applies to trunk, let me try submitting it.

        Show
        Tsz Wo Nicholas Sze added a comment - h5645_20130109.patch: updated with the branch. Since the patch also applies to trunk, let me try submitting it.
        Tsz Wo Nicholas Sze made changes -
        Attachment h5645_20130109.patch [ 12622102 ]
        Tsz Wo Nicholas Sze made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12622102/h5645_20130109.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
        org.apache.hadoop.hdfs.TestPersistBlocks

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5849//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5849//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622102/h5645_20130109.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer org.apache.hadoop.hdfs.TestPersistBlocks +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5849//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5849//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        TestOfflineEditsViewer needs the binary edit log file.

        TestPersistBlocks is not related. Filed HDFS-5747.

        Show
        Tsz Wo Nicholas Sze added a comment - TestOfflineEditsViewer needs the binary edit log file. TestPersistBlocks is not related. Filed HDFS-5747 .
        Hide
        Jing Zhao added a comment -

        +1 Patch looks good to me. Only one question: in the patch the editlog loader currently just stops when it hits the upgrade marker. I guess we will have more sophisticated actions in later jiras?

        Show
        Jing Zhao added a comment - +1 Patch looks good to me. Only one question: in the patch the editlog loader currently just stops when it hits the upgrade marker. I guess we will have more sophisticated actions in later jiras?
        Jing Zhao made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        It is correct to just stop at the upgrade marker for supporting rollback. We should also add ignoring the upgrade marker for the standby NN and supporting downgrade.

        Thanks for reviewing the patch!

        Show
        Tsz Wo Nicholas Sze added a comment - It is correct to just stop at the upgrade marker for supporting rollback. We should also add ignoring the upgrade marker for the standby NN and supporting downgrade. Thanks for reviewing the patch!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this.
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s HDFS-5535 (Rolling upgrades) [ 12325754 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        30d 19h 52m 1 Tsz Wo Nicholas Sze 09/Jan/14 03:33
        Patch Available Patch Available Resolved Resolved
        1d 2h 34m 1 Tsz Wo Nicholas Sze 10/Jan/14 06:08

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development