[HDFS-5581] NameNodeFsck should use only one instance of BlockPlacementPolicy

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.0
• Component/s: namenode
• Assignee: Vinayakumar B
• Reporter: Vinayakumar B
• Created: 29/Nov/13 02:33
• Updated: 24/Feb/14 20:57
• Resolved: 02/Dec/13 16:36

Description

While going through NameNodeFsck I found that following code creates the new instance of BlockPlacementPolicy for every block.

      // verify block placement policy
      BlockPlacementStatus blockPlacementStatus = 
          BlockPlacementPolicy.getInstance(conf, null, networktopology).
              verifyBlockPlacement(path, lBlk, targetFileReplication);

It would be better to use the namenode's BPP itself instead of creating a new one.