Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-5581

NameNodeFsck should use only one instance of BlockPlacementPolicy

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:

      Description

      While going through NameNodeFsck I found that following code creates the new instance of BlockPlacementPolicy for every block.

            // verify block placement policy
            BlockPlacementStatus blockPlacementStatus = 
                BlockPlacementPolicy.getInstance(conf, null, networktopology).
                    verifyBlockPlacement(path, lBlk, targetFileReplication);

      It would be better to use the namenode's BPP itself instead of creating a new one.

      1. HDFS-5581.patch
        2 kB
        Vinayakumar B
      2. HDFS-5581.patch
        2 kB
        Vinayakumar B

        Activity

        Vinayakumar B created issue -
        Vinayakumar B made changes -
        Field Original Value New Value
        Attachment HDFS-5581.patch [ 12616332 ]
        Vinayakumar B made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Vinayakumar B made changes -
        Attachment HDFS-5581.patch [ 12616335 ]
        Colin Patrick McCabe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Target Version/s 2.2.1 [ 12325255 ]
        Fix Version/s 2.2.1 [ 12325255 ]
        Resolution Fixed [ 1 ]
        Colin Patrick McCabe made changes -
        Fix Version/s 2.3.0 [ 12324588 ]
        Fix Version/s 2.2.1 [ 12325255 ]
        Target Version/s 2.2.1 [ 12325255 ] 2.3.0 [ 12324588 ]
        Arun C Murthy made changes -
        Fix Version/s 2.3.0 [ 12325255 ]
        Fix Version/s 2.4.0 [ 12324588 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Vinayakumar B
            Reporter:
            Vinayakumar B
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development