Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.3.0
    • Component/s: caching
    • Labels:

      Description

      Using the shell, `hdfs dfsadmin -help refreshNamespace` returns help text, but for cacheadmin, you have to specify `hdfs cacheadmin -help -addDirective` with a dash before the command name. This is inconsistent with dfsadmin, dfs, and haadmin, which also error when you provide a dash.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1h 1 Andrew Wang 25/Nov/13 23:57
        Patch Available Patch Available Resolved Resolved
        21h 41m 1 Colin Patrick McCabe 26/Nov/13 21:39
        Resolved Resolved Closed Closed
        580d 9h 46m 1 Vinod Kumar Vavilapalli 30/Jun/15 08:25
        Vinod Kumar Vavilapalli made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Closing tickets that are already part of a release.

        Show
        Vinod Kumar Vavilapalli added a comment - Closing tickets that are already part of a release.
        Allen Wittenauer made changes -
        Fix Version/s 2.3.0 [ 12325255 ]
        Fix Version/s 3.0.0 [ 12320356 ]
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1621 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1621/)
        HDFS-5565. CacheAdmin help should match against non-dashed commands (wang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1545850)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1621 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1621/ ) HDFS-5565 . CacheAdmin help should match against non-dashed commands (wang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1545850 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1595 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1595/)
        HDFS-5565. CacheAdmin help should match against non-dashed commands (wang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1545850)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1595 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1595/ ) HDFS-5565 . CacheAdmin help should match against non-dashed commands (wang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1545850 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #404 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/404/)
        HDFS-5565. CacheAdmin help should match against non-dashed commands (wang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1545850)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #404 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/404/ ) HDFS-5565 . CacheAdmin help should match against non-dashed commands (wang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1545850 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4797 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4797/)
        HDFS-5565. CacheAdmin help should match against non-dashed commands (wang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1545850)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4797 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4797/ ) HDFS-5565 . CacheAdmin help should match against non-dashed commands (wang via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1545850 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
        Colin Patrick McCabe made changes -
        Fix Version/s 3.0.0 [ 12320356 ]
        Colin Patrick McCabe made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Colin Patrick McCabe added a comment -

        committed; thanks andrew.

        Show
        Colin Patrick McCabe added a comment - committed; thanks andrew.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12615732/hdfs-5565-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5578//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5578//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615732/hdfs-5565-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5578//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5578//console This message is automatically generated.
        Hide
        Colin Patrick McCabe added a comment -

        This is just a really simple command-line change. There's no way it could cause QJM / Balancer / other test failures. I suspect some Jenkins issue, but I'm not sure what. Maybe someone killed some threads somehow? I am re-running the tests.

        Show
        Colin Patrick McCabe added a comment - This is just a really simple command-line change. There's no way it could cause QJM / Balancer / other test failures. I suspect some Jenkins issue, but I'm not sure what. Maybe someone killed some threads somehow? I am re-running the tests.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12615732/hdfs-5565-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.qjournal.TestNNWithQJM
        org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
        org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5567//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5567//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615732/hdfs-5565-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.qjournal.TestNNWithQJM org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5567//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5567//console This message is automatically generated.
        Hide
        Colin Patrick McCabe added a comment -

        +1 pending jenkins

        Show
        Colin Patrick McCabe added a comment - +1 pending jenkins
        Andrew Wang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Labels newbie caching newbie
        Assignee Andrew Wang [ andrew.wang ]
        Andrew Wang made changes -
        Attachment hdfs-5565-1.patch [ 12615732 ]
        Hide
        Andrew Wang added a comment -

        Small patch attached, twiddled TestCacheAdminCLI's input to use the new-style.

        Show
        Andrew Wang added a comment - Small patch attached, twiddled TestCacheAdminCLI's input to use the new-style.
        Andrew Wang made changes -
        Field Original Value New Value
        Labels newbie
        Andrew Wang created issue -

          People

          • Assignee:
            Andrew Wang
            Reporter:
            Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development