Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.0.0
    • Fix Version/s: None
    • Component/s: datanode, namenode
    • Labels:
      None
    • Target Version/s:

      Description

      Some configuration options still have the "path.based" moniker, missed during the big rename removing this naming convention.

        Activity

        Hide
        Colin Patrick McCabe added a comment -

        I discussed this with Andrew, and we have no plans to rename these options at the moment. We can reopen this if someone thinks of a better thing to call them

        Show
        Colin Patrick McCabe added a comment - I discussed this with Andrew, and we have no plans to rename these options at the moment. We can reopen this if someone thinks of a better thing to call them
        Hide
        Colin Patrick McCabe added a comment -

        I'm not sure if we want to rename these. For example, if we rename dfs.namenode.path.based.cache.refresh.interval.ms to dfs.namenode.cache.refresh.interval.ms, it starts to sound awfully generic.

        The rename that removed "PathBased" from a bunch of class names was just a matter of necessity-- the names were getting too cumbersome, and we didn't think there would be conflicts. With the config keys, a long name is not such a big problem since we only use them once or twice throughout the code. And it does help to disambiguate them from all the other cache configurations we have (and there are many)

        Show
        Colin Patrick McCabe added a comment - I'm not sure if we want to rename these. For example, if we rename dfs.namenode.path.based.cache.refresh.interval.ms to dfs.namenode.cache.refresh.interval.ms , it starts to sound awfully generic. The rename that removed "PathBased" from a bunch of class names was just a matter of necessity-- the names were getting too cumbersome, and we didn't think there would be conflicts. With the config keys, a long name is not such a big problem since we only use them once or twice throughout the code. And it does help to disambiguate them from all the other cache configurations we have (and there are many)

          People

          • Assignee:
            Andrew Wang
            Reporter:
            Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development