Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-5518

HDFS doesn't compile/run against Guava 1.5

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 2.2.0
    • Fix Version/s: None
    • Component/s: journal-node, test
    • Labels:
      None

      Description

      HADOOP-10101 updates hadoop project to using the latest version of google guava, so reduce conflict with other projects (including bookkeeper).

      Two classes in HDFS don't compile, as google removed some classes

      1. NullableOutputStream gone: switch to using Hadoop's own NullableOutputStream
      2. Ranges class gone: switch to Range class
      1. HADOOP-10101.patch
        10 kB
        Vinayakumar B
      2. HADOOP-10101-002.patch
        2 kB
        Steve Loughran
      3. HADOOP-10101-004.patch
        11 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          Steve Loughran added a comment -

          The patch for this is part of the cross-project HADOOP-10101 patch, submitted here for review/ Jenkins testing, though it would actually be applied in the '10101 patch

          Show
          Steve Loughran added a comment - The patch for this is part of the cross-project HADOOP-10101 patch, submitted here for review/ Jenkins testing, though it would actually be applied in the '10101 patch
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12614049/HADOOP-10101-002.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The applied patch generated 1564 javac compiler warnings (more than the trunk's current 1545 warnings).

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5446//testReport/
          Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/5446//artifact/trunk/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5446//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614049/HADOOP-10101-002.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1564 javac compiler warnings (more than the trunk's current 1545 warnings). +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5446//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/5446//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5446//console This message is automatically generated.
          Hide
          Steve Loughran added a comment -

          cancelling patch pending an update to HADOOP-10101

          Show
          Steve Loughran added a comment - cancelling patch pending an update to HADOOP-10101
          Hide
          Alejandro Abdelnur added a comment -

          how this change will affect downstream projects and apps? in what version are we planning to make this change?

          Show
          Alejandro Abdelnur added a comment - how this change will affect downstream projects and apps? in what version are we planning to make this change?
          Hide
          Steve Loughran added a comment -

          Alejandro

          1. I'm looking at 2.3 having an update of the dependencies, and leaving 2.2.x entirely alone, though a JetS3t patch went into 2.2.1 (HADOOP-9623) that may or may not stay in there.
          2. It will allow projects using the latest versions of guava to work with Hadoop 2.3+ without having to shade their version as BOOKEEPER-708 was forcing BK to do, something which was actually stopping HDFS from upgrading to Bookeeper 4.2.1 ( HDFS-5411)
          3. It will force projects also using out of date guava versions to update or play games with maven shading
          Show
          Steve Loughran added a comment - Alejandro I'm looking at 2.3 having an update of the dependencies, and leaving 2.2.x entirely alone, though a JetS3t patch went into 2.2.1 ( HADOOP-9623 ) that may or may not stay in there. It will allow projects using the latest versions of guava to work with Hadoop 2.3+ without having to shade their version as BOOKEEPER-708 was forcing BK to do, something which was actually stopping HDFS from upgrading to Bookeeper 4.2.1 ( HDFS-5411 ) It will force projects also using out of date guava versions to update or play games with maven shading
          Hide
          Vinayakumar B added a comment -

          Updated the Deprecated methods usage with successors.
          Please review

          Show
          Vinayakumar B added a comment - Updated the Deprecated methods usage with successors. Please review
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12617563/HADOOP-10101.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5674//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5674//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617563/HADOOP-10101.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5674//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5674//console This message is automatically generated.
          Hide
          Steve Loughran added a comment -

          previous patch but current against trunk; CRs stripped

          Show
          Steve Loughran added a comment - previous patch but current against trunk; CRs stripped
          Hide
          Steve Loughran added a comment -

          Looking at this, it's a superset of HDFS-7040 .. that updates the NullInputStream but not the timer stuff.

          Show
          Steve Loughran added a comment - Looking at this, it's a superset of HDFS-7040 .. that updates the NullInputStream but not the timer stuff.
          Hide
          Akira AJISAKA added a comment -

          Fixed by HADOOP-11600. Now Hadoop source code can be compiled with Guava 17.

          Show
          Akira AJISAKA added a comment - Fixed by HADOOP-11600 . Now Hadoop source code can be compiled with Guava 17.

            People

            • Assignee:
              Vinayakumar B
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development