[HDFS-5513] CacheAdmin commands fail when using . as the path

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.3.0
• Component/s: caching, tools
• Assignee: Andrew Wang
• Reporter: Stephen Chu
• Created: 14/Nov/13 05:14
• Updated: 12/May/16 18:18
• Resolved: 20/Nov/13 00:30

Description

The hdfs CLI commands generally accept "." as a path argument.
e.g.

hdfs dfs -rm .
hdfs dfsadmin -allowSnapshot .

I don't think it's very common to use the path "." but the CacheAdmin commands will fail saying that it cannot create a Path from an empty string.

[schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -removeDirectives -path .
Exception in thread "main" java.lang.IllegalArgumentException: Can not create a Path from an empty string
	at org.apache.hadoop.fs.Path.checkPathArg(Path.java:127)
	at org.apache.hadoop.fs.Path.<init>(Path.java:184)
	at org.apache.hadoop.hdfs.protocol.PathBasedCacheDirective$Builder.<init>(PathBasedCacheDirective.java:66)
	at org.apache.hadoop.hdfs.DistributedFileSystem.listPathBasedCacheDirectives(DistributedFileSystem.java:1639)
	at org.apache.hadoop.hdfs.tools.CacheAdmin$RemovePathBasedCacheDirectivesCommand.run(CacheAdmin.java:365)
	at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:82)
	at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:87)
[schu@hdfs-c5-nfs ~]$ hdfs cacheadmin -addDirective -path . -pool schu
Exception in thread "main" java.lang.IllegalArgumentException: Can not create a Path from an empty string
	at org.apache.hadoop.fs.Path.checkPathArg(Path.java:127)
	at org.apache.hadoop.fs.Path.<init>(Path.java:184)
	at org.apache.hadoop.hdfs.protocol.PathBasedCacheDirective$Builder.<init>(PathBasedCacheDirective.java:66)
	at org.apache.hadoop.hdfs.DistributedFileSystem.addPathBasedCacheDirective(DistributedFileSystem.java:1598)
	at org.apache.hadoop.hdfs.tools.CacheAdmin$AddPathBasedCacheDirectiveCommand.run(CacheAdmin.java:180)
	at org.apache.hadoop.hdfs.tools.CacheAdmin.run(CacheAdmin.java:82)
	at org.apache.hadoop.hdfs.tools.CacheAdmin.main(CacheAdmin.java:87)