Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-5440 moves token-related logic to TokenAspect. This jira merges unit tests the token-related tests from hftp / hsftp / webhdfs into TestTokenAspect

      1. HDFS-5487.000.patch
        21 kB
        Haohui Mai
      2. HDFS-5487.001.patch
        21 kB
        Haohui Mai
      3. HDFS-5487.002.patch
        11 kB
        Haohui Mai

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          4d 20h 59m 1 Haohui Mai 13/Nov/13 22:14
          Patch Available Patch Available Resolved Resolved
          3h 3m 1 Jing Zhao 14/Nov/13 01:18
          Resolved Resolved Closed Closed
          102d 19h 39m 1 Arun C Murthy 24/Feb/14 20:58
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Arun C Murthy made changes -
          Fix Version/s 2.3.0 [ 12325255 ]
          Fix Version/s 2.4.0 [ 12324588 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1582/)
          HDFS-5487. Introduce unit test for TokenAspect. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541776)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestTokenAspect.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1582/ ) HDFS-5487 . Introduce unit test for TokenAspect. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541776 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestTokenAspect.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1608/)
          HDFS-5487. Introduce unit test for TokenAspect. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541776)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestTokenAspect.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1608/ ) HDFS-5487 . Introduce unit test for TokenAspect. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541776 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestTokenAspect.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #391 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/391/)
          HDFS-5487. Introduce unit test for TokenAspect. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541776)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestTokenAspect.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #391 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/391/ ) HDFS-5487 . Introduce unit test for TokenAspect. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541776 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestTokenAspect.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4733 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4733/)
          HDFS-5487. Introduce unit test for TokenAspect. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541776)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestTokenAspect.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4733 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4733/ ) HDFS-5487 . Introduce unit test for TokenAspect. Contributed by Haohui Mai. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541776 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestTokenAspect.java
          Jing Zhao made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 2.3.0 [ 12324588 ]
          Resolution Fixed [ 1 ]
          Hide
          Jing Zhao added a comment -

          I've committed this to trunk and branch-2.

          Show
          Jing Zhao added a comment - I've committed this to trunk and branch-2.
          Hide
          Jing Zhao added a comment -

          +1. The failed test is unrelated. I will commit the patch shortly.

          Show
          Jing Zhao added a comment - +1. The failed test is unrelated. I will commit the patch shortly.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12613717/HDFS-5487.002.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5426//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5426//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613717/HDFS-5487.002.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5426//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5426//console This message is automatically generated.
          Haohui Mai made changes -
          Summary Refactor TestHftpDelegationToken into TestTokenAspect Introduce unit test for TokenAspect
          Haohui Mai made changes -
          Description HDFS-5440 moves token-related logic to TokenAspect. Therefore, it is appropriate to clean up the unit tests of TestHftpDelegationToken and to move them into TestTokenAspect. HDFS-5440 moves token-related logic to TokenAspect. This jira merges unit tests the token-related tests from hftp / hsftp / webhdfs into TestTokenAspect
          Haohui Mai made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Haohui Mai made changes -
          Attachment HDFS-5487.002.patch [ 12613717 ]
          Hide
          Haohui Mai added a comment -

          Thanks Jing Zhao for the comments.

          Show
          Haohui Mai added a comment - Thanks Jing Zhao for the comments.
          Hide
          Jing Zhao added a comment -

          The new unit test looks good to me. But let's keep TestHftpDelegationToken here and only add the new unit test in this jira. Hsftp related unit tests can be removed/updated in HDFS-5502.

          Show
          Jing Zhao added a comment - The new unit test looks good to me. But let's keep TestHftpDelegationToken here and only add the new unit test in this jira. Hsftp related unit tests can be removed/updated in HDFS-5502 .
          Haohui Mai made changes -
          Link This issue is depended upon by HDFS-5502 [ HDFS-5502 ]
          Haohui Mai made changes -
          Attachment HDFS-5487.001.patch [ 12613303 ]
          Haohui Mai made changes -
          Attachment HDFS-5487.000.patch [ 12612943 ]
          Haohui Mai made changes -
          Field Original Value New Value
          Link This issue depends upon HDFS-5440 [ HDFS-5440 ]
          Haohui Mai created issue -

            People

            • Assignee:
              Haohui Mai
              Reporter:
              Haohui Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development