[HDFS-5474] Deletesnapshot can make Namenode in safemode on NN restarts.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.0
• Component/s: snapshots
• Target Version/s: 2.3.0
• Hadoop Flags: Reviewed
• Assignee: sathish
• Reporter: Uma Maheswara Rao G
• Created: 07/Nov/13 06:32
• Updated: 24/Feb/14 20:57
• Resolved: 13/Nov/13 20:55

Description

When we deletesnapshot, we are deleting the blocks associated to that snapshot and after that we do logsync to editlog about deleteSnapshot.
There can be a chance that blocks removed from blocks map but before log sync if there is BR , NN may finds that block does not exist in blocks map and may invalidate that block. As part HB, invalidation info also can go. After this steps if Namenode shutdown before actually do logsync, On restart it will still consider that snapshot Inodes and expect blocks to report from DN.

Simple solution is, we should simply move down that blocks removal after logsync only. Similar to delete op.

Issue Links

• relates to: HDFS-2815 Namenode is not coming out of safemode when we perform ( NN crash + restart ) . Also FSCK report shows blocks missed.