Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-5356

MiniDFSCluster shoud close all open FileSystems when shutdown()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2.0, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      After add some metrics functions to DFSClient, I found that some unit tests relates to metrics are failed. Because MiniDFSCluster are never close open FileSystems, DFSClients are alive after MiniDFSCluster shutdown(). The metrics of DFSClients in DefaultMetricsSystem are still exist and this make other unit tests failed.

      1. HDFS-5356.patch
        3 kB
        haosdent
      2. HDFS-5356-1.patch
        2 kB
        Rakesh R
      3. HDFS-5356-2.patch
        6 kB
        Rakesh R
      4. HDFS-5356-3.patch
        6 kB
        Rakesh R
      5. HDFS-5356-4.patch
        7 kB
        Rakesh R
      6. HDFS-5356-5.patch
        5 kB
        Rakesh R
      7. HDFS-5356-6.patch
        5 kB
        Rakesh R
      8. HDFS-5356-7.patch
        5 kB
        Rakesh R
      9. HDFS-5356-8.patch
        5 kB
        Rakesh R

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12608314/HDFS-5356.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
        org.apache.hadoop.hdfs.server.namenode.ha.TestHAAppend
        org.apache.hadoop.hdfs.server.namenode.TestINodeFile
        org.apache.hadoop.hdfs.server.namenode.TestNameNodeRecovery
        org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
        org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
        org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
        org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
        org.apache.hadoop.hdfs.TestDFSClientFailover
        org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool
        org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM
        org.apache.hadoop.hdfs.web.TestWebHDFSForHA
        org.apache.hadoop.hdfs.TestFileCreation
        org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
        org.apache.hadoop.hdfs.server.namenode.ha.TestDFSZKFailoverController

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5182//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5182//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608314/HDFS-5356.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA org.apache.hadoop.hdfs.server.namenode.ha.TestHAAppend org.apache.hadoop.hdfs.server.namenode.TestINodeFile org.apache.hadoop.hdfs.server.namenode.TestNameNodeRecovery org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits org.apache.hadoop.hdfs.TestDFSClientFailover org.apache.hadoop.hdfs.server.datanode.TestDeleteBlockPool org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM org.apache.hadoop.hdfs.web.TestWebHDFSForHA org.apache.hadoop.hdfs.TestFileCreation org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby org.apache.hadoop.hdfs.server.namenode.ha.TestDFSZKFailoverController +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5182//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5182//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12608917/HDFS-5356.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.TestFileCreation

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5225//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5225//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608917/HDFS-5356.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestFileCreation +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5225//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5225//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12609308/HDFS-5356.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5244//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5244//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12609308/HDFS-5356.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5244//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5244//console This message is automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        I don't think FileSystem#closeAll is what we want to call here. That will close all filesystems, regardless of whether they relate to the MiniDFSCluster. Remember that MiniDFSCluster is not a singleton. Multiple instances can exist.

        We might be able to do something smarter here that would close just the FileSystem objects that pertain to the MiniDFSCluster.

        However, have you considered just fixing the metrics tests to close the FileSystem objects they create? That seems like the simplest thing to do.

        Show
        cmccabe Colin P. McCabe added a comment - I don't think FileSystem#closeAll is what we want to call here. That will close all filesystems, regardless of whether they relate to the MiniDFSCluster . Remember that MiniDFSCluster is not a singleton. Multiple instances can exist. We might be able to do something smarter here that would close just the FileSystem objects that pertain to the MiniDFSCluster . However, have you considered just fixing the metrics tests to close the FileSystem objects they create? That seems like the simplest thing to do.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12698355/HDFS-5356-1.patch
        against trunk revision 76e309e.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.balancer.TestBalancer
        org.apache.hadoop.hdfs.TestFileCreation
        org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

        The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.fs.TestGlobPaths

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9558//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9558//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698355/HDFS-5356-1.patch against trunk revision 76e309e. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.balancer.TestBalancer org.apache.hadoop.hdfs.TestFileCreation org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.fs.TestGlobPaths Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9558//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9558//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12699087/HDFS-5356-2.patch
        against trunk revision ab0b958.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestHAAppend
        org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9589//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9589//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699087/HDFS-5356-2.patch against trunk revision ab0b958. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestHAAppend org.apache.hadoop.hdfs.server.namenode.TestParallelImageWrite Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9589//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9589//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        I could see these two test cases are passing locally. Reattaching the previous patch to get QA report again.

        Show
        rakeshr Rakesh R added a comment - I could see these two test cases are passing locally. Reattaching the previous patch to get QA report again.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12699203/HDFS-5356-3.patch
        against trunk revision 9729b24.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.TestFSImageWithAcl

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9596//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9596//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699203/HDFS-5356-3.patch against trunk revision 9729b24. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestFSImageWithAcl Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9596//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9596//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Colin P. McCabe I've replaced FileSystem#closeAll with another approach. Kindly look at the latest patch when you get some time. Thanks!

        I think, the test failures are unrelated.

        Tests in error: 
          TestFSImageWithAcl.setUp:52 java.lang.NoClassDefFoundError: org/apache/hadoop/io/IOUtils$NullOutputStream
          TestFSImageWithAcl.tearDown:58 NullPointerException
        
        Show
        rakeshr Rakesh R added a comment - Colin P. McCabe I've replaced FileSystem#closeAll with another approach. Kindly look at the latest patch when you get some time. Thanks! I think, the test failures are unrelated. Tests in error: TestFSImageWithAcl.setUp:52 java.lang.NoClassDefFoundError: org/apache/hadoop/io/IOUtils$NullOutputStream TestFSImageWithAcl.tearDown:58 NullPointerException
        Hide
        cmccabe Colin P. McCabe added a comment -

        Can we just change TestFileCreation.java and TestRenameWithSnapshots.java to call FileSystem#close manually? This seems simpler.

        Show
        cmccabe Colin P. McCabe added a comment - Can we just change TestFileCreation.java and TestRenameWithSnapshots.java to call FileSystem#close manually? This seems simpler.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Colin P. McCabe for the reply. Yes, that would be fine for these two test cases. But as the the defect says, should we have a generic way of closing all the filesystems during minidfs#shutdown?.

        Show
        rakeshr Rakesh R added a comment - Thanks Colin P. McCabe for the reply. Yes, that would be fine for these two test cases. But as the the defect says, should we have a generic way of closing all the filesystems during minidfs#shutdown?.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Hi Rakesh,

        That's a very fair question. I agree that it's nicer in theory to have MiniDFSCluster#shutdown call close on every FS.

        What happened in practice is that almost all the long-lived resources have moved out of FileSystem (and its delegate DFSClient) and into ClientContext. This happened because the FileContext API doesn't have a close function, and a lot of the code is shared.

        FileSystem#close has also created a lot of problems over the years because while we give out the same FS instance to multiple caller of FileSystem#get, we don't reference count it (meaning that one thread which calls close on it can shut it down even if there are other users). This shouldn't be a problem in unit tests, but it is one reason hadoop FS closing doesn't happen that often in real systems.

        All that being said, I would be OK with the change you have now if you checked whether the FS was in the fileSystems list prior to adding it. Currently it appears like we may call close twice on the same fs if MiniDFSCluster#getFileSystemInstance was called more than once.

        Show
        cmccabe Colin P. McCabe added a comment - Hi Rakesh, That's a very fair question. I agree that it's nicer in theory to have MiniDFSCluster#shutdown call close on every FS. What happened in practice is that almost all the long-lived resources have moved out of FileSystem (and its delegate DFSClient) and into ClientContext. This happened because the FileContext API doesn't have a close function, and a lot of the code is shared. FileSystem#close has also created a lot of problems over the years because while we give out the same FS instance to multiple caller of FileSystem#get, we don't reference count it (meaning that one thread which calls close on it can shut it down even if there are other users). This shouldn't be a problem in unit tests, but it is one reason hadoop FS closing doesn't happen that often in real systems. All that being said, I would be OK with the change you have now if you checked whether the FS was in the fileSystems list prior to adding it. Currently it appears like we may call close twice on the same fs if MiniDFSCluster#getFileSystemInstance was called more than once.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Colin P. McCabe for the explanation and helps to understand it more.

        I would be OK with the change you have now if you checked whether the FS was in the fileSystems list prior to adding it. Currently it appears like we may call close twice on the same fs if MiniDFSCluster#getFileSystemInstance was called more than once.

        Yeah, thats good point. I think making the datastructure to java.util.Set instead of java.util.List would be sufficient to avoid the duplicates. Could you please have a look at the new patch when you get some time.

        Show
        rakeshr Rakesh R added a comment - Thanks Colin P. McCabe for the explanation and helps to understand it more. I would be OK with the change you have now if you checked whether the FS was in the fileSystems list prior to adding it. Currently it appears like we may call close twice on the same fs if MiniDFSCluster#getFileSystemInstance was called more than once. Yeah, thats good point. I think making the datastructure to java.util.Set instead of java.util.List would be sufficient to avoid the duplicates. Could you please have a look at the new patch when you get some time.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Hi Rakesh R, thanks for the patch.
        Here are some comments.

        Here need to passdown deleteDfsDir

           public void shutdown(boolean deleteDfsDir) {
        +    shutdown(false, true);
        +  }

        I Don't think below change are necessary in TestFileCreation.java.

        +    DistributedFileSystem fs1 = null;

        in-fact you can remove the original re-assignment code after cluster restart. That should ideally work as the NameNode restarted with same ports and data. I have verified

        fs = cluster.getFileSystem();

        Changes in TestRenameWithSnapshots.java are not at all required as hdfs is re-initialized everytime cluster is restarted. Let it close the FS during shutdown.

        Show
        vinayrpet Vinayakumar B added a comment - Hi Rakesh R , thanks for the patch. Here are some comments. Here need to passdown deleteDfsDir public void shutdown( boolean deleteDfsDir) { + shutdown( false , true ); + } I Don't think below change are necessary in TestFileCreation.java. + DistributedFileSystem fs1 = null ; in-fact you can remove the original re-assignment code after cluster restart. That should ideally work as the NameNode restarted with same ports and data. I have verified fs = cluster.getFileSystem(); Changes in TestRenameWithSnapshots.java are not at all required as hdfs is re-initialized everytime cluster is restarted. Let it close the FS during shutdown.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks a lot Vinayakumar B for the comments.

        Changes in TestRenameWithSnapshots.java are not at all required as hdfs is re-initialized everytime cluster is restarted. Let it close the FS during shutdown.

        I could see TestRenameWithSnapshots#testAppendFileAfterRenameInSnapshot is failing in my environment and with my changes in TestRenameWithSnapshots.java this is passing. Could you run and see the result.

        Show
        rakeshr Rakesh R added a comment - Thanks a lot Vinayakumar B for the comments. Changes in TestRenameWithSnapshots.java are not at all required as hdfs is re-initialized everytime cluster is restarted. Let it close the FS during shutdown. I could see TestRenameWithSnapshots#testAppendFileAfterRenameInSnapshot is failing in my environment and with my changes in TestRenameWithSnapshots.java this is passing. Could you run and see the result.
        Hide
        vkb VKB added a comment -

        For me all tests in TestRenameWithSnapshots are passing even without the complete patch.

        Show
        vkb VKB added a comment - For me all tests in TestRenameWithSnapshots are passing even without the complete patch.
        Hide
        vinayrpet Vinayakumar B added a comment -

        For me all tests in TestRenameWithSnapshots are passing even without the complete patch.

        Above one was my other account.

        Show
        vinayrpet Vinayakumar B added a comment - For me all tests in TestRenameWithSnapshots are passing even without the complete patch. Above one was my other account.
        Hide
        rakeshr Rakesh R added a comment -

        It is failing when comparing SnapshotTestHelper.compareDumpedTreeInFile(fsnBefore, fsnMiddle, compareQuota);. fsnBefore and fsnMiddle differs in their storagespace values.

        fsnBefore:    
        Quota[namespace: 4/9223372036854775806, storagespace: 9216/9223372036854775806, StorageType: DISK-StorageType: SSD-StorageType: ARCHIVE-]
        fsnMiddle:
        Quota[namespace: 4/9223372036854775806, storagespace: 6147/9223372036854775806, StorageType: DISK-StorageType: SSD-StorageType: ARCHIVE-]
        
        Show
        rakeshr Rakesh R added a comment - It is failing when comparing SnapshotTestHelper.compareDumpedTreeInFile(fsnBefore, fsnMiddle, compareQuota); . fsnBefore and fsnMiddle differs in their storagespace values. fsnBefore: Quota[namespace: 4/9223372036854775806, storagespace: 9216/9223372036854775806, StorageType: DISK-StorageType: SSD-StorageType: ARCHIVE-] fsnMiddle: Quota[namespace: 4/9223372036854775806, storagespace: 6147/9223372036854775806, StorageType: DISK-StorageType: SSD-StorageType: ARCHIVE-]
        Hide
        vinayrpet Vinayakumar B added a comment -

        It is failing when comparing SnapshotTestHelper.compareDumpedTreeInFile(fsnBefore, fsnMiddle, compareQuota);. fsnBefore and fsnMiddle differs in their storagespace values.

        This seems unrelated to closure of filesystem.
        OK now I got. If you are closing the filesystem, then open files are being closed which results in diff in these image sizes.
        I didnt check that image file sizes were being checked in the test. I just told about the functionality.

        Show
        vinayrpet Vinayakumar B added a comment - It is failing when comparing SnapshotTestHelper.compareDumpedTreeInFile(fsnBefore, fsnMiddle, compareQuota);. fsnBefore and fsnMiddle differs in their storagespace values. This seems unrelated to closure of filesystem. OK now I got. If you are closing the filesystem, then open files are being closed which results in diff in these image sizes. I didnt check that image file sizes were being checked in the test. I just told about the functionality.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12703854/HDFS-5356-4.patch
        against trunk revision 30c428a.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9831//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9831//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703854/HDFS-5356-4.patch against trunk revision 30c428a. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9831//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9831//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        OK. Do you agree to go ahead with the changes in TestRenameWithSnapshots ?

        Show
        rakeshr Rakesh R added a comment - OK. Do you agree to go ahead with the changes in TestRenameWithSnapshots ?
        Hide
        vinayrpet Vinayakumar B added a comment -

        Yes sure.

        Show
        vinayrpet Vinayakumar B added a comment - Yes sure.
        Hide
        rakeshr Rakesh R added a comment -

        Attached new patch addressing Vinayakumar B's comments.

        Show
        rakeshr Rakesh R added a comment - Attached new patch addressing Vinayakumar B 's comments.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12703881/HDFS-5356-5.patch
        against trunk revision 30c428a.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.TestFileTruncate
        org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits

        The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9834//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9834//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12703881/HDFS-5356-5.patch against trunk revision 30c428a. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestFileTruncate org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9834//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9834//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Since the test case is passing in my env, am re-attaching the same patch to get the jenkins report.

        Show
        rakeshr Rakesh R added a comment - Since the test case is passing in my env, am re-attaching the same patch to get the jenkins report.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704108/HDFS-5356-6.patch
        against trunk revision ff83ae7.

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9849//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704108/HDFS-5356-6.patch against trunk revision ff83ae7. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9849//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704108/HDFS-5356-6.patch
        against trunk revision ff83ae7.

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9850//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704108/HDFS-5356-6.patch against trunk revision ff83ae7. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9850//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704235/HDFS-5356-7.patch
        against trunk revision b49c3a1.

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9860//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704235/HDFS-5356-7.patch against trunk revision b49c3a1. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9860//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704235/HDFS-5356-7.patch
        against trunk revision 6fdef76.

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9880//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704235/HDFS-5356-7.patch against trunk revision 6fdef76. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9880//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Re-attaching the same patch to get the jenkins report.

        Show
        rakeshr Rakesh R added a comment - Re-attaching the same patch to get the jenkins report.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704667/HDFS-5356-8.patch
        against trunk revision bc9cb3e.

        -1 patch. Trunk compilation may be broken.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9886//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704667/HDFS-5356-8.patch against trunk revision bc9cb3e. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9886//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12704667/HDFS-5356-8.patch
        against trunk revision 3ff1ba2.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

        The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9892//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9892//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12704667/HDFS-5356-8.patch against trunk revision 3ff1ba2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9892//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9892//console This message is automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Vinayakumar B for triggering the build. It looks like the testcase failure is unrelated to this patch. Please have a look at the latest patch, I addressed the review comments.

        Show
        rakeshr Rakesh R added a comment - Thanks Vinayakumar B for triggering the build. It looks like the testcase failure is unrelated to this patch. Please have a look at the latest patch, I addressed the review comments.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.
        Thanks for the contribution Rakesh R.
        Thanks Colin P. McCabe for reviews.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks for the contribution Rakesh R . Thanks Colin P. McCabe for reviews.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7346 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7346/)
        HDFS-5356. MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7346 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7346/ ) HDFS-5356 . MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Colin P. McCabe for the reviews. Thanks Vinayakumar B for reviewing and committing the patch.

        Show
        rakeshr Rakesh R added a comment - Thanks Colin P. McCabe for the reviews. Thanks Vinayakumar B for reviewing and committing the patch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #869 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/869/)
        HDFS-5356. MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #869 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/869/ ) HDFS-5356 . MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/135/)
        HDFS-5356. MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/135/ ) HDFS-5356 . MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/126/)
        HDFS-5356. MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #126 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/126/ ) HDFS-5356 . MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2067 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2067/)
        HDFS-5356. MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2067 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2067/ ) HDFS-5356 . MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/135/)
        HDFS-5356. MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/135/ ) HDFS-5356 . MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2085/)
        HDFS-5356. MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2085 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2085/ ) HDFS-5356 . MiniDFSCluster should close all open FileSystems when shutdown() (Contributed by Rakesh R) (vinayakumarb: rev 018893e81ec1c43e6c79c77adec92c2edfb20cab) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestRenameWithSnapshots.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            rakeshr Rakesh R
            Reporter:
            haosdent@gmail.com haosdent
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development