Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-5216

NumDecomDeadDataNodes not returning correct number of dead decommissioned nodes

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • 2.1.0-beta
    • None
    • None
    • None

    Description

      For HDFS-4860 I essentially copied the process in NamenodejspHelper.generateHealthReport(), so it would be in sync with the original dfsHealth.jsp.

      However looking at this now there may be a bug? in getNumDecomDeadDataNodes(), where:
      getBlockManager().getDatanodeManager().fetchDatanodes(dead, null, true);

      Where the parameter true indicates that decommissioned nodes should be removed from the list.

      If the flag is true fetchDatanodes calls removeDecomNodeFromList, which will remove a node if an existing datanode does not appear in both include or exclude lists and it has been decommissioned.

      If I am looking to return the Number of Dead Decommissioned Nodes, should I change the remove decommissioned nodes flag to False? i.e.:
      getBlockManager().getDatanodeManager().fetchDatanodes(null, dead, false);

      Attachments

        1. HDFS-5216.diff
          3 kB
          Trevor Lorimer
        2. HDFS-5216.diff
          3 kB
          Trevor Lorimer

        Issue Links

          Activity

            People

              trevlo78 Trevor Lorimer
              trevlo78 Trevor Lorimer
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: