[HDFS-5107] Fix array copy error in Readdir and Readdirplus responses

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.1.1-beta
• Component/s: nfs
• Assignee: Brandon Li
• Reporter: Brandon Li
• Created: 16/Aug/13 17:57
• Updated: 12/May/16 18:17
• Resolved: 18/Aug/13 21:35

Description

System.arraycopy(this.entries, 0, entries, 0, entries.length);
it should be
System.arraycopy(entries, 0, this.entries, 0, entries.length);

Findbugs gives EI2 warning if directly assign entries to this.entries:
EI2: May expose internal representation by incorporating reference to mutable object (EI_EXPOSE_REP2)

This caused NFS to fail to return directory content.