[HDFS-5093] TestGlobPaths should re-use the MiniDFSCluster to avoid failure on Windows

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.0, 3.0.0-alpha1
• Fix Version/s: 2.3.0
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Chuan Liu
• Reporter: Chuan Liu
• Created: 14/Aug/13 00:31
• Updated: 12/May/16 18:13
• Resolved: 15/Aug/13 17:05

Description

Some test cases in TestGlobPaths fail on Windows because they try to create a new MiniDFSCluster though there is already one created at setUp(). This leads to failure on Windows because the new cluster will try to clean the old name node file that was opened by the existing cluster – on Windows, the process or thread cannot delete the file opened in normal Java APIs by another process or thread.

An example failure run looks like the following.

testGlobWithSymlinksOnFS(org.apache.hadoop.fs.TestGlobPaths)  Time elapsed: 47 sec  <<< ERROR!
java.io.IOException: Could not fully delete E:\tr\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\name1
	at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:759)
	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:644)
	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:334)
	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:316)
	at org.apache.hadoop.fs.TestGlobPaths.testOnFileSystem(TestGlobPaths.java:805)
	at org.apache.hadoop.fs.TestGlobPaths.testGlobWithSymlinksOnFS(TestGlobPaths.java:889)
...

Issue Links

• is broken by: HADOOP-9817 FileSystem#globStatus and FileContext#globStatus need to work with symlinks
• is part of: HDFS-3602 Enhancements to HDFS for Windows Server and Windows Azure development and runtime environments
• is required by: HADOOP-9865 FileContext.globStatus() has a regression with respect to relative path