Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4926

namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.1-beta
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      At http://localhost:50070/dfsnodelist.jsp?whatNodes=LIVE, there is a list of Live datanodes in a table. In the Node column, there is a link to each node. If you hover your cursor over one of the links, it shows the IP address and port number of the datanode. However, actual link is the hostname instead of the IP.

      Suggest that the tooltip reflect the actual url that the web browser would go to if the link is selected.

      1. live_nodes.png
        40 kB
        Jing Zhao
      2. HDFS-4926.patch.1
        5 kB
        Vivek Ganesan
      3. HDFS-4926.patch
        4 kB
        Vivek Ganesan
      4. Decommissioning_Aug_01.png
        27 kB
        Jing Zhao
      5. decommission.png
        29 kB
        Jing Zhao
      6. DeadDN_Aug_01.png
        12 kB
        Jing Zhao
      7. dead_nodes.png
        14 kB
        Jing Zhao

        Activity

        Hide
        Vivek Ganesan added a comment -

        Changed tooltip to read hostName:port (the hostName and port in the href URL) of the node

        Show
        Vivek Ganesan added a comment - Changed tooltip to read hostName:port (the hostName and port in the href URL) of the node
        Hide
        Vivek Ganesan added a comment -

        Tooltip modification in links to nodes

        Show
        Vivek Ganesan added a comment - Tooltip modification in links to nodes
        Hide
        Vivek Ganesan added a comment -

        -1 overall.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 43 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.
        =====================================================================================================

        No tests included because the change was a minor change involving a display value in a web page. No similar previous tests were found.

        Created a distribution and verified in a pseudo cluster.

        Steps:

        1. Start DFS -> start-dfs.sh
        2. In browser, navigate to http://localhost:50070/dfsnodelist.jsp?whatNodes=LIVE
        3. Hover the mouse pointer over any node name and check if it displays hostname:port rather than ipAddress:port

        ======================================================================================================

        javadoc warnings are not related to the changes made. please find attached file specifying javadoc warnings

        Show
        Vivek Ganesan added a comment - -1 overall . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 43 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version ) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. ===================================================================================================== No tests included because the change was a minor change involving a display value in a web page. No similar previous tests were found. Created a distribution and verified in a pseudo cluster. Steps: 1. Start DFS -> start-dfs.sh 2. In browser, navigate to http://localhost:50070/dfsnodelist.jsp?whatNodes=LIVE 3. Hover the mouse pointer over any node name and check if it displays hostname:port rather than ipAddress:port ====================================================================================================== javadoc warnings are not related to the changes made. please find attached file specifying javadoc warnings
        Hide
        Vivek Ganesan added a comment -

        Patch Javadoc warnings

        Show
        Vivek Ganesan added a comment - Patch Javadoc warnings
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12592033/patchJavadocWarnings.txt
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4644//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12592033/patchJavadocWarnings.txt against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4644//console This message is automatically generated.
        Hide
        Vivek Ganesan added a comment -

        Request review for the patch (following http://wiki.apache.org/hadoop/CodeReviewChecklist)

        Show
        Vivek Ganesan added a comment - Request review for the patch (following http://wiki.apache.org/hadoop/CodeReviewChecklist )
        Hide
        Vivek Ganesan added a comment -

        autobuild system took the non-patch attachment.

        So, deleted that attachment and cancelling patch for resubmission.

        Show
        Vivek Ganesan added a comment - autobuild system took the non-patch attachment. So, deleted that attachment and cancelling patch for resubmission.
        Hide
        Vivek Ganesan added a comment -

        resubmitting patch. Previous patch check failed because of an extra attachment.

        Show
        Vivek Ganesan added a comment - resubmitting patch. Previous patch check failed because of an extra attachment.
        Hide
        Jing Zhao added a comment -

        Hi Vivek,

        In NamenodeJspHelper#generateNodeData, before calling generateNodeDataHeader, the comment says:

              /*
               * Say the datanode is dn1.hadoop.apache.org with ip 192.168.0.5 we use:
               * 1) d.getHostName():d.getPort() to display. Domain and port are stripped
               *    if they are common across the nodes. i.e. "dn1"
               * 2) d.getHost():d.Port() for "title". i.e. "192.168.0.5:50010"
               * 3) d.getHostName():d.getInfoPort() for url.
               *    i.e. "http://dn1.hadoop.apache.org:50075/..."
               * Note that "d.getHost():d.getPort()" is what DFS clients use to
               * interact with datanodes.
               */
        

        The original code shows the data transfer IP and port in the title, which should also be some useful information. Thus I think maybe we do not need to use "hostName:http port" to replace it.

        Show
        Jing Zhao added a comment - Hi Vivek, In NamenodeJspHelper#generateNodeData, before calling generateNodeDataHeader, the comment says: /* * Say the datanode is dn1.hadoop.apache.org with ip 192.168.0.5 we use: * 1) d.getHostName():d.getPort() to display. Domain and port are stripped * if they are common across the nodes. i.e. "dn1" * 2) d.getHost():d.Port() for "title" . i.e. "192.168.0.5:50010" * 3) d.getHostName():d.getInfoPort() for url. * i.e. "http: //dn1.hadoop.apache.org:50075/..." * Note that "d.getHost():d.getPort()" is what DFS clients use to * interact with datanodes. */ The original code shows the data transfer IP and port in the title, which should also be some useful information. Thus I think maybe we do not need to use "hostName:http port" to replace it.
        Hide
        Vivek Ganesan added a comment -

        Hi Jing,

        I agree that we were showing some extra useful information in the original code by displaying IP:dataTransferPort.

        Thus, we have two view points here.

        1. Tool tip should be consistent with the HTML link (viewpoint of issue reporter)
        2. It's okay to provide supplementary useful information in tool tip (your view point)

        At this point, I would like to (+1) the point (2) above, since we are not displaying the data transfer port/ip in any other place in the page.

        Another modification I can think of is as follows: [Let's call it view point number (3) in addition to (1) and (2) above]
        1. Add new column to show data transfer port
        2. Add new column to show http port
        3. Change the tooltip of link to show ip address only.

        The rationale behind this modifiation is, when a user sees a host name (link) in the table and wants to identify the node's rack (assuming, rack can be derived from ip address, which mostly is the case), our tool tip can be the first point of information by displaying the ip address corresponding to the host name. Also, for knowing which port the HDFS clients have to connect to, the user can refer to the extra column which we add in the table.

        Any additional comments are welcome.

        Show
        Vivek Ganesan added a comment - Hi Jing, I agree that we were showing some extra useful information in the original code by displaying IP:dataTransferPort. Thus, we have two view points here. 1. Tool tip should be consistent with the HTML link (viewpoint of issue reporter) 2. It's okay to provide supplementary useful information in tool tip (your view point) At this point, I would like to (+1) the point (2) above, since we are not displaying the data transfer port/ip in any other place in the page. Another modification I can think of is as follows: [Let's call it view point number (3) in addition to (1) and (2) above] 1. Add new column to show data transfer port 2. Add new column to show http port 3. Change the tooltip of link to show ip address only. The rationale behind this modifiation is, when a user sees a host name (link) in the table and wants to identify the node's rack (assuming, rack can be derived from ip address, which mostly is the case), our tool tip can be the first point of information by displaying the ip address corresponding to the host name. Also, for knowing which port the HDFS clients have to connect to, the user can refer to the extra column which we add in the table. Any additional comments are welcome.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12592031/hdfs-4926.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.web.TestWebHdfsTimeouts

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4645//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4645//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12592031/hdfs-4926.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.web.TestWebHdfsTimeouts +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4645//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4645//console This message is automatically generated.
        Hide
        Vivek Ganesan added a comment -
        Show
        Vivek Ganesan added a comment - Need review for the ideas put forth at https://issues.apache.org/jira/browse/HDFS-4926?focusedCommentId=13707219&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13707219 Cancelling the patch, which was submitted earlier.
        Hide
        Jing Zhao added a comment -

        Hi Vivek, thanks a lot for the reply and proposing new ideas for improvement.

        Another modification I can think of is as follows: [Let's call it view point number (3) in addition to (1) and (2) above]

        1. Add new column to show data transfer port

        2. Add new column to show http port

        3. Change the tooltip of link to show ip address only.

        I agree extra columns can make the information more clear. But instead of adding two columns here, can we only add one column for "d.getHost():d.Port()", i.e., the information originally shown in title, and clearly stating that this is the DN's transferring address? Then for title we can make it consistent with the real URL (hostName + http port). What do you think?

        Show
        Jing Zhao added a comment - Hi Vivek, thanks a lot for the reply and proposing new ideas for improvement. Another modification I can think of is as follows: [Let's call it view point number (3) in addition to (1) and (2) above] 1. Add new column to show data transfer port 2. Add new column to show http port 3. Change the tooltip of link to show ip address only. I agree extra columns can make the information more clear. But instead of adding two columns here, can we only add one column for "d.getHost():d.Port()", i.e., the information originally shown in title, and clearly stating that this is the DN's transferring address? Then for title we can make it consistent with the real URL (hostName + http port). What do you think?
        Hide
        Vivek Ganesan added a comment -

        Hi Jing,

        This idea looks great!

        ...instead of adding two columns here, can we only add one column for "d.getHost():d.port()", i.e., the information originally shown in title, and clearly stating that this is the DN's transferring address? Then for title we can make it consistent with the real URL (hostName + http port).

        I will add one new column with the following properties and shift the hyperlink to that new column:

        • Column Header: URL(Open for suggestions if anything. For now, using the string "URL")
        • The text in the cell (a hyperlink) will be in accordance with the following quote:

          /*

          • Say the datanode is dn1.hadoop.apache.org with ip 192.168.0.5 we use:
          • 1) d.getHostName():d.getPort() to display. Domain and port are stripped
          • if they are common across the nodes. i.e. "dn1"
          • 2) d.getHost():d.Port() for "title". i.e. "192.168.0.5:50010"
          • 3) d.getHostName():d.getInfoPort() for url.
          • i.e. "http://dn1.hadoop.apache.org:50075/..."
          • Note that "d.getHost():d.getPort()" is what DFS clients use to
          • interact with datanodes.
            */
        • Title (or tooltip) : Same as hyperlink content
        Show
        Vivek Ganesan added a comment - Hi Jing, This idea looks great! ...instead of adding two columns here, can we only add one column for "d.getHost():d.port()", i.e., the information originally shown in title, and clearly stating that this is the DN's transferring address? Then for title we can make it consistent with the real URL (hostName + http port). I will add one new column with the following properties and shift the hyperlink to that new column: Column Header: URL(Open for suggestions if anything. For now, using the string "URL") The text in the cell (a hyperlink) will be in accordance with the following quote: /* Say the datanode is dn1.hadoop.apache.org with ip 192.168.0.5 we use: 1) d.getHostName():d.getPort() to display. Domain and port are stripped if they are common across the nodes. i.e. "dn1" 2) d.getHost():d.Port() for "title". i.e. "192.168.0.5:50010" 3) d.getHostName():d.getInfoPort() for url. i.e. "http://dn1.hadoop.apache.org:50075/..." Note that "d.getHost():d.getPort()" is what DFS clients use to interact with datanodes. */ Title (or tooltip) : Same as hyperlink content
        Hide
        Vivek Ganesan added a comment -

        Fixing the following issues also in Name Node JSP page along with the issue at hand.

        1. Node list table has broken borders.
        2. Node list table has a column, whose column header reads "Block Pool Used (%) > Blocks ". Renaming this column header to "Block Pool Used (%)". This issue is most probably due to a previous merge conflict.

        Show
        Vivek Ganesan added a comment - Fixing the following issues also in Name Node JSP page along with the issue at hand. 1. Node list table has broken borders. 2. Node list table has a column, whose column header reads "Block Pool Used (%) > Blocks ". Renaming this column header to "Block Pool Used (%)". This issue is most probably due to a previous merge conflict.
        Hide
        Vivek Ganesan added a comment -

        Local Patch Check Results:
        -1 overall.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 42 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        ====================================
        No new tests were introduced because only cosmetic issues were fixed. No functionality changes.

        To test the fix, following steps were followed:

        1. Hadoop dist tar was created from the patch.
        2. Started DFS (start-dfs.sh)
        3. Opened http://localhost:50070 and navigated to live nodes list link to verify the fix

        Javadocs have not been modified. So, they are most probably false positives.

        Show
        Vivek Ganesan added a comment - Local Patch Check Results: -1 overall . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 42 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version ) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. ==================================== No new tests were introduced because only cosmetic issues were fixed. No functionality changes. To test the fix, following steps were followed: 1. Hadoop dist tar was created from the patch. 2. Started DFS (start-dfs.sh) 3. Opened http://localhost:50070 and navigated to live nodes list link to verify the fix Javadocs have not been modified. So, they are most probably false positives.
        Hide
        Vivek Ganesan added a comment -

        Request review for the patch

        Show
        Vivek Ganesan added a comment - Request review for the patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12594966/HDFS-4926.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4747//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4747//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12594966/HDFS-4926.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4747//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4747//console This message is automatically generated.
        Hide
        Jing Zhao added a comment -

        Hi Vivek,

        Thanks for updating the patch! Some thoughts and comments:

        1. Currently with your patch the WebUI looks like this:

        Node URL
        hostName (without href and title) hostName + InfoPort (href=title=url)

        In this case, we're missing the information contained in the original title (i.e., d.getHost():d.Port()). How about showing this:

        Node Transferring Address
        hostName (href=title=url) d.getHost():d.Port() (without href and title)

        2. We may need to update the javadoc to make it consistent with the new WebUI.

        Show
        Jing Zhao added a comment - Hi Vivek, Thanks for updating the patch! Some thoughts and comments: 1. Currently with your patch the WebUI looks like this: Node URL hostName (without href and title) hostName + InfoPort (href=title=url) In this case, we're missing the information contained in the original title (i.e., d.getHost():d.Port()). How about showing this: Node Transferring Address hostName (href=title=url) d.getHost():d.Port() (without href and title) 2. We may need to update the javadoc to make it consistent with the new WebUI.
        Hide
        Vivek Ganesan added a comment -

        LOCAL BUILD RESULTS
        ================================

        -1 overall.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 42 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        ==============================
        Changes made are only to fix cosmetic issues/display issues. No change in functionality. Hence, no new tests added.

        Javadocs warnings are false positives, as seen in previous patch

        Show
        Vivek Ganesan added a comment - LOCAL BUILD RESULTS ================================ -1 overall . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 42 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version ) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. ============================== Changes made are only to fix cosmetic issues/display issues. No change in functionality. Hence, no new tests added. Javadocs warnings are false positives, as seen in previous patch
        Hide
        Vivek Ganesan added a comment -

        Request review for the patch

        Show
        Vivek Ganesan added a comment - Request review for the patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12595179/HDFS-4926.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4752//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4752//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595179/HDFS-4926.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4752//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4752//console This message is automatically generated.
        Hide
        Jing Zhao added a comment -

        The current patch looks good to me. I built and ran locally and the new WebUI looks good. Only one nit:

        +          + ((alive) ? "" : "\n") + "<td class=\"address\">" + d.getIpAddr()
        +          + ":" + d.getXferPort());
        

        Let's use "d.getXferAddr()" instead of "d.getIpAddr() + ":" + d.getXferPort()" here.

        +1 with the change.

        Show
        Jing Zhao added a comment - The current patch looks good to me. I built and ran locally and the new WebUI looks good. Only one nit: + + ((alive) ? "" : " \n ") + " <td class=\ "address\" >" + d.getIpAddr() + + ":" + d.getXferPort()); Let's use "d.getXferAddr()" instead of "d.getIpAddr() + ":" + d.getXferPort()" here. +1 with the change.
        Hide
        Vivek Ganesan added a comment -

        Will resubmit the patch with suggested change

        Show
        Vivek Ganesan added a comment - Will resubmit the patch with suggested change
        Hide
        Vivek Ganesan added a comment -

        LOCAL PATCH VALIDATION RESULTS
        =========================================

        -1 overall.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 42 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        ======================================
        1. No tests were added because no functionality was changed. Only cosmetic/display issues were corrected.

        2. Javadoc error is a false positive, similar to previous patches.

        Show
        Vivek Ganesan added a comment - LOCAL PATCH VALIDATION RESULTS ========================================= -1 overall . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 42 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version ) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. ====================================== 1. No tests were added because no functionality was changed. Only cosmetic/display issues were corrected. 2. Javadoc error is a false positive, similar to previous patches.
        Hide
        Vivek Ganesan added a comment -

        Made the suggested changes. Request review for the patch

        Show
        Vivek Ganesan added a comment - Made the suggested changes. Request review for the patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12595424/HDFS-4926.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4753//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4753//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595424/HDFS-4926.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4753//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4753//console This message is automatically generated.
        Hide
        Jing Zhao added a comment -

        Thanks for addressing the comments Vivek. I tried the latest patch, now the live nodes looks pretty good. Then for showing decommissioning/dead dns, I guess you forgot to add the "Transferring Address" to the first row (see attached screenshots). So could you also verify the decommissioning dn list and dead dn list? It will be great if you can upload screenshots for all the 3 dn lists.

        By the way, you do not need to delete the old patch every time when you upload a new one. Naming the patch with index will be good.

        Show
        Jing Zhao added a comment - Thanks for addressing the comments Vivek. I tried the latest patch, now the live nodes looks pretty good. Then for showing decommissioning/dead dns, I guess you forgot to add the "Transferring Address" to the first row (see attached screenshots). So could you also verify the decommissioning dn list and dead dn list? It will be great if you can upload screenshots for all the 3 dn lists. By the way, you do not need to delete the old patch every time when you upload a new one. Naming the patch with index will be good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12595458/DeadDN_Aug_01.png
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4755//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595458/DeadDN_Aug_01.png against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4755//console This message is automatically generated.
        Hide
        Vivek Ganesan added a comment -

        LOCAL PATCH TEST RESULTS

        -1 overall.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 42 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version ) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        =====================================

        Hi Jing,

        I have made code changes. I currently have only one node. I am not able to test dead nodes and decommissioned nodes.

        Is there any way I can simulate and test those scenarios with a single node?

        Any pointers would be very helpful.

        Thank you.

        Show
        Vivek Ganesan added a comment - LOCAL PATCH TEST RESULTS -1 overall . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 42 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version ) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. ===================================== Hi Jing, I have made code changes. I currently have only one node. I am not able to test dead nodes and decommissioned nodes. Is there any way I can simulate and test those scenarios with a single node? Any pointers would be very helpful. Thank you.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12595608/HDFS-4926.patch.1
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4757//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4757//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12595608/HDFS-4926.patch.1 against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4757//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4757//console This message is automatically generated.
        Hide
        Vivek Ganesan added a comment -

        No new tests were introduced because only cosmetic issues were fixed. No functionality changes.

        To test the fix, following steps were followed:

        1. Hadoop dist tar was created from the patch.
        2. Started DFS (start-dfs.sh)
        3. Opened http://localhost:50070 and navigated to live nodes list link to verify the fix in a single-node environment

        Show
        Vivek Ganesan added a comment - No new tests were introduced because only cosmetic issues were fixed. No functionality changes. To test the fix, following steps were followed: 1. Hadoop dist tar was created from the patch. 2. Started DFS (start-dfs.sh) 3. Opened http://localhost:50070 and navigated to live nodes list link to verify the fix in a single-node environment
        Hide
        Jing Zhao added a comment -

        Thanks Vivek! I run a single-node cluster in my laptop with your patch and all three node lists looks good. +1 for the patch.

        Show
        Jing Zhao added a comment - Thanks Vivek! I run a single-node cluster in my laptop with your patch and all three node lists looks good. +1 for the patch.
        Hide
        Jing Zhao added a comment -

        I've committed this to trunk, branch-2, and branch-2.1-beta.

        Show
        Jing Zhao added a comment - I've committed this to trunk, branch-2, and branch-2.1-beta.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4224 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4224/)
        HDFS-4926. namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link. Contributed by Vivek Ganesan. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511477)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4224 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4224/ ) HDFS-4926 . namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link. Contributed by Vivek Ganesan. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511477 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #295 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/295/)
        HDFS-4926. namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link. Contributed by Vivek Ganesan. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511477)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #295 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/295/ ) HDFS-4926 . namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link. Contributed by Vivek Ganesan. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511477 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1485 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1485/)
        HDFS-4926. namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link. Contributed by Vivek Ganesan. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511477)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1485 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1485/ ) HDFS-4926 . namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link. Contributed by Vivek Ganesan. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511477 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1512 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1512/)
        HDFS-4926. namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link. Contributed by Vivek Ganesan. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511477)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1512 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1512/ ) HDFS-4926 . namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link. Contributed by Vivek Ganesan. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1511477 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css

          People

          • Assignee:
            Vivek Ganesan
            Reporter:
            Joseph Lorenzini
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development