[HDFS-4824] FileInputStreamCache.close leaves dangling reference to FileInputStreamCache.cacheCleaner

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.4-alpha
• Fix Version/s: 2.1.0-beta
• Component/s: hdfs-client
• Target Version/s: 2.1.0-beta
• Hadoop Flags: Reviewed
• Assignee: Colin McCabe
• Reporter: Henry Robinson
• Created: 14/May/13 22:23
• Updated: 03/Sep/14 22:46
• Resolved: 17/May/13 03:39

Description

FileInputStreamCache leaves around a reference to its cacheCleaner after close().

The cacheCleaner is created like this:

if (cacheCleaner == null) {
          cacheCleaner = new CacheCleaner();
          executor.scheduleAtFixedRate(cacheCleaner, expiryTimeMs, expiryTimeMs,
              TimeUnit.MILLISECONDS);
        }

and supposedly removed like this:

if (cacheCleaner != null) {
  executor.remove(cacheCleaner);
}

However, ScheduledThreadPoolExecutor.remove returns a success boolean which should be checked. And I think from a quick read of that class that the return value of scheduleAtFixedRate should be used as the argument to remove.