[HDFS-4707] Fix FilterFileSystem and findbugs warning in Snapshot branch

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Snapshot (HDFS-2802)
• Component/s: datanode, namenode
• Hadoop Flags: Reviewed
• Assignee: Tsz-wo Sze
• Reporter: Tsz-wo Sze
• Created: 17/Apr/13 22:49
• Updated: 18/Apr/13 13:09
• Resolved: 18/Apr/13 01:28

Description

The snapshot methods are not added to FilterFileSystem.

Findbugs warnings:

• SIC Should snapshot.Snapshot$Root be a static inner class?
• WMI Method FSImageFormat$Saver.saveImage(ByteBuffer, INodeDirectory, DataOutputStream, Snapshot, boolean) makes inefficient use of keySet iterator instead of entrySet iterator
• BC Unchecked/unconfirmed cast from FSImageSerialization.writeINodeFile(INodeFile, DataOutput, boolean)
• BC Unchecked/unconfirmed cast from snapshot.SnapshotFSImageFormat.loadDirectoryDiffList(INodeDirectory, DataInput, FSImageFormat$Loader)