[HDFS-4544] Error in deleting blocks should not do check disk, for all types of errors

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.1, 2.0.3-alpha
• Fix Version/s: 1.2.0, 0.23.7, 2.1.0-beta
• Hadoop Flags: Reviewed
• Assignee: Arpit Agarwal
• Reporter: Amareshwari Sriramadasu
• Created: 04/Mar/13 04:21
• Updated: 15/May/13 05:16
• Resolved: 06/Mar/13 17:35

Description

The following code in Datanode.java

      try {
        if (blockScanner != null) {
          blockScanner.deleteBlocks(toDelete);
        }
        data.invalidate(toDelete);
      } catch(IOException e) {
        checkDiskError();
        throw e;
      }

causes check disk to happen in case of any errors during invalidate.

We have seen errors like :

2013-03-02 00:08:28,849 WARN org.apache.hadoop.hdfs.server.datanode.DataNode: Unexpected error trying to delete block blk_-2973118207682441648_225738165. BlockInfo not found in volumeMap.

And all such errors trigger check disk, making the clients timeout.

Issue Links

• relates to: HDFS-4581 DataNode#checkDiskError should not be called on network errors