[HDFS-4433] make TestPeerCache not flaky

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: datanode, hdfs-client, performance
• Hadoop Flags: Reviewed
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 23/Jan/13 19:53
• Updated: 23/Jan/13 20:01
• Resolved: 23/Jan/13 20:01

Description

TestPeerCache is flaky now because it relies on using the same global cache for every test function. So the cache timeout can't be set to something different for each test.

Also, we should implement equals and hashCode for FakePeer, since otherwise testMultiplePeersWithSameDnId is not really testing what happens when multiple equal peers are inserted into the cache. (The default equals is object equality).