[HDFS-4417] HDFS-347: fix case where local reads get disabled incorrectly

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: datanode, hdfs-client, performance
• Assignee: Colin McCabe
• Reporter: Todd Lipcon
• Created: 17/Jan/13 05:46
• Updated: 24/Jan/13 20:24
• Resolved: 24/Jan/13 20:24

Description

In testing HDFS-347 against HBase (thanks jdcryans) we ran into the following case:

• a workload is running which puts a bunch of local sockets in the PeerCache
• the workload abates for a while, causing the sockets to go "stale" (ie the DN side disconnects after the keepalive timeout)
• the workload starts again

In this case, the local socket retrieved from the cache failed the newBlockReader call, and it incorrectly disabled local sockets on that host. This is similar to an earlier bug HDFS-3376, but not quite the same.

The next issue we ran into is that, once this happened, it never tried local sockets again, because the cache held lots of TCP sockets. Since we always managed to get a cached socket to the local node, it didn't bother trying local read again.