[HDFS-4402] some small DomainSocket fixes: avoid findbugs warning, change log level, etc.

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Hadoop Flags: Reviewed
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 15/Jan/13 00:10
• Updated: 15/Jan/13 00:31
• Resolved: 15/Jan/13 00:31

Description

Some miscellaneous fixes:

• findbugs complains about a short-circuit operator in DomainSocket.java for some reason. We don't need it (it doesn't help optimization since the expressions lack side-effects), so let's ditch it to avoid the findbugs warning.
• change the log level of one error message to warn
• BlockReaderLocal should use a BufferedInputStream to read the metadata file header, to avoid doing multiple small reads.