Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.1, 0.21.0
    • Component/s: None
    • Labels:
      None

      Description

      There are a few issues with quotas help messages.

      Space Quotas :

      1. It is not clear to the users that space quota counts replication as well. i.e. with a replication of 3, user needs 3GB of quota to be able to write 1GB file. should makes this explicit in the message
      2. There is a cut-n-paste error in the help message.

      All quota commands :

      • user needs to type 'dfsadmin -help -setQuota' (note '-'before setQuota), where as for the rest of the dfsadmin (and fs) commands '-' is not required. Should make this consistent.

      Since this is documentation only fix, I would like to commit it to 0.20.1 also.

      1. HDFS-438.patch
        3 kB
        Raghu Angadi
      2. HDFS-438.patch
        5 kB
        Raghu Angadi
      3. HADOOP-6012-branch-20.patch
        3 kB
        Raghu Angadi
      4. HADOOP-6012.patch
        3 kB
        Raghu Angadi
      5. HADOOP-6012.patch
        5 kB
        Raghu Angadi

        Activity

        Hide
        Raghu Angadi added a comment -

        Attached patch fixed above issues.

        Help message:

        • Before :
           $ bin/hdfs dfsadmin -help -setSpaceQuota
          -setSpaceQuota <quota> <dirname>...<dirname>: Set the disk space quota <quota> for each directory <dirName>.
                          The directory quota is a long integer that puts a hard limit
                          on the number of names in the directory tree.
                          Quota can also be speciefied with a binary prefix for terabytes,
                          petabytes etc (e.g. 50t is 50TB, 5m is 5MB, 3p is 3PB).
                          [...]  
        • After :
           $ bin/hdfs dfsadmin -help setSpaceQuota
          -setSpaceQuota <quota> <dirname>...<dirname>: Set the disk space quota <quota> for each directory <dirName>.
                          The space quota is a long integer that puts a hard limit
                          on the total size of all the files under the directory tree.
                          The extra space required for replication is also counted. E.g.
                          a 1GB file with replication of 3 consumes 3GB of the quota.
          
                          Quota can also be speciefied with a binary prefix for terabytes,
                          petabytes etc (e.g. 50t is 50TB, 5m is 5MB, 3p is 3PB).
                          [...] 
        Show
        Raghu Angadi added a comment - Attached patch fixed above issues. Help message: Before : $ bin/hdfs dfsadmin -help -setSpaceQuota -setSpaceQuota <quota> <dirname>...<dirname>: Set the disk space quota <quota> for each directory <dirName>. The directory quota is a long integer that puts a hard limit on the number of names in the directory tree. Quota can also be speciefied with a binary prefix for terabytes, petabytes etc (e.g. 50t is 50TB, 5m is 5MB, 3p is 3PB). [...] After : $ bin/hdfs dfsadmin -help setSpaceQuota -setSpaceQuota <quota> <dirname>...<dirname>: Set the disk space quota <quota> for each directory <dirName>. The space quota is a long integer that puts a hard limit on the total size of all the files under the directory tree. The extra space required for replication is also counted. E.g. a 1GB file with replication of 3 consumes 3GB of the quota. Quota can also be speciefied with a binary prefix for terabytes, petabytes etc (e.g. 50t is 50TB, 5m is 5MB, 3p is 3PB). [...]
        Hide
        Raghu Angadi added a comment -

        This conflicts with HADOOP-5862. will wait for it to be committed before updating the patch for trunk and 0.20.

        Show
        Raghu Angadi added a comment - This conflicts with HADOOP-5862 . will wait for it to be committed before updating the patch for trunk and 0.20.
        Hide
        Raghu Angadi added a comment -

        Patch for new hdfs trunk.

        Show
        Raghu Angadi added a comment - Patch for new hdfs trunk.
        Hide
        Boris Shkolnik added a comment -

        +1
        looks good

        Show
        Boris Shkolnik added a comment - +1 looks good
        Hide
        Raghu Angadi added a comment -

        Thanks Boris.

        Updated patch fixes TestHDFSCLI. This test verifies part of the help message.

        Show
        Raghu Angadi added a comment - Thanks Boris. Updated patch fixes TestHDFSCLI. This test verifies part of the help message.
        Hide
        Raghu Angadi added a comment -

        Patch for 0.20/core-trunk.

        Show
        Raghu Angadi added a comment - Patch for 0.20/core-trunk.
        Hide
        Raghu Angadi added a comment -

        test-patch (0.20 patch):

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 4 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warning

        Show
        Raghu Angadi added a comment - test-patch (0.20 patch): [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warning
        Hide
        Raghu Angadi added a comment -

        Patch for 0.20 is attached. The patch for old trunk does not apply to 0.20.

        Show
        Raghu Angadi added a comment - Patch for 0.20 is attached. The patch for old trunk does not apply to 0.20.
        Hide
        Raghu Angadi added a comment -

        I just committed this.

        Show
        Raghu Angadi added a comment - I just committed this.

          People

          • Assignee:
            Raghu Angadi
            Reporter:
            Raghu Angadi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development