Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HdfsConstants.java or DFSClient/LeaseManager.java could use a comment indicating the behavior of hard and soft file lease limit periods.

      1. HDFS-4383.3.patch
        18 kB
        Neethu PL
      2. HDFS-4383.patch
        2 kB
        Chu Tong
      3. HDFS-4383.patch
        1 kB
        Chu Tong
      4. HDFS-4383.patch
        1 kB
        Chu Tong
      5. HDFS-4383-5.patch
        2 kB
        Mohammad Arshad
      6. HDFS-4383-6.patch
        2 kB
        Mohammad Arshad

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2150/)
        HDFS-4383. Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2150/ ) HDFS-4383 . Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/192/)
        HDFS-4383. Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/192/ ) HDFS-4383 . Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/202/)
        HDFS-4383. Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/202/ ) HDFS-4383 . Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2132 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2132/)
        HDFS-4383. Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2132 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2132/ ) HDFS-4383 . Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/203/)
        HDFS-4383. Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #203 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/203/ ) HDFS-4383 . Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #934 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/934/)
        HDFS-4383. Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #934 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/934/ ) HDFS-4383 . Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7879 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7879/)
        HDFS-4383. Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7879 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7879/ ) HDFS-4383 . Document the lease limits. Contributed by Arshad Mohammad. (aajisaka: rev dc8434ab2b177ca9673bd8eecf7b185d4c4ffb31) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk and branch-2. Thanks Mohammad Arshad for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Mohammad Arshad for the contribution.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Looks good to me, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - Looks good to me, +1.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 1s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 46s There were no new javac warning messages.
        +1 javadoc 9m 59s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 13s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 20s Pre-build of native portion
        -1 hdfs tests 165m 8s Tests failed in hadoop-hdfs.
            209m 14s  



        Reason Tests
        Failed unit tests hadoop.tools.TestHdfsConfigFields
          hadoop.tracing.TestTraceAdmin
          hadoop.hdfs.server.mover.TestMover



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731917/HDFS-4383-6.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f24452d
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10939/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10939/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10939/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 1s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 9m 59s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 13s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 20s Pre-build of native portion -1 hdfs tests 165m 8s Tests failed in hadoop-hdfs.     209m 14s   Reason Tests Failed unit tests hadoop.tools.TestHdfsConfigFields   hadoop.tracing.TestTraceAdmin   hadoop.hdfs.server.mover.TestMover Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731917/HDFS-4383-6.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f24452d hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10939/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10939/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10939/console This message was automatically generated.
        Hide
        arshad.mohammad Mohammad Arshad added a comment -

        This issue is very old and it is now ready for commit

        Show
        arshad.mohammad Mohammad Arshad added a comment - This issue is very old and it is now ready for commit
        Hide
        arshad.mohammad Mohammad Arshad added a comment -

        -1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

        Only java doc is added, no functionality got added/modified. So no test cases

        -1 | hdfs tests | 164m 53s | Tests failed in hadoop-hdfs..

        Test case failure are surely not because of this patch. This patch is only added java doc, there is not funtionality changes

        Show
        arshad.mohammad Mohammad Arshad added a comment - -1 | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. Only java doc is added, no functionality got added/modified. So no test cases -1 | hdfs tests | 164m 53s | Tests failed in hadoop-hdfs.. Test case failure are surely not because of this patch. This patch is only added java doc, there is not funtionality changes
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 45s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 16s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 1s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 164m 53s Tests failed in hadoop-hdfs.
            207m 50s  



        Reason Tests
        Failed unit tests hadoop.tracing.TestTraceAdmin
          hadoop.hdfs.tools.TestHdfsConfigFields



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731917/HDFS-4383-6.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7e543c2
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10913/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10913/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10913/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 45s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 16s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 1s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 164m 53s Tests failed in hadoop-hdfs.     207m 50s   Reason Tests Failed unit tests hadoop.tracing.TestTraceAdmin   hadoop.hdfs.tools.TestHdfsConfigFields Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731917/HDFS-4383-6.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7e543c2 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10913/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10913/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10913/console This message was automatically generated.
        Hide
        arshad.mohammad Mohammad Arshad added a comment -

        removed blank lines

        Show
        arshad.mohammad Mohammad Arshad added a comment - removed blank lines
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 36s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 14s The applied patch generated 1 new checkstyle issues (total was 23, now 24).
        -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 5s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 165m 35s Tests failed in hadoop-hdfs.
            208m 22s  



        Reason Tests
        Failed unit tests hadoop.hdfs.tools.TestHdfsConfigFields
          hadoop.tracing.TestTraceAdmin



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731818/HDFS-4383-5.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4536399
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10904/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10904/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10904/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10904/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10904/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 14s The applied patch generated 1 new checkstyle issues (total was 23, now 24). -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 5s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 165m 35s Tests failed in hadoop-hdfs.     208m 22s   Reason Tests Failed unit tests hadoop.hdfs.tools.TestHdfsConfigFields   hadoop.tracing.TestTraceAdmin Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731818/HDFS-4383-5.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4536399 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10904/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10904/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10904/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10904/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10904/console This message was automatically generated.
        Hide
        arshad.mohammad Mohammad Arshad added a comment -

        The Constants were moved from HdfsConstants to HdfsServerConstants so applied the java doc to contants in HdfsServerConstants

        Show
        arshad.mohammad Mohammad Arshad added a comment - The Constants were moved from HdfsConstants to HdfsServerConstants so applied the java doc to contants in HdfsServerConstants
        Hide
        arshad.mohammad Mohammad Arshad added a comment -

        I will remove whitespace and submit the patch

        Show
        arshad.mohammad Mohammad Arshad added a comment - I will remove whitespace and submit the patch
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 33s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 13s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 13s Pre-build of native portion
        +1 hdfs tests 165m 44s Tests passed in hadoop-hdfs.
            208m 23s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12569055/HDFS-4383.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10717/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10717/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10717/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10717/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 13s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 13s Pre-build of native portion +1 hdfs tests 165m 44s Tests passed in hadoop-hdfs.     208m 23s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12569055/HDFS-4383.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10717/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10717/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10717/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10717/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 32s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 15s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 8s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 11s Pre-build of native portion
        -1 hdfs tests 163m 39s Tests failed in hadoop-hdfs.
            206m 20s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12569055/HDFS-4383.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10711/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10711/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10711/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10711/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 15s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 8s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 11s Pre-build of native portion -1 hdfs tests 163m 39s Tests failed in hadoop-hdfs.     206m 20s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12569055/HDFS-4383.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10711/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10711/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10711/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10711/console This message was automatically generated.
        Hide
        gelesh Gelesh added a comment -

        There are two para comments, and much of the clause are repeating.
        I feel, the older patch (Neethu PL's) was better,
        else Chu Tong , or Neethu PL , could you please try some way to have

        / * For a HDFS client to write to a file, a lease is granted; During the lease
        / * period, no other client can write to the file. The writing client can
        / * periodically renew the lease. When the file is closed, the lease is
        / * revoked.
        / * The lease duration is bound by LEASE_SOFTLIMIT_PERIOD and LEASE_HARDLIMIT_PERIOD

        as a common comment,
        and before each variable , variable specific comment ,

        Just a thought & suggestion, please act on it, if you feel, this way is worth.

        I was just wondering, there is no one till date to respond and review this...

        Show
        gelesh Gelesh added a comment - There are two para comments, and much of the clause are repeating. I feel, the older patch ( Neethu PL 's) was better, else Chu Tong , or Neethu PL , could you please try some way to have / * For a HDFS client to write to a file, a lease is granted; During the lease / * period, no other client can write to the file. The writing client can / * periodically renew the lease. When the file is closed, the lease is / * revoked. / * The lease duration is bound by LEASE_SOFTLIMIT_PERIOD and LEASE_HARDLIMIT_PERIOD as a common comment, and before each variable , variable specific comment , Just a thought & suggestion, please act on it, if you feel, this way is worth. I was just wondering, there is no one till date to respond and review this...
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12569055/HDFS-4383.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3967//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3967//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12569055/HDFS-4383.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3967//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3967//console This message is automatically generated.
        Hide
        stayhf Chu Tong added a comment -

        I added javadoc for soft/hard limits and checked manually.

        Show
        stayhf Chu Tong added a comment - I added javadoc for soft/hard limits and checked manually.
        Hide
        stayhf Chu Tong added a comment -

        @Neethu, hmmmm, why a new file is added in the new patch? Also, I am working on to make both
        softLimit and hardLimit have javadoc, hopefully I can get them done today. If you want, you can take that over, otherwise, I will do it today. Thanks

        Show
        stayhf Chu Tong added a comment - @Neethu, hmmmm, why a new file is added in the new patch? Also, I am working on to make both softLimit and hardLimit have javadoc, hopefully I can get them done today. If you want, you can take that over, otherwise, I will do it today. Thanks
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12568946/HDFS-4383.3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3962//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3962//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568946/HDFS-4383.3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3962//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3962//console This message is automatically generated.
        Hide
        neethu pl Neethu PL added a comment -

        Comments added as per java standards

        Show
        neethu pl Neethu PL added a comment - Comments added as per java standards
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12568756/HDFS-4383.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3960//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568756/HDFS-4383.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3960//console This message is automatically generated.
        Hide
        stayhf Chu Tong added a comment -

        Changed to javadoc style

        Show
        stayhf Chu Tong added a comment - Changed to javadoc style
        Hide
        stevel@apache.org Steve Loughran added a comment -

        text looks OK; needs to be in javadoc format if we want to get it into the javadocs

        Show
        stevel@apache.org Steve Loughran added a comment - text looks OK; needs to be in javadoc format if we want to get it into the javadocs
        Hide
        stayhf Chu Tong added a comment -

        trivial change, no testcase needed.

        Show
        stayhf Chu Tong added a comment - trivial change, no testcase needed.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12568690/HDFS-4383.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3959//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3959//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12568690/HDFS-4383.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3959//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3959//console This message is automatically generated.

          People

          • Assignee:
            arshad.mohammad Mohammad Arshad
            Reporter:
            eli Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            14 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development