[HDFS-4351] Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 3.0.0-alpha1
• Fix Version/s: 1.2.0, 2.0.3-alpha
• Component/s: namenode
• Target Version/s: 1.2.0
• Hadoop Flags: Reviewed
• Assignee: Andrew Wang
• Reporter: Andrew Wang
• Created: 02/Jan/13 20:50
• Updated: 12/May/16 18:19
• Resolved: 07/Jan/13 03:13

Description

There's a bug in BlockPlacementPolicyDefault#chooseTarget with stale node avoidance enabled (HDFS-3912). If a NotEnoughReplicasException is thrown in the call to chooseRandom(), numOfReplicas is not updated together with the partial result in result since it is pass by value. The retry call to chooseTarget then uses this incorrect value.

This can be seen if you enable stale node detection for TestReplicationPolicy#testChooseTargetWithMoreThanAvaiableNodes().